Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56684263:Fastmail
Message-ID: <ae53994a-aaa5-8a57-4284-85000229249d@ryhl.io>
Date:   Thu, 30 Mar 2023 22:28:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v3 08/13] rust: init: add `stack_pin_init!` macro
Content-Language: en-US-large
To:     Benno Lossin <y86-dev@protonmail.com>
Cc:     rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?Q?Bj=c3=b6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Gary Guo <gary@garyguo.net>
References: <20230329223239.138757-1-y86-dev@protonmail.com>
 <20230329223239.138757-9-y86-dev@protonmail.com>
 <ada8307d-5177-2094-683f-bce619f1ea44@ryhl.io>
 <4b048bfc-e4fe-8c2f-ebfe-9b6a410cd8b8@protonmail.com>
From:   Alice Ryhl <alice@ryhl.io>
In-Reply-To: <4b048bfc-e4fe-8c2f-ebfe-9b6a410cd8b8@protonmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/30/23 17:19, Benno Lossin wrote:
> On 30.03.23 17:00, Alice Ryhl wrote:
>> On 3/30/23 00:33, y86-dev@protonmail.com wrote:
>>> From: Benno Lossin <y86-dev@protonmail.com>
>>>
>>> The `stack_pin_init!` macro allows pin-initializing a value on the
>>> stack. It accepts a `impl PinInit<T, E>` to initialize a `T`. It allows
>>> propagating any errors via `?` or handling it normally via `match`.
>>>
>>> Signed-off-by: Benno Lossin <y86-dev@protonmail.com>
>>
>> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
>>
>>> ---
>>> +#[macro_export]
>>> +macro_rules! stack_pin_init {
>>> +    (let $var:ident $(: $t:ty)? = $val:expr) => {
>>> +        let mut $var = $crate::init::__internal::StackInit$(::<$t>)?::uninit();
>>> +        let mut $var = {
>>> +            let val = $val;
>>> +            unsafe { $crate::init::__internal::StackInit::init(&mut $var, val) }
>>> +        };
>>> +    };
>>> +    (let $var:ident $(: $t:ty)? =? $val:expr) => {
>>> +        let mut $var = $crate::init::__internal::StackInit$(::<$t>)?::uninit();
>>> +        let mut $var = {
>>> +            let val = $val;
>>> +            unsafe { $crate::init::__internal::StackInit::init(&mut $var, val)? }
>>> +        };
>>> +    };
>>> +}
>>
>> This will be inconvenient to use if the initializer is infallible and is
>> used inside an infallible function. However, I'm not sure what a better
>> alternative would be. Perhaps we should have three variants?
> 
> That could be an option, any ideas for the syntax though? Or should it
> be a different macro like `stack_pin_init!` and `try_stack_pin_init!`?

You've also split up the other macros into a fallible and infallible 
version, so I think the same would be fine here. Perhaps use 
`stack_pin_try_init!` as the name?

>> Also, maybe a `<-` rather than `=` would be more consistent?
> 
> That is sadly not possible, since `<-` is not allowed after `ty` fragments.
> 
>> Anyway, I don't think this should block the PR. We can revisit it later
>> if it becomes a problem.
> 
> Sure.
> 
> --
> Cheers,
> Benno
> 
>