Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Asmaa Mnebhi <asmaa@nvidia.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Wolfram Sang <wsa@kernel.org>,
        Khalil Blaiech <kblaiech@nvidia.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/1] i2c: mlxbf: Use readl_poll_timeout_atomic() for
 polling
Thread-Topic: [PATCH v1 1/1] i2c: mlxbf: Use readl_poll_timeout_atomic() for
 polling
Thread-Index: AQHZYxA+Y7+smArn/UObFn67jSfa8K8T0Tag
Date:   Thu, 30 Mar 2023 21:10:50 +0000
Message-ID: <CH2PR12MB389550C8CC64A53E256ACC0ED78E9@CH2PR12MB3895.namprd12.prod.outlook.com>
References: <20230330135747.15684-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20230330135747.15684-1-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XwYVKlWqtKBOxgXkjJH9RLI2i937aRpiszyhFhfUbG68sfTur1z4UFqTHG7m?=
 =?us-ascii?Q?MNK1WSGsZXPNHtaYLKyASjfHD0lkg2GdQDbG7CKskJUy6mlkcTR4rdG96Dn4?=
 =?us-ascii?Q?wMqb7U/HGXrk/ac8W4W1B6+6gz5q2sMxivMKSDZV5TAtxWyDxKVpH98doCHL?=
 =?us-ascii?Q?yjP9q3540xRUSOp5iGRlqka/3VOzSmzmkAvi7NerJ8msVfmCjOqzkN965AQ+?=
 =?us-ascii?Q?GqV2S6W7xMCR3rW3FAt+KyAF2391Iy2XZ+NQeILH/9eg2qsFjjQXCXLOeraj?=
 =?us-ascii?Q?QlDVJYGJJXHGx+PKA0Z1U2W7lZuq7X4p6kMWZXIiuaBlAIl3hvzbE0fpGG6/?=
 =?us-ascii?Q?K/jkX/wCMNyX9R4sRTOvnnRvHLJqA7PfoGE0I+2ZoyDiBvjnhyab5SFEQQUr?=
 =?us-ascii?Q?cuXbObhsiaZZzrkRwvlg0tQKnFI+oH4NelpgHzzcOWA1+7UiY26OHuyRlyEE?=
 =?us-ascii?Q?wpHkAQcUI9hrPYcj8lCSbraTnk5B8/cz6VNAy+wq8VH5IFaYwc0tgiknMa6P?=
 =?us-ascii?Q?3HWanlhqOsL57sojFMGkzULJnw9KcMp8MohkVb+GT///DrW0G99zEvv7Lft9?=
 =?us-ascii?Q?KOAg6htJ7ZNpn+Hv/sBq4xhwhfvhtoE8YrN7/iMgZtobMbY98isy+kahue/T?=
 =?us-ascii?Q?+A+7aPCPrnpp8vzwzaVTPwP4G+3yGBFFtSKqj1PKam/MLsai84/AAThFLpuC?=
 =?us-ascii?Q?zw49dgXmBi34EIDTNwlqBFfgD99Y8Ol6Ksajnyqn4isyDn7JSPQO939jtKqs?=
 =?us-ascii?Q?DQwlyl55ab1SDfccziE+EvE8ITc9h9+H9CP8naoCl0aq0U3gzf8kWGsuwQhQ?=
 =?us-ascii?Q?c1kIrLtTfMY9PmvUFvg+34n6hV56RqekIic5g60+47o2SQluyXrz4ExRcWz/?=
 =?us-ascii?Q?JPlVmFdq0nmSD87IX5rcnD/9e0+G9NmBDI3VoxjzZgtkWzR72oKetVMUkKr4?=
 =?us-ascii?Q?53z5Fcks1LqfgBSWN5X5XcYqtVTyYHk4pmVce2h7+LIqVrswFwylcLNCwnxm?=
 =?us-ascii?Q?9WA2hQl7vwb3bxEWc1ye4SmYd6EJ8X/ZOzN5gVl5Aoydz6vrLSU90hK3DN5S?=
 =?us-ascii?Q?DbMwMxl4vT0ekX3wQuOC6T1BnkKPcGBdNHwAllyQYbifrPNM05W8/laXIyah?=
 =?us-ascii?Q?tL0UCALeGum4zGbEnkfnabZ2l+Ndc+yhVKBqFjSXIWEFtp8INwqLF2CuPl4R?=
 =?us-ascii?Q?rzmNeH64rKLYvD8zvonVL2oVwXhoa+BLAAVIlM5au9hp3krrqf7xQnbo+3eB?=
 =?us-ascii?Q?iuZtzvGkk8jI2jXmygF9GzaJxp4YKxJ9y6PmjLe1I2VkUYTlb4Zpc+fpHh+e?=
 =?us-ascii?Q?fBMM/jF8eYZ+d3NtjXzGqoFg8LXY8/TowAK+vgpF7QkwNNZmBKgc4bSLEKrF?=
 =?us-ascii?Q?6NuHTrEp977pmGdxTkqkT4T/DMf7tVnw7lja8nmPHup1a3FGuX3zkiTPZRoe?=
 =?us-ascii?Q?x+O4HfZ3SdHuP0j0OWEt55UHZ6KVZJMguFY6bE458uftWcvd9irOMeSgYZTc?=
 =?us-ascii?Q?N3rEDx0qkUkJr5v3UD9jFwdiH2bba+x7na2eAE1Cf3wu1mvMGHe2GgA+seBR?=
 =?us-ascii?Q?Yykze0lM507QWzV+Gxg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3895.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51a88198-3edc-4f2f-88d3-08db31633d6c
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2023 21:10:50.4781
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ysC2hFruGCPrvzexyJjbhIwo5ACtic14sz9ISFT0S5Zsywhiwpm3gFLhWpn+UxClAiIfDPWuYnuGQVh9t8NVfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8306
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

LGTM besides the small comment below:

> -	/* Check whether the HW is idle */
> -	if (WARN_ON(!mlxbf_i2c_smbus_master_wait_for_idle(priv))) {
> +	/*
> +	 * SW must make sure that the SMBus Master GW is idle before
> starting
> +	 * a transaction. Accordingly, this call polls the Master FSM stop bit;
> +	 * it returns 0 when the bit is asserted, -ETIMEDOUT if not.

It returns 0 when the bit is cleared, -ETIMEDOUT if not.

> +	 */
> +	ret =3D readl_poll_timeout_atomic(priv->mst->io + priv->chip-
> >smbus_master_fsm_off,
> +					bits, !(bits &
> MLXBF_I2C_SMBUS_MASTER_FSM_STOP_MASK),
> +					MLXBF_I2C_POLL_FREQ_IN_USEC,
> MLXBF_I2C_SMBUS_TIMEOUT);
> +	if (WARN_ON(ret)) {
>  		ret =3D -EBUSY;
>  		goto out_unlock;