Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vishnu Dasa <vdasa@vmware.com>
To:     Arseniy Krasnov <AVKrasnov@sberdevices.ru>
CC:     Stefan Hajnoczi <stefanha@redhat.com>,
        Stefano Garzarella <sgarzare@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Bobby Eshleman <bobby.eshleman@bytedance.com>,
        Bryan Tan <bryantan@vmware.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@sberdevices.ru" <kernel@sberdevices.ru>,
        "oxffffaa@gmail.com" <oxffffaa@gmail.com>,
        Pv-drivers <Pv-drivers@vmware.com>
Subject: Re: [RFC PATCH v3 1/4] vsock/vmci: convert VMCI error code to -ENOMEM
 on send
Thread-Topic: [RFC PATCH v3 1/4] vsock/vmci: convert VMCI error code to
 -ENOMEM on send
Thread-Index: AQHZY0R9k4VKb4Rnn0Sv+wxENPcUEK8T2giA
Date:   Thu, 30 Mar 2023 21:40:55 +0000
Message-ID: <728EC7B8-4187-48AC-9FA5-EC757B72FAAF@vmware.com>
References: <a0915a9d-ba41-5a90-0e16-40c2315f0445@sberdevices.ru>
In-Reply-To: <a0915a9d-ba41-5a90-0e16-40c2315f0445@sberdevices.ru>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mfqRiTpQo2X7gugAaG8fdKqMQnaxXN77V6XDWCBmpfnlODMP/PGXwAcXZLbP?=
 =?us-ascii?Q?hcpGx/i9jlJDYGkdOSc4b2/p0i+LfGV/5pAbhjr7PQpmYIpIY2E2EuS695mZ?=
 =?us-ascii?Q?vJmcymKWo50YJDJbQ9zHaLacwbjUb1RzoujdLZUs+c32GkhFzBjLvc2NSAa+?=
 =?us-ascii?Q?aJ0m6KHtTusDPmJumhl+TY3My/yCplLpmGRotpeWY84U4QLs+SYWlPd7yYH3?=
 =?us-ascii?Q?wzWaZwFnieluZkQYwAX25T43tDFsfAUp2aJ2AKbrKdDnNcmAqXGaFhvw9oqS?=
 =?us-ascii?Q?93UPk+kiocbK4QH9lD2Jkh+eKsdYxTaMT95LYI8QIaRYPruNDhhOX8gjttIL?=
 =?us-ascii?Q?CMPckCMbUtq4CF9c8d2OVB0OIw3kH0LBpjzUKHdZ3Z/yXTHM9cXVCHKvz9ft?=
 =?us-ascii?Q?Ix0oDva3l9p8BTsRhGDdNUd2JI9r9O5ur+6tpAMJLl0rOGFioWGkTWVQKzID?=
 =?us-ascii?Q?Vd5TiAl7FMjQ9C0gXU6dquhRN/Z2SAWOMDcSYp25osqCUoJ1yjxjRaM4t4Tm?=
 =?us-ascii?Q?hnt1beCF0Gr3F8SQMgR+hgLAqeCjp/xYgOxsU7C0mR96SeTiChGQH9M+YeW0?=
 =?us-ascii?Q?xFE9QLxsyWfrE7OEqtAYMKzMOQ4JolNBNrNZKOOKOCKOse4gvWXbfkmKgPCp?=
 =?us-ascii?Q?6HdGstWhiKde7e/5lyuHuOa3n8F0BEuLPtNa9+JJWJjh+uqhVfWUL7q1tkwe?=
 =?us-ascii?Q?JOhPXFx45RcJ+ya2m9RtGB35cJu1TBUlYBs31ff4OkyDbheBA8lPEP5ugK/N?=
 =?us-ascii?Q?drSO/w/ZodfCs6THJfSSljfjnuYsuZguTRAfEPNKxAjKiUnDktxLPjMwXlXy?=
 =?us-ascii?Q?2LdgRJ3IBCr+G3pEnbajT/JJw8j6B3sV8cyg4qKwfj9tKJzDvHkIdPu+pc2z?=
 =?us-ascii?Q?clbd/rk2+ghUJ6Qq4yo2dkjS2S7mym4AGDGS73K1G3ooPi1CWUQ3wbTzuF8t?=
 =?us-ascii?Q?QXKqL416MZaBRK8SS6afsT5JhmwqP42N7qnPORwK3o7jZNXi5ugnSEkAnX9F?=
 =?us-ascii?Q?yxFa7G/vWusCZuRH/e4vdAWgbpW2rZBKHmAvr+k6WKrUuuTKHAugOyvYpxl0?=
 =?us-ascii?Q?tpGtEcrELy35l+dOY3MbnPcRagRY0iP7si85ON7V+9GAXXDIxRQrGc21M7eh?=
 =?us-ascii?Q?n6FvAPAzeS5Vf1pnZC7oqcseatHCD50c5e5Ww5fLM8H89v6EWXGzPJQWMLT3?=
 =?us-ascii?Q?Um+PKltrYNtto7oKHzs/iHCGpyU7W5I98FV+ujVMi28fymJt2UkqVGLh1DkW?=
 =?us-ascii?Q?oMjoRyCKNMssypjWvrNLpBi0MLUEPHf/YtULesRlzcYssjnWaUhBIP/Eyh08?=
 =?us-ascii?Q?6cQX4TlhBSFT1L4oteNu4XDe1noTk7+Rm80Dc+Gg/HELU+WL7QSySCxLPqRx?=
 =?us-ascii?Q?JCl8T0Sr8VUiYEzJeeywRO7o/XZEuNOjqcMDsYAGwwHAvPzhM4HP34J7LACb?=
 =?us-ascii?Q?/uQv4EsyqwJmG6Bz02XdIsLdj/AkNkRgiwo74cJB21VzpWyO6qpnLHs5n6x4?=
 =?us-ascii?Q?Sl4wVfIYpP1sBgwrnGdByQ467ZHQn+sKumHA0OEbak1wTi5e8iaNvLPKpLxz?=
 =?us-ascii?Q?JJDf2Rqedo2Fwv9yTS5V4UKkl+Vith4QAUkq0fFj1MxDX8l2BZJLbERoPPFw?=
 =?us-ascii?Q?HEYh9WI9F2cTplUELp78ZPiH5RjNrS/zD/q+gaHvEx9L?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <07F523487DDF6F41AF6F43243A6AD33B@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB3960.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a70be3d-3ed6-417c-e09c-08db3167718c
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2023 21:40:55.9514
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2WxMxGCcQWHyGf6ldEowWyEvjKS0wZdRvNmVoDO6+wPI8QTgNJt5IyAt6msZGPUUtxoW4I4KZQzxMV9XnlknSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR05MB8481
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mar 30, 2023, at 1:12 PM, Arseniy Krasnov <AVKrasnov@sberdevices.ru> w=
rote:
>=20
> !! External Email
>=20
> This adds conversion of VMCI specific error code to general -ENOMEM. It
> is needed, because af_vsock.c passes error value returned from transport
> to the user, which does not expect to get VMCI_ERROR_* values.
>=20
> Fixes: c43170b7e157 ("vsock: return errors other than -ENOMEM to socket")
> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>

Thanks, looks good to me.

Reviewed-by: Vishnu Dasa <vdasa@vmware.com>

> ---
> net/vmw_vsock/vmci_transport.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transpor=
t.c
> index 36eb16a40745..95cc4d79ba29 100644
> --- a/net/vmw_vsock/vmci_transport.c
> +++ b/net/vmw_vsock/vmci_transport.c
> @@ -1842,7 +1842,13 @@ static ssize_t vmci_transport_stream_enqueue(
>        struct msghdr *msg,
>        size_t len)
> {
> -       return vmci_qpair_enquev(vmci_trans(vsk)->qpair, msg, len, 0);
> +       ssize_t err;
> +
> +       err =3D vmci_qpair_enquev(vmci_trans(vsk)->qpair, msg, len, 0);
> +       if (err < 0)
> +               err =3D -ENOMEM;
> +
> +       return err;
> }
>=20
> static s64 vmci_transport_stream_has_data(struct vsock_sock *vsk)
> --
> 2.25.1
>=20
> !! External Email: This email originated from outside of the organization=
. Do not click links or open attachments unless you recognize the sender.