Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vishnu Dasa <vdasa@vmware.com>
To:     Arseniy Krasnov <AVKrasnov@sberdevices.ru>
CC:     Stefan Hajnoczi <stefanha@redhat.com>,
        Stefano Garzarella <sgarzare@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Bobby Eshleman <bobby.eshleman@bytedance.com>,
        Bryan Tan <bryantan@vmware.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@sberdevices.ru" <kernel@sberdevices.ru>,
        "oxffffaa@gmail.com" <oxffffaa@gmail.com>,
        Pv-drivers <Pv-drivers@vmware.com>
Subject: Re: [RFC PATCH v3 2/4] vsock/vmci: convert VMCI error code to -ENOMEM
 on receive
Thread-Topic: [RFC PATCH v3 2/4] vsock/vmci: convert VMCI error code to
 -ENOMEM on receive
Thread-Index: AQHZY0Sj2XCJ41BR6k66SiCaGaLi868TwxQAgAAZQ4A=
Date:   Thu, 30 Mar 2023 21:49:12 +0000
Message-ID: <B95BC5A0-EB56-4921-8FFB-C41CFB7929C5@vmware.com>
References: <4d34fac8-7170-5a3e-5043-42a9f7e4b5b3@sberdevices.ru>
 <9fd06ca5-ace9-251d-34af-aca4db9c3ee0@sberdevices.ru>
In-Reply-To: <9fd06ca5-ace9-251d-34af-aca4db9c3ee0@sberdevices.ru>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hff6RxoN0jvfRuPk1WS8cm3OL2lU1TAD0V1/yiiNJysj418BkL3AlmxIl8WG?=
 =?us-ascii?Q?VuVUWFluuU/QtP4fPfHAj7D5xs1gmg5k7LMpPr0nM6a/Sq37pNyZqv4cJjel?=
 =?us-ascii?Q?IGcactGidOCkLuNV1JeONUAloBFXsuR8M9buWWrErYL2s3BI9EG+NdgK4w+j?=
 =?us-ascii?Q?gO/u0rmkFSKpYpfdqR22qeMg5U4HxON8WPMw3BYI/2mQMcQ6v/p36z4iRPGt?=
 =?us-ascii?Q?Wn7OkSfgvDeJpXZr7Dr3VFx0Fo8UwYDyHuO2fqMDf+DiucIU2PBseGlJKYJQ?=
 =?us-ascii?Q?ndghNbK5/nKO8wNevUtNKtx1/MXpPKSvAMatDnfXK9fnsxIQrL2Im43jBtdf?=
 =?us-ascii?Q?zSD8gx3ky1lXlOZ6H8hQqykEIhpSQjfi2xhx/lBp0ytnXR1lQqIE5fWGV483?=
 =?us-ascii?Q?+5HdRh3tv2arEnoUooJM/E27gFSXhpYG07WzY4kd8q19Spgz6/a5Gcrk4hfK?=
 =?us-ascii?Q?BJBcIuLPKGlGvg8MUSX1oYN25DjE6JNiQV47HOiq/0RMXPljbkOUVRb8dpsv?=
 =?us-ascii?Q?FPlreTC5KPDQtpjiZprAItqUPjspLNmTGZWfqx7OHeDYUW1qYKwnsjcPyEeX?=
 =?us-ascii?Q?jiy0aBfPxov1Y8o1TTxFooohucQspTMtXCOvxu/DG/8OpxfDsHQPxx+66YyE?=
 =?us-ascii?Q?aH83gq72Fy4RIroK9n6fpHa3ykbxBI8B64VmK9UkOua1N6/zNDd2TOGaH4lv?=
 =?us-ascii?Q?ZI6VK84k9DZ5FAvEloin50nqzhWUHMuKubddh6SUrtDZnjnHa2ODqC+E4XQN?=
 =?us-ascii?Q?H7Idd8WIGLokIxxzPtWV1YAn7VfJyWmGsNDhyjSGN+GGt7i7Y0Z5+XDFMg5l?=
 =?us-ascii?Q?jBnddKxqdZO18bmHZp4zwQhHmncVxg+UuOqaGlENdoQfVS4Xlz7hUQQM3nB4?=
 =?us-ascii?Q?AS/xeRH5Nx8kTcTDdJ11qxH9vNC5vSW4+bUTJ3926ZByJ5ZITyU1CDQGOW1p?=
 =?us-ascii?Q?Ztw2GdaBLMPZ406K4oeYPp0S7ji1B57e5mSTcfOifAlY8YHaU/zj8hNmNftq?=
 =?us-ascii?Q?HAN6GUWJUxzYkIZ80oDFKeijgGnonVm0M2JCwFBUzNQwY2aEWLL2bM5esX0x?=
 =?us-ascii?Q?wSoCydq+YUKUNg1C5/+X4OyMbWdX7rWUI7I52l8Vqj3gBtJ9PxAjNnjm/P9O?=
 =?us-ascii?Q?N1Lnewqm72k+0mDW+N2CP4NvuJUCYQHuY4o2WGpIgpAYKyFZZtpzrIBhG9we?=
 =?us-ascii?Q?YhuP8UEbDHOuw6wNbQiGryTtrey9DTf4NdwhuD9+NN9yTBoMhnq2dE6nb2d9?=
 =?us-ascii?Q?L6Q0VQgP/KsSLjc5xSz9gVSeDwkNPmiepRewzM/TTnkhxg6dHH8bKx5jgfFe?=
 =?us-ascii?Q?2OePr9/XU3721mxtP6+ANR0dWS15vyi65y2u6HlxiQA3YuqngFWwW4jYR/8Z?=
 =?us-ascii?Q?aT9EragZzHbIALf15zH0eNdg2dtUWldK171lE1SsaGekvwRqOJmGQb3iHDEO?=
 =?us-ascii?Q?cJwe6waGUtJb7UDHSlTsKlST1A19DJ9DPK6Cdj4Fes7qxEsHg+jCoBt8wo4W?=
 =?us-ascii?Q?HmGX04Yx9EA0F/GWvclEVd9/pscN4vhWnsdmq8Q6RymtkIFeQTl8yM7H7Rbx?=
 =?us-ascii?Q?D1bgolC+F/ERzYcLoM9ruCD7Yn2IBOBw8Or9fJU/FgKi7kihV3dEmNifN/GC?=
 =?us-ascii?Q?b+2+C3SCqB6j/7/7454II4mPkh4nmggTLTFfxN3jTYxL?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <498EA72511E78B44B30020065927A9BB@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB3960.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0241472e-c164-496a-9c6f-08db3168997e
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2023 21:49:12.4038
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CUfRSDBZBBWNAFJurx6q5xdoUA6SMr4KAyop6RR+uhLqVBFui+C1RmIKgBsk72Kmb+99pNzqLeL3QBhldx0kfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0501MB3885
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mar 30, 2023, at 1:18 PM, Arseniy Krasnov <AVKrasnov@sberdevices.ru> w=
rote:
>=20
> !! External Email
>=20
> On 30.03.2023 23:13, Arseniy Krasnov wrote:
>> This adds conversion of VMCI specific error code to general -ENOMEM. It
>> is needed, because af_vsock.c passes error value returned from transport
>> to the user, which does not expect to get VMCI_ERROR_* values.
>=20
> @Stefano, I have some doubts about this commit message, as it says "... a=
f_vsock.c
> passes error value returned from transport to the user ...", but this
> behaviour is implemented only in the next patch. Is it ok, if both patche=
s
> are in a single patchset?
>=20
> For patch 1 I think it is ok, as it fixes current implementation.
>=20
> Thanks, Arseniy
>=20
>>=20
>> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>

Code change looks good to me.  Will let you figure out the commit message
with Stefano. Thanks!

Reviewed-by: Vishnu Dasa <vdasa@vmware.com>

>> ---
>> net/vmw_vsock/vmci_transport.c | 11 +++++++++--
>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>=20
>> diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transpo=
rt.c
>> index 95cc4d79ba29..b370070194fa 100644
>> --- a/net/vmw_vsock/vmci_transport.c
>> +++ b/net/vmw_vsock/vmci_transport.c
>> @@ -1831,10 +1831,17 @@ static ssize_t vmci_transport_stream_dequeue(
>>      size_t len,
>>      int flags)
>> {
>> +     ssize_t err;
>> +
>>      if (flags & MSG_PEEK)
>> -             return vmci_qpair_peekv(vmci_trans(vsk)->qpair, msg, len, =
0);
>> +             err =3D vmci_qpair_peekv(vmci_trans(vsk)->qpair, msg, len,=
 0);
>>      else
>> -             return vmci_qpair_dequev(vmci_trans(vsk)->qpair, msg, len,=
 0);
>> +             err =3D vmci_qpair_dequev(vmci_trans(vsk)->qpair, msg, len=
, 0);
>> +
>> +     if (err < 0)
>> +             err =3D -ENOMEM;
>> +
>> +     return err;
>> }
>>=20
>> static ssize_t vmci_transport_stream_enqueue(
>=20
> !! External Email: This email originated from outside of the organization=
. Do not click links or open attachments unless you recognize the sender.