Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <11215033-fa3c-ecb1-2fc0-e9aeba47be9b@infradead.org> <af6281f5-9c6c-d2d7-5978-b637b8d18473@loongson.cn>
In-Reply-To: <af6281f5-9c6c-d2d7-5978-b637b8d18473@loongson.cn>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Fri, 31 Mar 2023 10:17:59 +0800
Message-ID: <CAAhV-H5+GCi76aC=Mk3aoHqP5qEWhjQvBtwLGGtuBLXL1ardjA@mail.gmail.com>
Subject: Re: loongarch wakeup build error
To:     Tiezhu Yang <yangtiezhu@loongson.cn>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        WANG Xuerui <kernel@xen0n.name>, loongarch@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Tiezhu,

On Thu, Mar 30, 2023 at 11:33=E2=80=AFAM Tiezhu Yang <yangtiezhu@loongson.c=
n> wrote:
>
>
>
> On 03/30/2023 06:55 AM, Randy Dunlap wrote:
> > Hi,
> >
> > I don't know if this has been reported previously, so here goes.
> >
> > When CONFIG_SUSPEND is not set:
> >
> > loongarch64-linux-ld: drivers/acpi/sleep.o: in function `acpi_pm_prepar=
e':
> > sleep.c:(.text+0x278): undefined reference to `loongarch_wakeup_start'
> > loongarch64-linux-ld: sleep.c:(.text+0x27c): undefined reference to `lo=
ongarch_wakeup_start'
> > loongarch64-linux-ld: sleep.c:(.text+0x27c): undefined reference to `lo=
ongarch_wakeup_start'
> >
> > A complete randconfig file is attached.
> >
>
> I can reproduce this build error on LoongArch.
>
> Here is the call trace:
>
> acpi_pm_prepare()
>    __acpi_pm_prepare()
>      acpi_sleep_prepare()
>        acpi_get_wakeup_address()
>          loongarch_wakeup_start()
>
>
> loongarch_wakeup_start() is defined in arch/loongarch/power/suspend_asm.S
> which is built under CONFIG_SUSPEND. In order to fix the build error, jus=
t
> define a empty loongarch_wakeup_start() if CONFIG_SUSPEND is not set.
>
> diff --git a/arch/loongarch/include/asm/acpi.h
> b/arch/loongarch/include/asm/acpi.h
> index 4198753aa1d0..7b812a836a5a 100644
> --- a/arch/loongarch/include/asm/acpi.h
> +++ b/arch/loongarch/include/asm/acpi.h
> @@ -39,9 +39,14 @@ extern int loongarch_acpi_suspend(void);
>   extern int (*acpi_suspend_lowlevel)(void);
>   extern void loongarch_suspend_enter(void);
>
> +#ifdef CONFIG_SUSPEND
> +extern void loongarch_wakeup_start(void);
> +#else
> +static inline void loongarch_wakeup_start(void) {}
> +#endif
> +
>   static inline unsigned long acpi_get_wakeup_address(void)
>   {
> -       extern void loongarch_wakeup_start(void);
>         return (unsigned long)loongarch_wakeup_start;
>   }
>
> If the above change makes sense, I will send a formal patch later.
No, we should make sure acpi_get_wakeup_address() return 0, not a
random address [1]. But my version reuse your commit messages, thank
you all the same.

[1] https://github.com/loongson/linux/commit/49d888dce72e2dc094c9ac39702bbe=
058b89ed79

Huacai
>
> Thanks,
> Tiezhu
>
>