Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 20:07:16 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Zhao Liu <zhao1.liu@linux.intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthew Auld <matthew.auld@intel.com>,
        Thomas =?iso-8859-1?Q?Hellstr=F6m?= 
        <thomas.hellstrom@linux.intel.com>,
        Nirmoy Das <nirmoy.das@intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
CC:     Ira Weiny <ira.weiny@intel.com>,
        "Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
        Zhenyu Wang <zhenyu.z.wang@intel.com>,
        Zhao Liu <zhao1.liu@intel.com>,
        Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH v2 5/9] drm/i915: Use kmap_local_page() in
 gem/selftests/i915_gem_coherency.c
Message-ID: <64264e64af269_375f7e2948f@iweiny-mobl.notmuch>
References: <20230329073220.3982460-1-zhao1.liu@linux.intel.com>
 <20230329073220.3982460-6-zhao1.liu@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230329073220.3982460-6-zhao1.liu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lDl0M1m1FSm+fMTFzBcgHiS9zvYbJ0ByXTidA5I0Lvp/a0VyAwwe7Npj51ez?=
 =?us-ascii?Q?fAFWEAg14HlawrdOtBtDxZQeFAvZpsfXk3SMXqjDbcG3Xco5pVPczGKOuIC+?=
 =?us-ascii?Q?aT0RIhsa3kyg8baFgEnKClx6+cW7alSq34ehZ5prvqlNAZNuFuvmQHM5lKpf?=
 =?us-ascii?Q?xkeZlSq6nWxXFrqVpTN2gxDFy7eaM9MogG1EcZU/pXmuN4ejsPDka5ZMOZBA?=
 =?us-ascii?Q?lHNlJA1/KlPAom6JE4SYIuVCkCd0waJBYyMfxL/7fkLGF+jBdtNNrrhLy7RC?=
 =?us-ascii?Q?JZxEOBrwJe+xiRjKLKED3DGuL/MTtNmr/9vOnrMAnMM5ZS8MUvvJy/RJp+fq?=
 =?us-ascii?Q?kdVOo5PtANfF22I4TiD6cloTeib3MVeNqjJs69xpIfoHX0gUNMN+XleuN9dI?=
 =?us-ascii?Q?b+F+zc9lA1mMYwRKeTLK2boljQpwEAfHCuXTRyHtScUBrEijwdOUFFSmC0SJ?=
 =?us-ascii?Q?x0Ynk90Mj9bPOMR1AjSxFXsU30SAN0H9Ud1BOLXFzvQp06x2SQjhF1LWIKEG?=
 =?us-ascii?Q?qnlnJaYf9AVhOo8VxrqCMVYJC951gAmhLjdlrJrLQ3xiojyaSWqw421x5nzV?=
 =?us-ascii?Q?dx+EcXs3FH39IjtUQRxe8/YHkmjpdW1fK6cAMRVw0j6kZCg7yTzJLILAHXaH?=
 =?us-ascii?Q?U+6lig6yW80rgUW7mL0grP3ToKu3Vs4Jkg6oMGwlgmsbLAUel5UxmnSC3/76?=
 =?us-ascii?Q?jKn8h4KE9d4Hv8dwLuZVx8Wtrph2IqEDaMKGGIrZ3sbLy7nEu9p2vDgRRQ6T?=
 =?us-ascii?Q?7H37W3pxIGjoPmk1Xuu0jQZXfH+uBoEHE4oESJ/sJTCbR2M3415ztWO9Sd6O?=
 =?us-ascii?Q?BeVboGZHU3WJ7NsOje4X9QcHjNHi3wGsn8UGe+uK3aZPe4OMIbvmz2CUmDlk?=
 =?us-ascii?Q?4hvuSx2r78xB8HVJIDWt9rnBi7lQ8qi4QVbugULT0l3sXa9v0rYquiV+QY1V?=
 =?us-ascii?Q?l6GQswVO0ION1ZTqV2hvrZJGIa2/uPW/G+6VAULD6pPCKQGw+iqih8BjFI2u?=
 =?us-ascii?Q?tXdmaI5jFr/yYcirquOFPjg5s0cuDZNHTmWgQjuEKXf/N2sXdY0cdEopeKpR?=
 =?us-ascii?Q?fFTezVY0Du4Gv7HvhZcqGbRXkHGRete9IrW4afK0f6mL2XUA+IBoQ2k5SWbc?=
 =?us-ascii?Q?CRw1mhEngX5VHTHLhpBRv+GAMh48Znja1x4AEDE0K+QE4vF34l/yaK+LJVe3?=
 =?us-ascii?Q?1Vo0YiBHVxJhJR8xuAksyv9iLIkYpul0ys8Qi+MI1m3tFH1CPDzymq6+SCOy?=
 =?us-ascii?Q?i8GESiVn6c+zHad38yBjA+FHiUIak+Gh5qiQRGi9nrSAjXRktbOEdVa9AGjG?=
 =?us-ascii?Q?IibenujZqk5WAZMLFZvvUqMbNHOobGTo/eGzGKqVDENkGUg4tpH9IQt8aSaI?=
 =?us-ascii?Q?ofrjML+V2OUcnLqgUrBMBJXH5XRnlK8RikEynH7I+KTLBxYhx2Dpy/5Ktyx6?=
 =?us-ascii?Q?W75c8nrtoArp1hLwBy/yG2FYkkU2BfdTTyWyiKFc9w5ElWKw7WQw6zSwaPTL?=
 =?us-ascii?Q?WzlCE84Grg5vLQjFnV0f0GTv/ePYLbxgQJYYEhlDBSlduQ0xfIcZpTttPpF0?=
 =?us-ascii?Q?Z3RqR7PTGhJMIkn06T6YX9wCwSnmOQXo9vE3FaSU?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 95898138-89f1-4400-7358-08db31950b62
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 03:07:21.5891
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3EnY8701u30lcv8V+GcjP9lFH67jYkoWVjGQ7wOTtyVeeAi51GkzG9zXT8nrm/tHzCGL1iE5U91ydQXfh3i5PQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8303
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1], and this patch converts the call from
> kmap_atomic() to kmap_local_page().
> 
> The main difference between atomic and local mappings is that local
> mappings doesn't disable page faults or preemption (the preemption is
> disabled for !PREEMPT_RT case, otherwise it only disables migration)..
> 
> With kmap_local_page(), we can avoid the often unwanted side effect of
> unnecessary page faults or preemption disables.
> 
> In drm/i915/gem/selftests/i915_gem_coherency.c, functions cpu_set()
> and cpu_get() mainly uses mapping to flush cache and assign the value.
> There're 2 reasons why cpu_set() and cpu_get() don't need to disable
> pagefaults and preemption for mapping:
> 
> 1. The flush operation is safe. cpu_set() and cpu_get() call
> drm_clflush_virt_range() to use CLFLUSHOPT or WBINVD to flush. Since
> CLFLUSHOPT is global on x86 and WBINVD is called on each cpu in
> drm_clflush_virt_range(), the flush operation is global.
> 
> 2. Any context switch caused by preemption or page faults (page fault
> may cause sleep) doesn't affect the validity of local mapping.
> 
> Therefore, cpu_set() and cpu_get() are functions where the use of
> kmap_local_page() in place of kmap_atomic() is correctly suited.
> 
> Convert the calls of kmap_atomic() / kunmap_atomic() to
> kmap_local_page() / kunmap_local().
> 
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com
> 
> v2:
> * Dropped hot plug related description since it has nothing to do with
>   kmap_local_page().
> * No code change since v1, and added description of the motivation of
>   using kmap_local_page().
> 
> Suggested-by: Dave Hansen <dave.hansen@intel.com>
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>