Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 20:33:27 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Zhao Liu <zhao1.liu@linux.intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthew Auld <matthew.auld@intel.com>,
        Thomas =?iso-8859-1?Q?Hellstr=F6m?= 
        <thomas.hellstrom@linux.intel.com>,
        Nirmoy Das <nirmoy.das@intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
CC:     Ira Weiny <ira.weiny@intel.com>,
        "Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
        Zhenyu Wang <zhenyu.z.wang@intel.com>,
        Zhao Liu <zhao1.liu@intel.com>,
        Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH v2 6/9] drm/i915: Use kmap_local_page() in
 gem/selftests/i915_gem_context.c
Message-ID: <642654876a503_375f7e294e@iweiny-mobl.notmuch>
References: <20230329073220.3982460-1-zhao1.liu@linux.intel.com>
 <20230329073220.3982460-7-zhao1.liu@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230329073220.3982460-7-zhao1.liu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HMn8hFxIZz2vxlrFmnjuMcGWWaWhgOZc6apR6zFGCwNeSvgsldYskcCAxycr?=
 =?us-ascii?Q?u7EjM+Xg50TyXQ7P+wx1Ge+J/CkUxlNdOyXaHCDz4vYX6RIU9vGaXW6NH53d?=
 =?us-ascii?Q?PG9rs1hjojXrn057N1ZlhOpaUXkqSScP5E5hy2dA8BVNfVLA9QlPSqxO6/03?=
 =?us-ascii?Q?7JDlcJAP35t3uSo80cV2fv7OKCUnd8EGytOaExzyJS0De0auxV+YmngsBMhW?=
 =?us-ascii?Q?psR/zT8pyPPrwDTCS6tpVH5GX99/EkAfXhi2BnCJpDdnNJDrxzsN0lPM3pbZ?=
 =?us-ascii?Q?WBosiur6SGwbwmkQns9dfpEe9aZxzuw+z+sfkFtCup/NGYh50cjL0CBZoq/v?=
 =?us-ascii?Q?tWMIEPEVq437f1XbhbfXvhhYpNGUJMnffkL0yxIKesR2X98X8uidtZAsgdjE?=
 =?us-ascii?Q?pQtSE8k47r+zq78Vns+zBLNIXOZ2pG7MUk5B5L0hpbpTAE3560y/CrJzat6v?=
 =?us-ascii?Q?BxYBpaDzSVsb8KD6pgrCvUmc473R+5KUUU6ckCWuXIvM1q61IeYjuG7Wb9Fu?=
 =?us-ascii?Q?xgSaAz6naW0EKc644J7r5w/YqvNiAHltzaEDnku2RdTAnD2h8CBY8PNXxZbO?=
 =?us-ascii?Q?3QWiM4t89aScKsspvprQIvv4tCVwjt7fOzwZ4P/AStlobGnMr6Z8xMzfoVsd?=
 =?us-ascii?Q?xZtkpJeKY93SYB5jrZL554GDaDQVx6TUK38Nnqsg+olaJOGBptheY+EppRgq?=
 =?us-ascii?Q?0RWGVaWbqu5Tuv4W4JZNlVPcFv/F9kRMqKKABjMTlMybISuwwDIx0Drn846Z?=
 =?us-ascii?Q?582DCBHjnmx6ljY7ksWcfYsPN3VSv3r/ZDBlk2XNQTc5EmNDrZkytYz9uVVv?=
 =?us-ascii?Q?axeCB8dpLsjEAPZID9KSZ3g3opyttyQyqg7U8QpT8svmyMqFy7jGcljZ1eHC?=
 =?us-ascii?Q?+A4PCwcRZy3CV7M6gRJHhs5ghTdoXEgLOPUJ7vi5g5mPqIA0U933JRpT6/Yr?=
 =?us-ascii?Q?K994jueTDU1BuP2cOUlDQ0W4Q1AIJ9vBOLsWbv0lTvLMPopcDNoKoT5b2Cd1?=
 =?us-ascii?Q?uCnDM+DYLoPjcn9HLJvi11Gs5gxgn6NWJr7+vumt8LFsLe5J1X596JYF/IKe?=
 =?us-ascii?Q?yI7DoPzXFQOufCyu968ZQmLxS51Lmqz0E0pa6fpjIoNLR6qnXeFCOWkcXOlv?=
 =?us-ascii?Q?f4H6k/JLmnTl6ALD9CYSUpiOZtKIkJ9org3GBvOXG+Hgiv7FMYRVdinuqdHZ?=
 =?us-ascii?Q?PrxcOpNg4hcUkmnU/0j0qvPw/qwKP4w8akJiVUHa+JT2afOGKqBo0IxcRon9?=
 =?us-ascii?Q?KG0ZPTnWucSG9fB6IZkWvNpDR+sb1z6QvcxVXIBD/VUYn92+liKLOO5TjyIe?=
 =?us-ascii?Q?FGwu8eKFkszautwjzxL8SzV+gvDCqz8BZKossoY+D9SpzxcXTR7eaOaPwdZI?=
 =?us-ascii?Q?0t7RDW8a+u9Y/4yK98MYXdo/AERyy4CgqnHXkrB13ywJKZTxDhodcuza8eZE?=
 =?us-ascii?Q?w9p8/3ek/e9+CJBTc15xQay5XWCiZURRsTyD7TD6TUA+eDzsOVV7vFQoQZxy?=
 =?us-ascii?Q?/PbJD57Sf3DOiJuZ7i+SIbMFlhLfi59sWOsyxIOPZwLu2rF/ajI3nqMKNyW9?=
 =?us-ascii?Q?6LO2Cv3zZ3b5GxyL0bI88qo/A2RUsiYSKlew/GGX?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 822d6e08-1489-4996-d110-08db3198b3a5
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 03:33:32.3907
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +AT3HilBv4kYx1+rcXQ31cF4d5U+/PByCeSWWKQpIwj7PPRGX687u3jkT5szZuyleM+8No47MzA3FejVljudDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6411
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1], and this patch converts the call from
> kmap_atomic() to kmap_local_page().
> 
> The main difference between atomic and local mappings is that local
> mappings doesn't disable page faults or preemption.
> 
> With kmap_local_page(), we can avoid the often unwanted side effect of
> unnecessary page faults or preemption disables.
> 
> In drm/i915/gem/selftests/i915_gem_context.c, functions cpu_fill() and
> cpu_check() mainly uses mapping to flush cache and check/assign the
> value.
> 
> There're 2 reasons why cpu_fill() and cpu_check() don't need to disable
> pagefaults and preemption for mapping:
> 
> 1. The flush operation is safe. cpu_fill() and cpu_check() call
> drm_clflush_virt_range() to use CLFLUSHOPT or WBINVD to flush. Since
> CLFLUSHOPT is global on x86 and WBINVD is called on each cpu in
> drm_clflush_virt_range(), the flush operation is global.
> 
> 2. Any context switch caused by preemption or page faults (page fault
> may cause sleep) doesn't affect the validity of local mapping.
> 
> Therefore, cpu_fill() and cpu_check() are functions where the use of
> kmap_local_page() in place of kmap_atomic() is correctly suited.
> 
> Convert the calls of kmap_atomic() / kunmap_atomic() to
> kmap_local_page() / kunmap_local().
> 
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com
> 
> v2:
> * Dropped hot plug related description since it has nothing to do with
>   kmap_local_page().
> * No code change since v1, and added description of the motivation of
>   using kmap_local_page().
> 
> Suggested-by: Dave Hansen <dave.hansen@intel.com>
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

First off I think this is fine.

But as I looked at this final selftests patch I began to wonder how the
memory being mapped here and in the previous selftests patches are
allocated.  Does highmem need to be considered at all?  Unfortunately, I
could not determine where the memory in the SG list of this test gem
object was allocated.

AFAICS cpu_fill() is only called in create_test_object().  Digging into
huge_gem_object() did not reveal where these pages were allocated from.

I wonder if these kmap_local_page() calls could be removed entirely based
on knowing that the pages were allocated from low mem?  Removing yet
another user of highmem altogether would be best if possible.

Do you know how these test objects are created?  Do the pages come from
user space somehow?

Regardless this is still a step in the right direction so:

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> Suggested by credits:
>   Dave: Referred to his explanation about cache flush.
>   Ira: Referred to his task document, review comments and explanation
>        about cache flush.
>   Fabio: Referred to his boiler plate commit message and his description
>          about why kmap_local_page() should be preferred.
> ---
>  drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index a81fa6a20f5a..dcbc0b8e3323 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -481,12 +481,12 @@ static int cpu_fill(struct drm_i915_gem_object *obj, u32 value)
>  	for (n = 0; n < real_page_count(obj); n++) {
>  		u32 *map;
>  
> -		map = kmap_atomic(i915_gem_object_get_page(obj, n));
> +		map = kmap_local_page(i915_gem_object_get_page(obj, n));
>  		for (m = 0; m < DW_PER_PAGE; m++)
>  			map[m] = value;
>  		if (!has_llc)
>  			drm_clflush_virt_range(map, PAGE_SIZE);
> -		kunmap_atomic(map);
> +		kunmap_local(map);
>  	}
>  
>  	i915_gem_object_finish_access(obj);
> @@ -512,7 +512,7 @@ static noinline int cpu_check(struct drm_i915_gem_object *obj,
>  	for (n = 0; n < real_page_count(obj); n++) {
>  		u32 *map, m;
>  
> -		map = kmap_atomic(i915_gem_object_get_page(obj, n));
> +		map = kmap_local_page(i915_gem_object_get_page(obj, n));
>  		if (needs_flush & CLFLUSH_BEFORE)
>  			drm_clflush_virt_range(map, PAGE_SIZE);
>  
> @@ -538,7 +538,7 @@ static noinline int cpu_check(struct drm_i915_gem_object *obj,
>  		}
>  
>  out_unmap:
> -		kunmap_atomic(map);
> +		kunmap_local(map);
>  		if (err)
>  			break;
>  	}
> -- 
> 2.34.1
>