Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp639545rwl; Thu, 30 Mar 2023 23:34:41 -0700 (PDT) X-Google-Smtp-Source: AKy350bDMHLiMwT8mmZQzjhaVt8WH327uOQKHePZ41KACQPLcn2LXObN5Af2w8dFlElJpPJA2+Gc X-Received: by 2002:a05:6a20:1585:b0:d9:a977:fae with SMTP id h5-20020a056a20158500b000d9a9770faemr5265229pzj.3.1680244481076; Thu, 30 Mar 2023 23:34:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680244481; cv=none; d=google.com; s=arc-20160816; b=rGoYyp5C+nUslMPhYWVBx7W7fq6Q0yPj8JunfDL/8cKkF5BnjYiiw8DiAuqKi/dUlt aGohHXInZrsWnmvWzpCKPL4hjHfkZrMVfUfY09DdqvJjGQbNk98GRkQnrhOCQ9Pg1kdX 2ORXlai6hQIUfoP2aMXlUNQI3Hq6LkOWZTyo0qz6EPMl3po4qeph3z6CrDI8FMRFmZRf pNW6Vl4fOnjd531qcO4vXWsiDZWNvSmioawesa9HVfICAKs1rp5VRPuU6ScO1pfWsNXD iITmggULHJiIHepwR4A+JUC/t/98Ti0xIGn6nOjBrh2zp0a8wxASDsAKau3PmchSXqFz Oedw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=j30QLMDESvoyDz9iXByOpZ6fuiifC140J3QpR7RkjPQ=; b=BzEl7H2G5Ha14sPD1f670xLRxV2BguGmcgqrC8RXBa+U3M/G6O+CqswXI+Ho3qZ6tB 6xgm03ULa6D4AwwrT7Qu5yWxU1Mfe4GbnQfx+S/AovQNVvnNOJThFfNwsAUWW0ELcQF2 jjbh9xGKC9qC9pXCyRgomoYIcd0cia7qYo5yCORfTeGxaBVWVvKKVhj0ipb3+ZQzT5eB zIpCQwc3AcMqgT/VtqgYwRxKfNGwolXIzw5u580hoTGKeiBHrt6EDb3h7LlBe4Goi21a U6kXec4tenzNXIfpVBsb5OkdBOTqyGHjMZRpbJxBWR30Dh97aii1Yk64OTSfR9yYk4fF t9DA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=oXu9mPTa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l186-20020a6388c3000000b00513965a1e60si1489375pgd.902.2023.03.30.23.34.28; Thu, 30 Mar 2023 23:34:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=oXu9mPTa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230093AbjCaGdb (ORCPT + 99 others); Fri, 31 Mar 2023 02:33:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbjCaGda (ORCPT ); Fri, 31 Mar 2023 02:33:30 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C22FAEB54 for ; Thu, 30 Mar 2023 23:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=j30QLMDESvoyDz9iXByOpZ6fuiif C140J3QpR7RkjPQ=; b=oXu9mPTaTxRk6wk56CLilnLn1AJMz6BsqGKKrOmoxSDk giEsFLBaGazYey8qG+NZ0qFrWc+XpvN/yx5gR+rww/lXF3owJUEeHoarR+rM6lc4 1kdYuSl8KXYamdiHBXLAqLrLYstIlsNPBncTnLQBB4/DD5wn/8jldNbqWEX/8rc= Received: (qmail 1183893 invoked from network); 31 Mar 2023 08:33:24 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 31 Mar 2023 08:33:24 +0200 X-UD-Smtp-Session: l3s3148p1@iTbcYiz4iqAujnv6 Date: Fri, 31 Mar 2023 08:33:24 +0200 From: Wolfram Sang To: Jakub Kicinski Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Steve Glendinning , "David S. Miller" , Eric Dumazet , Paolo Abeni , Geert Uytterhoeven , linux-kernel@vger.kernel.org Subject: Re: [PATCH net v4] smsc911x: only update stats when interface is up Message-ID: Mail-Followup-To: Wolfram Sang , Jakub Kicinski , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Steve Glendinning , "David S. Miller" , Eric Dumazet , Paolo Abeni , Geert Uytterhoeven , linux-kernel@vger.kernel.org References: <20230329064010.24657-1-wsa+renesas@sang-engineering.com> <20230329123958.045c9861@kernel.org> <20230329131724.4484a881@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5qdbPEL+nrZZAkQ+" Content-Disposition: inline In-Reply-To: <20230329131724.4484a881@kernel.org> X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5qdbPEL+nrZZAkQ+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Okay, core changes aside - does pm_runtime_put() imply an RCU sync? > Otherwise your check in get_stats is racy... =46rom some light research, I can't find a trace of RCU sync. Pity, I'll need to move furhter investigation to later. I'll report back if I have something, but it may take a while. Thanks for the help! --5qdbPEL+nrZZAkQ+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmQmfrAACgkQFA3kzBSg KbaqLw//ZoK8taG1FXjfTLeNELsk6VxQP8Gp7XWth0XTlt6av1jXS8HWdO+zvYfI HIjujOUzkWqmDJ6YrupRseMl6FXBcWPfKfa/q1eQ68a9Pv0ur+zbhWhKDk/7DaEN veuSNRzEjOwTqtqJmF6hsjZFPeuoqijb+ObmYMgMHswUfRsuP4OHi3sJRTsFB2+6 jGCrQYJH5tPHifl6nkDvaah57Y6r1gG4zMx9Yq8ON0f92ZwAjkt8q5sgv80NxWJu 3Z+oSa1ysbO2FGqRfH5gVtmrG9wS565O8b6AcD/ZgRP23B+alssS7DNBUVc8FKc0 RyvFwxLxF7LB23EKsu46Xm/C49junk1xhlQpasldrPQmIbPyAA8vcN4F3ruAZLr9 v7kk5g+uSOT3r/dFy6byG7vsh18HsGzhm0wlVh447iAT7fasuRI/79cfuufDqI0v FI0fVNlWdvsJs+RGl+ZOO3D23fSEYqMiKZSunf/Z/2Mp3H6ZIQKI3QL2G4Ygyjlb diCVFcV6P5N1VQ1eSkIrRoAPlonzCy7LKJKE22yF4B/odmdOyTY+zaC0tBNvQ4Q8 z5ZzWYOTvBSmZplFmPE6Us3inG2NLCFlHb1WWm9GfuWCjqqgM/54rQbml5IQUR6o jV1X6s+4tSiOzknY/a0bmZXv/v/LyzctwQrBkyyD3YDdSCnSxk0= =QAsY -----END PGP SIGNATURE----- --5qdbPEL+nrZZAkQ+--