Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 31 Mar 2023 09:45:33 +0200
From:   Stefano Garzarella <sgarzare@redhat.com>
To:     Simon Horman <simon.horman@corigine.com>
Cc:     virtualization@lists.linux-foundation.org,
        Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>,
        Jason Wang <jasowang@redhat.com>, eperezma@redhat.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        kvm@vger.kernel.org, stefanha@redhat.com,
        "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v4 5/9] vringh: support VA with iotlb
Message-ID: <3jqstd75xs6f2pn7pwjxnkphhan5bk25er3ord4rw63545htu7@vgngick7zfco>
References: <20230324153607.46836-1-sgarzare@redhat.com>
 <20230324153919.47633-1-sgarzare@redhat.com>
 <ZCWIXZbeWanvPJA3@corigine.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <ZCWIXZbeWanvPJA3@corigine.com>
Precedence: bulk

On Thu, Mar 30, 2023 at 03:02:21PM +0200, Simon Horman wrote:
>On Fri, Mar 24, 2023 at 04:39:19PM +0100, Stefano Garzarella wrote:
>> vDPA supports the possibility to use user VA in the iotlb messages.
>> So, let's add support for user VA in vringh to use it in the vDPA
>> simulators.
>>
>> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>
>...
>
>> +/**
>> + * vringh_init_iotlb_va - initialize a vringh for a ring with IOTLB containing
>> + *                        user VA.
>> + * @vrh: the vringh to initialize.
>> + * @features: the feature bits for this ring.
>> + * @num: the number of elements.
>> + * @weak_barriers: true if we only need memory barriers, not I/O.
>> + * @desc: the userpace descriptor pointer.
>> + * @avail: the userpace avail pointer.
>> + * @used: the userpace used pointer.
>
>nit: s/userpace/userspace/

Oops, good catch!

Copy & past typos also present in the documentation of vringh_init_kern
and vringh_init_iotlb.

I will fix this patch and send a separate patch to fix the other two.

Thanks,
Stefano