Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20230329223239.138757-1-y86-dev@protonmail.com>
 <20230329223239.138757-5-y86-dev@protonmail.com>
 <87h6u24bip.fsf@metaspace.dk>
 <6c3985d3-6b81-df0e-5c22-12a0d8044119@protonmail.com>
User-agent: mu4e 1.9.18; emacs 28.2.50
From:   Andreas Hindborg <nmi@metaspace.dk>
To:     Benno Lossin <y86-dev@protonmail.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?utf-8?Q?Bj=C3=B6rn?= Roy Baron <bjorn3_gh@protonmail.com>,
        Alice Ryhl <alice@ryhl.io>, rust-for-linux@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH v3 04/13] rust: add pin-init API core
Date:   Fri, 31 Mar 2023 10:16:56 +0200
In-reply-to: <6c3985d3-6b81-df0e-5c22-12a0d8044119@protonmail.com>
Message-ID: <871ql549lv.fsf@metaspace.dk>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Benno Lossin <y86-dev@protonmail.com> writes:

> On 30.03.23 15:05, Andreas Hindborg wrote:
>>> +//! [`Arc<T>`]: crate::sync::Arc
>>> +//! [`impl PinInit<Foo>`]: PinInit
>>> +//! [`impl PinInit<T, E>`]: PinInit
>>> +//! [`impl Init<T, E>`]: Init
>>> +//! [`Opaque`]: kernel::types::Opaque
>>> +//! [`pin_data`]: ::macros::pin_data
>>> +//! [`UniqueArc<T>`]: kernel::sync::UniqueArc
>>> +//! [`Box<T>`]: alloc::boxed::Box
>>> +
>>> +use core::{convert::Infallible, marker::PhantomData, mem::MaybeUninit};
>>> +
>>> +/// A pinned initializer for `T`.
>>
>> "An initializer for a pinned `T`" instead?
>
> To me this does not really make sense, since the type `T` cannot be
> pinned, only an instance can be. But maybe I should use the term
> `pin-initializer` instead.

I see. Could be "An initializer for a pinned instance of `T`" then. Just
to clarify that the initializer itself is not the thing that is pinned.