Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230331030204.1179524-1-treapking@chromium.org>
In-Reply-To: <20230331030204.1179524-1-treapking@chromium.org>
From:   Robert Foss <rfoss@kernel.org>
Date:   Fri, 31 Mar 2023 10:48:29 +0200
Message-ID: <CAN6tsi4i+3H4-e7wCGTrpR+RCZy4OfgErn3bFmOWtWRkZy_whg@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge: ps8640: Use constant sleep time for polling hpd
To:     Pin-yen Lin <treapking@chromium.org>
Cc:     Douglas Anderson <dianders@chromium.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Mar 31, 2023 at 5:02=E2=80=AFAM Pin-yen Lin <treapking@chromium.org=
> wrote:
>
> The default hpd_wait_us in panel_edp.c is 2 seconds. This makes the
> sleep time in the polling of _ps8640_wait_hpd_asserted become 200ms.
> Change it to a constant 20ms to speed up the function.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> ---
>
>  drivers/gpu/drm/bridge/parade-ps8640.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bri=
dge/parade-ps8640.c
> index b823e55650b1..c3eb45179405 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -184,7 +184,7 @@ static int _ps8640_wait_hpd_asserted(struct ps8640 *p=
s_bridge, unsigned long wai
>          * actually connected to GPIO9).
>          */
>         ret =3D regmap_read_poll_timeout(map, PAGE2_GPIO_H, status,
> -                                      status & PS_GPIO9, wait_us / 10, w=
ait_us);
> +                                      status & PS_GPIO9, 20000, wait_us)=
;
>
>         /*
>          * The first time we see HPD go high after a reset we delay an ex=
tra
> --
> 2.40.0.348.gf938b09366-goog
>

Snoozing for a few days before applying.

Reviewed-by: Robert Foss <rfoss@kernel.org>