Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp770576rwl; Fri, 31 Mar 2023 02:02:45 -0700 (PDT) X-Google-Smtp-Source: AKy350Z52pVTCongpKS/p6QDeb60dqQFUxBmjIPxu+HwHgjLFYPvmOyT7kRY+BjtpUl+IEM6PcqH X-Received: by 2002:a05:6402:40d6:b0:502:367:d5b8 with SMTP id z22-20020a05640240d600b005020367d5b8mr5735920edb.4.1680253365306; Fri, 31 Mar 2023 02:02:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680253365; cv=none; d=google.com; s=arc-20160816; b=ArmZPcTXr8UHF65AyI/iuicydnHODV7f0L35xTVNl5Rm3PG1ppfnLOATOEhZoL9jiw hP391MCGT3RsbMu9DrZ8vr7UQx9hlpG0HJ6XY8MfGb5wC8XbyRseuRu8H/STPyDjmS57 tm9I9BsgZRbA/WuucUDdGBH4nUqE8kmTBuGLjgxRJ4ldRH/k4Np9nYDHVSVeshDosR9U 81LpVO4VMEBLSJdNKjE5HRHbtAc99W0XH8FUHCQqdaFjpTHOPEKuhgI6/lvDjf1wxtNK 5Mwie/5FFt5lK/PnT0CBVdUAiPKCt8XwzMEM25uPZdQ2f2wZNJ8rWLxk7CLDuWfoijRM 0p4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:to:from:subject:cc :message-id:date:content-transfer-encoding:mime-version :dkim-signature; bh=9Yu3f2V+e4EaAUzQwuZ3S/oppL0PlLG/aTOTVG2SOQI=; b=jXejeFCeutow/dKOfKzagzdrvrqAWoGoP+tJGF9+w+FwDSimdPOGVq1OJLqpoCPG5X GGPSYVEqU52RW72JD9SacP1axblOMldfhRFVp5Zftq3xSrEwyNDQ0bYZDkZwrgTLJrqG d1ZgiVBSpohVIzz0WWXQL07MmzVgb0phwwvfnwa2i8eSZg9+x9X8BLWI1ObDVgQRZPxX 2qcrqr876fI1f33Ja4zSBj9TE8S/5eR/eQUsnmo7KXb8OpnVW855raYNBX1sNpvo2qbv E5ZmG1G2BglBa/gDDHkagoDmjldBrUlViV4urSLHUpekmxj2ZSxZBD4xumRmWFLC3N41 r7cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=YUP4PKRs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r25-20020aa7c159000000b004ad73eb9374si1501565edp.147.2023.03.31.02.02.13; Fri, 31 Mar 2023 02:02:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=YUP4PKRs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231539AbjCaJAC (ORCPT + 99 others); Fri, 31 Mar 2023 05:00:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbjCaJAA (ORCPT ); Fri, 31 Mar 2023 05:00:00 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C46E57DB3 for ; Fri, 31 Mar 2023 01:59:53 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id h8so86920498ede.8 for ; Fri, 31 Mar 2023 01:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1680253192; x=1682845192; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9Yu3f2V+e4EaAUzQwuZ3S/oppL0PlLG/aTOTVG2SOQI=; b=YUP4PKRsSoQMh0PPFqhOKgoI3m1ystsRho+dQI8mv7YXsmpBc5oqws9E4jekOggY2M WlLaek7XOC3tzkuNr4E8adUiz7cj8/DbQnx9Pha6M+TDztwQan/W3a/f6MSTKTTB7IHn uFQJ41FJEBLht4kQn5l3XWVoKmbSvD+XKAv0YQgTly0n6jMK5UTT2cxm0xm8JlQMMIHI 60y4dluzbYTVjn+a8CXnJqJ45agTqTsvNUgne2qG/l1WZH3TP65cfNV/XSDlqQH4Dmkx iGcDlzXMpDSbOhqVj5rszbpYpIScfvGpXtReqSsGa2krXBIzJdQHe/l5NW/duIkCHiZr CiLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680253192; x=1682845192; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9Yu3f2V+e4EaAUzQwuZ3S/oppL0PlLG/aTOTVG2SOQI=; b=6jzruIGuQSBADC+zo5S/sa3zCO5/+PjauRPkVXzW2QhYxRxPi3Hy7jfHEbwL8OvZ6d Eb/pQ4uAqIUCpa3Mbn6uqINZQa37VC6tDgWWmMoe+Xk/1Vo1h9clYMPsUCg3nHbo3Fk0 uNQ+vThJcnYZ85HIrJga8AdJsYOUFO8ySLxdrC3nHTg4lOcH19PqnzGOi+UNHr07ub8T BdknrHmEFjRLiDNCveJqtxECIAoLMPNKaJbsv1IXKiWZd3auTOk1Vz7jPE5dwGB5NNyj sqEUGbw8T8irUN+vE7sW3L3YGJnK1Gk8gHvNPf4uChPdMfmMyprUHWDJXND+HGQmLcAR owUQ== X-Gm-Message-State: AAQBX9d7vpwU8T6cg0Cs2sonYjHJPl2bEghYe5IpsDDgxmqRdrv3cUIa 8Ryk9Hn7nSrqdye0xe49Yss/jw== X-Received: by 2002:a17:906:138e:b0:92f:dcf7:9434 with SMTP id f14-20020a170906138e00b0092fdcf79434mr7621783ejc.9.1680253192262; Fri, 31 Mar 2023 01:59:52 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id m11-20020a170906160b00b00938041aef83sm742828ejd.169.2023.03.31.01.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 01:59:52 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 31 Mar 2023 10:59:51 +0200 Message-Id: Cc: "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , , , , Subject: Re: [PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: configure flash LED From: "Luca Weiss" To: "Pavel Machek" , "Fenglin Wu" X-Mailer: aerc 0.14.0 References: <20221209-fp4-pm6150l-flash-v1-0-531521eb2a72@fairphone.com> <20221209-fp4-pm6150l-flash-v1-3-531521eb2a72@fairphone.com> In-Reply-To: X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, On Thu Mar 23, 2023 at 8:54 PM CET, Pavel Machek wrote: > Hi! > > > > > > I'm pretty sure the flash is not yellow. > > >=20 > > > The marketing term is Dual LED flash or Dual-tone flash, one LED is a > > > blue-ish white and one is a yellow-ish white, but from what I can tel= l, > > > in the original code it's always referred to as white and yellow so I > > > also followed that here. > > >=20 > > > Also the LEDs are right next to each other so in practise for torch j= ust > > > both go on, and for camera flash I cannot really tell you but I guess > > > it's doing something there with the camera tuning. > > >=20 > > > See also this picture: > > > https://shop.fairphone.com/media/catalog/product/cache/b752d78484639b= 19641a8560800d919d/p/_/p_5b_main_camera_back.jpg > > >=20 > > Hi Pavel, > >=20 > > Luca is right. It is normally called dual CCT (Correlated Color Tempera= ture) > > flash LED. It has 2 LEDs, one is with higher CCT (~6000K) so it looks l= ike a > > white LED, another is with lower CCT (~2000K) and it looks like a yello= w > > LED. I am not an expert of this but my understanding is the camera tuni= ng > > process normally adjusts the brightness of the two LEDs and enables the= m to > > get different CCT for different snapshots. > > I believe this is normally called "warm white" and "cool white", no? > Yellow would be monochromatic light at cca 575nm, see > https://en.wikipedia.org/wiki/Shades_of_yellow . I don't really have any more information I can provide right now. If you feel it should be called warm white and cool white, feel free to send a patch changing it. I'm personally okay with it being called white & yellow since that seems to be the term used in (downstream) software for these kinds of leds. Regards Luca > > If we need to add some defines for that, lets do that. > > BR, > Pavel > --=20 > People of Russia, stop Putin before his war on Ukraine escalates.