Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761844AbXIUXhu (ORCPT ); Fri, 21 Sep 2007 19:37:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750987AbXIUXhm (ORCPT ); Fri, 21 Sep 2007 19:37:42 -0400 Received: from mx1.redhat.com ([66.187.233.31]:60995 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751766AbXIUXhl (ORCPT ); Fri, 21 Sep 2007 19:37:41 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <10249.1190416956@redhat.com> References: <10249.1190416956@redhat.com> <46F3F8BF.1030404@redhat.com> <20070921144703.8323.50492.stgit@warthog.procyon.org.uk> <20070921144815.8323.77745.stgit@warthog.procyon.org.uk> Cc: dhowells@redhat.com, Peter Staubach , viro@ftp.linux.org.uk, hch@infradead.org, Trond.Myklebust@netapp.com, sds@tycho.nsa.gov, casey@schaufler-ca.com, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org Subject: Re: [PATCH 14/22] NFS: Use local caching X-Mailer: MH-E 8.0.3; nmh 1.2-20070115cvs; GNU Emacs 22.1.50 Date: Sat, 22 Sep 2007 00:37:26 +0100 Message-ID: <10304.1190417846@redhat.com> To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 36 David Howells wrote: > Peter Staubach wrote: > > > Did I miss the section where the modified semantics about which > > mounted file systems can use the cache and which ones can not > > was implemented? > > Yes. fs/nfs/super.c: case Opt_sharecache: mnt->flags &= ~NFS_MOUNT_UNSHARED; break; case Opt_nosharecache: mnt->flags |= NFS_MOUNT_UNSHARED; mnt->options &= ~NFS_OPTION_FSCACHE; break; case Opt_fscache: /* sharing is mandatory with fscache */ mnt->options |= NFS_OPTION_FSCACHE; mnt->flags &= ~NFS_MOUNT_UNSHARED; break; case Opt_nofscache: mnt->options &= ~NFS_OPTION_FSCACHE; break; Hmmm... Actually, I'm not sure this is sufficient. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/