Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp820518rwl; Fri, 31 Mar 2023 02:56:08 -0700 (PDT) X-Google-Smtp-Source: AKy350YdNUAb9FBJe0cgVhIf8Gn7hAZLjoT6Hbqyy31QlInYnihHUz6LYsfuKMLImgbthl9Iw5EC X-Received: by 2002:a05:6a21:32a2:b0:e3:6fdb:f6c6 with SMTP id yt34-20020a056a2132a200b000e36fdbf6c6mr5776430pzb.6.1680256568377; Fri, 31 Mar 2023 02:56:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680256568; cv=none; d=google.com; s=arc-20160816; b=LnFw3OG2qc1dh97MLUBTZRLt9am5INflO3Wc5s7qCWyqOdeDbEyoUtWTmurvW4/3zS OAPgyQfMBZJJK4lWxsVuLmfJSYcGdKQyV8L2IhAEtpvdvVGs1hv+bcnd5wT0LAiQah2+ VmQqwjc9S/q/DIogMBGtwxzvvkUL4Dz4F77DzqTsYQssIKiBMDDVeux782nc7EpYrUeJ EPbWjLE5Vil7+V132N5KWpkWom4bCIO0BKQ5i/X7tcIEi5Spre48JCR9bmeED58DaHct 7PuEdUzU+WYJwRwWAQZTpeuSuBpHq0YbXaHAyXtrrgkG/5JqRch3sanG1WJTkUgzAvXn z9mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=QmDPKBmiyvgbw8nx8tGsK8b2rKR4tpYw4tKnKG24dUs=; b=gSwPWcK/dxN7ca12icJvT5QNZ4svzS9YWNwXJXCW5Qmb/t90pQfBkAgfgFtgx0VWz0 IzpXvntC9AuElERrIK7IIHSOSWGM681ehVhm+I2098uLof9IiqoZJrrAZbqaw0qdQHU1 SEn2qeciEGZEbsR9VUfytP8Ho6Kb4pBV8yQW+B2iC3NM3ggNn7hhb6w+aNY+gZ87ttbv 7mdbI6D+AlAa/Xi+JIomz3TlWI9o+7aVCj3JyJihG4Q7AdDCZqEVRJQfXgbfpnWBt2Ef qnTMRdNzu1fGXbFOMDnvRyj63CSimFWbeW4UQOejmS+HdCQrlTChMO5peDK7jJqMCSxC 6olw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bv65-20020a632e44000000b0051323b8ba22si1889982pgb.788.2023.03.31.02.55.56; Fri, 31 Mar 2023 02:56:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231267AbjCaJwQ (ORCPT + 99 others); Fri, 31 Mar 2023 05:52:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231232AbjCaJvl (ORCPT ); Fri, 31 Mar 2023 05:51:41 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 177861D863; Fri, 31 Mar 2023 02:49:52 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1piBOC-00Al6w-Tq; Fri, 31 Mar 2023 17:49:45 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 31 Mar 2023 17:49:44 +0800 Date: Fri, 31 Mar 2023 17:49:44 +0800 From: Herbert Xu To: meenakshi.aggarwal@nxp.com Cc: horia.geanta@nxp.com, V.sethi@nxp.com, pankaj.gupta@nxp.com, gaurav.jain@nxp.com, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, leonard.crestez@nxp.com, aisheng.dong@nxp.com Subject: Re: [PATCH] crypto: caam - refactor RNG initialization Message-ID: References: <20230320073848.697473-1-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230320073848.697473-1-meenakshi.aggarwal@nxp.com> X-Spam-Status: No, score=4.3 required=5.0 tests=HELO_DYNAMIC_IPADDR2, PDS_RDNS_DYNAMIC_FP,RDNS_DYNAMIC,SPF_HELO_NONE,SPF_PASS,TVD_RCVD_IP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: **** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 20, 2023 at 08:38:48AM +0100, meenakshi.aggarwal@nxp.com wrote: > > @@ -619,7 +712,7 @@ static bool needs_entropy_delay_adjustment(void) > /* Probe routine for CAAM top (controller) level */ > static int caam_probe(struct platform_device *pdev) > { > - int ret, ring, gen_sk, ent_delay = RTSDCTL_ENT_DLY_MIN; > + int ret, ring; > u64 caam_id; > const struct soc_device_attribute *imx_soc_match; > struct device *dev; > @@ -629,10 +722,8 @@ static int caam_probe(struct platform_device *pdev) > struct caam_perfmon __iomem *perfmon; > struct dentry *dfs_root; > u32 scfgr, comp_params; > - u8 rng_vid; > int pg_size; > int BLOCK_OFFSET = 0; > - bool pr_support = false; > bool reg_access = true; This patch does not apply against cryptodev. There is no reg_access in my tree. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt