Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <211e3b03-96ee-e0e5-95aa-3b4094a18237@wolfvision.net>
Date:   Fri, 31 Mar 2023 11:49:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 0/7] Add timing override to sitronix,st7789v
Content-Language: en-US
To:     Gerald Loacker <gerald.loacker@wolfvision.net>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Maxime Ripard <mripard@kernel.org>
References: <20230314115644.3775169-1-gerald.loacker@wolfvision.net>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20230314115644.3775169-1-gerald.loacker@wolfvision.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGIwYnNwSHB2WVJ0L2dLZW9qSlVPSHZubDhKSGNLWkR1MWh4SGVRQmltZ1NP?=
 =?utf-8?B?Z293cVRYNXZ0UU44dk83OFJnQkd6SzJCakgrWFVDSVRvYi9RRzVPN3UwaXB5?=
 =?utf-8?B?U2J3Z0ZCUjc5VUFNeC9sZGNOTkNqeU9PQlVPVWt3RVFiTDRaQzBCVlRZSWxx?=
 =?utf-8?B?QnZldkZWRXBJTWxjdzdicnV0cEJtNURlamlVRzJFME15aHR3UFFYbXhPSzNP?=
 =?utf-8?B?dlk5OStyQXQrR0RlS2Zpd0NodWhGOGVScE95WDgzSWRZZjhvNmIrUUZCeFBx?=
 =?utf-8?B?TzlacmdRWmlNRFl4NzlhZGpwWXdpVitibGhDRG1nbmdRYjFac2ZmaXczejk3?=
 =?utf-8?B?WmlOT3dkaUtmYTN5cTFXRjdMb2JrSDJqQkEvU1JEZG5YSk1oN00vbnVnaEh5?=
 =?utf-8?B?OU54bUQ4QjlIMzYwbWEvUlQweHF6SGFwQzRtM3FiMmZpblVkS0lvOGt3QkM2?=
 =?utf-8?B?aXhXbnB4YlYxQ2lOOEFkOVk4UXFKeEhWd0tGY3NQNzc3T3MvMmJnRDFocElj?=
 =?utf-8?B?c0xUNTJSMUkycjUrMmNzMnVUb1hnc0lFbzRxdEFtMkw0Wk0ySlZCSGsvY3Nj?=
 =?utf-8?B?Y1NJL24xcFlkV2hDL016T1ExWksvRVhldnRHN0EwbjBVeWpDRUZ0SFF5T3Ex?=
 =?utf-8?B?NXFDZTlhTE9OTk9ZVFl2S3F4b0NnbE9nRy9TcHJVUTgzMkxnQzBmTVgvTndK?=
 =?utf-8?B?WEp4cnZ4a3lDY1c2ODM0NXBuWnhBbGFYejV2Z3lEbEN2T2dmbHVHOGpHWElV?=
 =?utf-8?B?bGoxbFpiaXZhY3hVY2xFbDM2ZFRHOFZHa2Rta1cvNWk5T21mcUhNYklzZ04v?=
 =?utf-8?B?b0F1VDFESTBIT0tUeWRKS3I0VDY4VmwvZ3I4emxiYk5nb1l4S202NWI0UVUv?=
 =?utf-8?B?eGpwZk1GL0o4b2FwZmFVTVNKZTEvSHBOVjFveDhVM2paVTF2YkxnaEdXUXJj?=
 =?utf-8?B?b0Z1UjlSWUI5K2VHeVFKdVYzWmQ3VHFndHhBVHRENks2SmlCd1dJNXlvcHBt?=
 =?utf-8?B?ZnJIMXhFVjJBT01oV04rVDN1WXIxa093SlpRZWU0d01HYUdyT0Y1eGdtMHYr?=
 =?utf-8?B?MzlSSHl6NHM1MWVMVUhKdU8xUVhBMDFtSjRUNU5tbVFXUzVuZDUxS2tudVlY?=
 =?utf-8?B?UFNEOHNLSUtrTjFORjZlVGVBMUtRTktJcGNVZnZNMVZhMGhHUlFRNzMrOFRm?=
 =?utf-8?B?UmhHMVVYS1E4dHg3L05OVDZQR09MV3V3VWpmdkpEcFNqRGpXaG1PZm5Sblc3?=
 =?utf-8?B?YzVHcGVtT0lYamJPYnFFRUU1aTNhOFkrSThGS1hGbDdxQnNEQTNpbnFveEFG?=
 =?utf-8?B?RzZ6R05CblVSY2V1ekNNRUU3RTJ1RUxsaWJHb1BOcEVJQy9DM05XNXJzWXpN?=
 =?utf-8?B?QkN3bjdaRWdwNFJ3djVLdnV1VUsxbXFieFdnN1dpekFKWU9RZDRmMUNLZ2Yy?=
 =?utf-8?B?M0NmTW9RNXdBUXhjSXRUanNpT09iWlVjYzh5NVVNVHVwSXdZYW50VmxvVVUz?=
 =?utf-8?B?M0tUZDVDd0N0eUxDb3E0SDRzb1VSN2x1cWRTL2dXR2F3OVZhR2wwWHY0QW5E?=
 =?utf-8?B?VUZLTmtUU1cwV0RsZVZpUDYxbU14S1ZURFVJRWhzZVU3ejFvazRNOU9VTXdR?=
 =?utf-8?B?RllpK0phcGpEV0RDeVkrWUxmY1ZxWGFyS1B1eE9SdXdwTlJydTZkMVpGalpK?=
 =?utf-8?B?dC9PZ1JXZnhuQkJLeFJPMXhEZmZKZ2l1MWl2b2hoY0VUWmtOWFd3SGNwQ3h2?=
 =?utf-8?B?VXMrYnkrcVZOTGxVVFhDRGltc2xBLzRpaHdiV3ZXUG1KcHk5OE81dkI4RWx6?=
 =?utf-8?B?ZlFRdXc5a0lGNTdKblRDWDluQW1KZkdUVUllWStzSGFIMjlXTC9RRU1UTHVJ?=
 =?utf-8?B?YkpFREphZWlUZERYb0svdk80S2JLdzAySFB3TldXNExQNS9UQzVhYUQzQ00v?=
 =?utf-8?B?QzZ5UXZQTllQdjZtUXhhWXY5VXVjdGRNc1RTN3ZJdUcrRGttTUhLQzF5OXNr?=
 =?utf-8?B?UWdmVWozMDVDMFVQQVZoRC9PRHMrRzVEN2ZldXI2R0MwQmRKT3dReXR1NVJx?=
 =?utf-8?B?YUFQUEt1YWwvQmxpblFxM3BpczkwMmF6c2J5VHQ2bzd4amtyYlQ5U0dmbERF?=
 =?utf-8?B?aThmWVRwWHNnTnVLTWxqOXFYZWg4OXhHZityU1hVd29Kb3oyOVM1elNhWTQ4?=
 =?utf-8?B?TnhZRVdSR3czL1lwS2FCaDNwWVV2ekUvOUtVTWFjb3YzbG9HUnRoVVZQQVR4?=
 =?utf-8?B?TndmT2pNRWFxYnhmQTF4UG16MnFRPT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f6f9618-4179-467a-6ae4-08db31cd42c0
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 09:49:46.2405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kXWUPRSmASXodpcOXFIj9njUv/adUVpFTbRvyKr8TYdgAs7Q4mewzMjUNmbPaHV9m0NdwZXjj3AMf3gNtm4Vzhqi0Ep16gac/eoNdgVW2rU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6291
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi all,

On 3/14/23 12:56, Gerald Loacker wrote:
> This patch set adds additional functionality to the sitronix,st7789v
> driver.
> 
> Patches 1,3 and 4 propagate useful flags to the drm subsystem.
> Patch 2 adds the orientation property.

If there are no objections, patches 1-4 and 6 could be applied from our
point of view. Or should we spin a v2?

> Patch 5 parses the device tree for a panel-timing and makes it possible to
>   override the default timing.
> Patches 6 and 7 add the new properties to the dt-bindings.

Parsing the timing from the device tree (patches 5 and 7) can be
ignored, we'll come up with a different approach.

Best regards,
Michael

> 
> Gerald Loacker (4):
>   drm/panel: sitronix-st7789v: propagate h/v-sync polarity
>   drm/panel: sitronix-st7789v: add bus_flags to connector
>   drm/panel: sitronix-st7789v: parse device tree to override timing mode
>   dt-bindings: display: add panel-timing property to sitronix,st7789v
> 
> Michael Riesch (3):
>   drm/panel: sitronix-st7789v: propagate RGB666 format
>   drm/panel: sitronix-st7789v: add panel orientation support
>   dt-bindings: display: add rotation property to sitronix,st7789v
> 
>  .../display/panel/sitronix,st7789v.yaml       |  19 ++
>  .../gpu/drm/panel/panel-sitronix-st7789v.c    | 204 +++++++++++++++---
>  2 files changed, 191 insertions(+), 32 deletions(-)
>