Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <97687def-aca0-b1c5-68b6-e00079613c90@gmail.com>
Date:   Fri, 31 Mar 2023 05:47:29 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [RFC net-next] net: phy: introduce phy_reg_field interface
Content-Language: en-US
To:     "Radu Pirea (OSS)" <radu-nicolae.pirea@oss.nxp.com>,
        andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230331123259.567627-1-radu-nicolae.pirea@oss.nxp.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20230331123259.567627-1-radu-nicolae.pirea@oss.nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/31/2023 5:32 AM, Radu Pirea (OSS) wrote:
> Some PHYs can be heavily modified between revisions, and the addresses of
> the registers are changed and the register fields are moved from one
> register to another.
> 
> To integrate more PHYs in the same driver with the same register fields,
> but these register fields were located in different registers at
> different offsets, I introduced the phy_reg_fied structure.
> 
> phy_reg_fied structure abstracts the register fields differences.
> 
> Signed-off-by: Radu Pirea (OSS) <radu-nicolae.pirea@oss.nxp.com>

You know how it goes: a framework without its user will not be accepted 
unless an user of that framework also shows up. Can you post both?
-- 
Florian