Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-238-g746678b8b6-fm-20230329.001-g746678b8
Mime-Version: 1.0
Message-Id: <900066e4-fd5c-4645-bf04-9c27561516a9@app.fastmail.com>
In-Reply-To: <CAMZdPi8ZMfLTHaEn2LbXvuen=Rb68KrWJmgbq9Miou_RDi=Btg@mail.gmail.com>
References: <20230320152319.665592-1-loic.poulain@linaro.org>
 <20230330114242.GC434339@google.com>
 <242a5400-b5e6-4707-af88-1d695e114f78@app.fastmail.com>
 <CAMZdPi8ZMfLTHaEn2LbXvuen=Rb68KrWJmgbq9Miou_RDi=Btg@mail.gmail.com>
Date:   Fri, 31 Mar 2023 15:06:00 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Loic Poulain" <loic.poulain@linaro.org>
Cc:     "Lee Jones" <lee@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: syscon: Use of_io_request_and_map() for IO mapping
Content-Type: text/plain
Precedence: bulk

On Thu, Mar 30, 2023, at 15:22, Loic Poulain wrote:
> On Thu, 30 Mar 2023 at 14:45, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Thu, Mar 30, 2023, at 13:42, Lee Jones wrote:
>> > On Mon, 20 Mar 2023, Loic Poulain wrote:
>>
>> Thanks for pinging me. I would indeed expect this to cause
>> problems, as syscon mappings are likely to be used in a way
>> that is not entirely clean, with other devices defining
>> overlapping ranges.
>
> Isn't syscon exactly here to address that collision/overlapping issue?
> From a syscon perspective, it seems to be handled correctly at least
> since the mapping is only setup once, with the first user device (in
> syscon_node_to_regmap). Or are you thinking about non syscon devices
> overlapping the syscon area?

I meant them overlapping with other devices. Ideally this should
not exist, but most likely we have to deal with dtb files where
some other device does overlap with a syscon.

     Arnd