Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20230329223239.138757-14-y86-dev@protonmail.com>
User-agent: mu4e 1.9.18; emacs 28.2.50
From:   Andreas Hindborg <nmi@metaspace.dk>
To:     y86-dev@protonmail.com
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?utf-8?Q?Bj=C3=B6rn?= Roy Baron <bjorn3_gh@protonmail.com>,
        Alice Ryhl <alice@ryhl.io>, rust-for-linux@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev,
        Andreas Hindborg <a.hindborg@samsung.com>
Subject: Re: [PATCH v3 13/13] rust: sync: add functions for initializing
 `UniqueArc<MaybeUninit<T>>`
Date:   Fri, 31 Mar 2023 15:07:18 +0200
In-reply-to: <20230329223239.138757-14-y86-dev@protonmail.com>
Message-ID: <87v8ih1329.fsf@metaspace.dk>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


y86-dev@protonmail.com writes:

> From: Benno Lossin <y86-dev@protonmail.com>
>
> Add two functions `init_with` and `pin_init_with` to
> `UniqueArc<MaybeUninit<T>>` to initialize the memory of already allocated
> `UniqueArc`s. This is useful when you want to allocate memory check some
> condition inside of a context where allocation is forbidden and then
> conditionally initialize an object.
>
> Signed-off-by: Benno Lossin <y86-dev@protonmail.com>
> ---

Reviewed-by: Andreas Hindborg <a.hindborg@samsung.com>

>  rust/kernel/sync/arc.rs | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index 4ed6329a5e5f..64b0e9d67025 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -540,6 +540,30 @@ impl<T> UniqueArc<MaybeUninit<T>> {
>              inner: unsafe { Arc::from_inner(inner.cast()) },
>          }
>      }
> +
> +    /// Initialize `self` using the given initializer.
> +    pub fn init_with<E>(mut self, init: impl Init<T, E>) -> core::result::Result<UniqueArc<T>, E> {
> +        // SAFETY: The supplied pointer is valid for initialization.
> +        match unsafe { init.__init(self.as_mut_ptr()) } {
> +            // SAFETY: Initialization completed successfully.
> +            Ok(()) => Ok(unsafe { self.assume_init() }),
> +            Err(err) => Err(err),
> +        }
> +    }
> +
> +    /// Pin-initialize `self` using the given pin-initializer.
> +    pub fn pin_init_with<E>(
> +        mut self,
> +        init: impl PinInit<T, E>,
> +    ) -> core::result::Result<Pin<UniqueArc<T>>, E> {
> +        // SAFETY: The supplied pointer is valid for initialization and we will later pin the value
> +        // to ensure it does not move.
> +        match unsafe { init.__pinned_init(self.as_mut_ptr()) } {
> +            // SAFETY: Initialization completed successfully.
> +            Ok(()) => Ok(unsafe { self.assume_init() }.into()),
> +            Err(err) => Err(err),
> +        }
> +    }
>  }
>
>  impl<T: ?Sized> From<UniqueArc<T>> for Pin<UniqueArc<T>> {