Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fbf84e6b-438c-0486-1ee3-7bb1171b2c0a@amd.com>
Date:   Fri, 31 Mar 2023 11:01:23 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] drm/amd/display: remove unused average_render_time_in_us
 and i variables
To:     Tom Rix <trix@redhat.com>, harry.wentland@amd.com,
        sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        nathan@kernel.org, ndesaulniers@google.com, aric.cyr@amd.com,
        HaoPing.Liu@amd.com, Anthony.Koo@amd.com, hanghong.ma@amd.com,
        Angus.Wang@amd.com, Dillon.Varone@amd.com
Cc:     llvm@lists.linux.dev, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230331001032.1846456-1-trix@redhat.com>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230331001032.1846456-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2pDT2g2YjVRQzVISHNaOUNab25HRzVnWkZkR091eC90N21KN1lUK2R3aUNn?=
 =?utf-8?B?Wi9mcDFxWm81NWdvbUpGRXdlZFFLUWVWN2RFcCs1TEs0cDJGbjlQS2ZIbWhK?=
 =?utf-8?B?L21aNmRkVWwrQ1ZiV0dHelFiUmZQdU9WZ3FRTi9ZTUtNUUM0VmxlWVFBdFoz?=
 =?utf-8?B?ckdiSHdTYVpZY2dYYnlvd2hRRHJVekpWY0dhRHVUMUo3a1dOSWpJZUoydElP?=
 =?utf-8?B?ZURpRmlwK3RqSFhwUGQ2bVk0VzE0SEJ4WlBoMllHdEl5ZEIwejhGOHFKQWlx?=
 =?utf-8?B?ZGxueHhqbFh5Sk9aUlVYNmRhSThwdi9yUDVzYnA4SjhaY2dUNTVJUHBHbGRJ?=
 =?utf-8?B?SUJYVnhBYkxNVDJFamNKVnNrTjNXOFhReTRmRTd4c2dsclA5Nk0vZEVjeVRO?=
 =?utf-8?B?SlNKMStoR3ZlTHRCWW8ya2Q2bU5CZWZFQ20zaU5pMjlkdjhOdUdrSlUyNGFl?=
 =?utf-8?B?dXhleEhxcThFVlIyWWRUQ2doZ1UzWGdFdktsK0ZZT1c5T3h0ZGExTWZSUFFh?=
 =?utf-8?B?UVFDek5PMWxWRWJJSTZHV1ZVWS9QR2VieHdZUHVMeHRTOUhya1MvY0lmTDZH?=
 =?utf-8?B?SG84NWg0QmFZSk9TcVE4Ynlnd1hxQ0lXN0VwSFBpU250NGg5K0doZ25MZnBJ?=
 =?utf-8?B?SUxLckhUWDJ6Sm8zR3RBYWI4aEE5T2FvRlREeVFmcVVrN3d6ZlUxNVQ1dmlS?=
 =?utf-8?B?Mzh0M2d1eS9TYS9NZ205TURFeUYwYmZMSDNGbFdJeXRoUlZOZnJVd05zT29D?=
 =?utf-8?B?ZXlLOWhidmIxUG0vWitIVWhON1dtVXdNaithMU9QSnFmbjV0VDZXQzRXUU9J?=
 =?utf-8?B?VitZOGR6WFdPUFFsZDhveEEyb2FMVEpkQTI2bU03MmRsWEtnalhLQ2xpdkhF?=
 =?utf-8?B?U1U3dEZtV1ErWUVNcmtlUnB1Q202T1E1LzBRQjUwVU8vb24xc09PVU9HeFRn?=
 =?utf-8?B?MVQrekQyK3JQTUwzOWUzRTFaZk5PdGVFQy84MW9WeVVaMzVac0JOczc2REY4?=
 =?utf-8?B?c044TGlvY1VSckZFZmFQY0N3dmdadGRaRTV2cWsvREhhWGYwU0ZTSVNtQXY3?=
 =?utf-8?B?ZkZDNnB1aTdReTZqaVVMQ3pBUU5EOStRRWUvTUpGUWdyNTNlRm11YXVwZUZI?=
 =?utf-8?B?a0hTckpiN0FrcUpBNytZRjl2WXZIZWprdVkvdjFYRWRJUEhvV2pKV0E3V0o5?=
 =?utf-8?B?dmJhK1dtUzBCd1dpemZCRytSbW4vdFpJekdTbkpkQVJETllNeTcxemtUeGhW?=
 =?utf-8?B?eXdlQWlHWUphKzVocXhxSWk3bnBhMWNXZzJMUkxxMnBKUlgyaS9aYktTMzAx?=
 =?utf-8?B?OFZGdC9OWGJwdGRGMWtSRGpkN3RvTVZ6Zy82blJpSlYwZU9jWFUvTUtDUHls?=
 =?utf-8?B?VVY3cWhsOTRoU01DY0lyaDVGSkpnQjVGZ1Z3emltRFpYTmhtVGg4ZEpVRnZu?=
 =?utf-8?B?UzZOY0R5T0JyK3k0UlVLMDhQQSt5bm1HTGpyTC9NeDZ0cHlBOXcrQ0Z1WnhC?=
 =?utf-8?B?STUxY05jRm50TTlWOXBURVZFK21QT0J2ZzJ4VCtoRVVmai9LejQwVm11R0d3?=
 =?utf-8?B?dHpRbGhNaDBKTGwxTHZkTUExS1NTN0dYdVdxTWw2V1FEUFRFV0kxait2S2Ro?=
 =?utf-8?B?SnJvQ2VNTU1na295QU9WVmZXclVlL1BjbkxoSGlrR0dpMitCc2NBSEZTQ3dG?=
 =?utf-8?B?SE1ZQzNqazZKbHd3ejllbWRWeDVNRnJKMFRqcVFsMWR1ZlRvdE0xSkNqUzQw?=
 =?utf-8?B?a1VzenZ1cXBQVUJHVnVlUkg5czQzcGh2c2o5bWI2U0NEdzRjNnJ2K0RmN0Z2?=
 =?utf-8?B?d0NmOW85bDVENXdPL0QvLzlmNTJaeUFucmRkUjhUd3lXVmZ2Uno1YktvMklI?=
 =?utf-8?B?RVU2ekpON0N3TzMwZm9ydGJFak15Rm9RK3lYc0JFOVJNeDY5TVZkYjJaaEF2?=
 =?utf-8?B?QU1SNmtDZ3BKU051U2VuanhMVGlrUVhGRmp3WDJLczNhWjFvRVErUkltUjNv?=
 =?utf-8?B?ZnNtZ2hKT3paNGNaV082SHhSTFR2RElUTzB1R3dOUGcvSDBQR3JFdDh0RWJo?=
 =?utf-8?B?T25IM2hlZUdJRUpZclhaOEZHUWpEOWJ6MlVxZjN0dzRSVmhqbitQUkJxUDh5?=
 =?utf-8?Q?hh9XO3TCoN3U6EZojJoed7onx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1013ea79-ccd1-4f50-dff2-08db31f89bd4
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 15:00:04.3630
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aBbCcrPxJgWt5t9r3W2HZdgNXmzMR/+5PhawQv00Dry4DA5XBSRyQRhC8g56YUWEMmf15PvrCy8uBXR/RkvS4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5226
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/30/23 20:10, Tom Rix wrote:
> clang with W=1 reports
> drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:1132:15: error: variable
>    'average_render_time_in_us' set but not used [-Werror,-Wunused-but-set-variable]
>          unsigned int average_render_time_in_us = 0;
>                       ^
> This variable is not used so remove it, which caused i to be unused so remove that as well.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Applied, thanks!

> ---
>   .../drm/amd/display/modules/freesync/freesync.c    | 14 --------------
>   1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> index 315da61ee897..5c41a4751db4 100644
> --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> @@ -1129,7 +1129,6 @@ void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
>   {
>   	struct core_freesync *core_freesync = NULL;
>   	unsigned int last_render_time_in_us = 0;
> -	unsigned int average_render_time_in_us = 0;
>   
>   	if (mod_freesync == NULL)
>   		return;
> @@ -1138,7 +1137,6 @@ void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
>   
>   	if (in_out_vrr->supported &&
>   			in_out_vrr->state == VRR_STATE_ACTIVE_VARIABLE) {
> -		unsigned int i = 0;
>   		unsigned int oldest_index = plane->time.index + 1;
>   
>   		if (oldest_index >= DC_PLANE_UPDATE_TIMES_MAX)
> @@ -1147,18 +1145,6 @@ void mod_freesync_handle_preflip(struct mod_freesync *mod_freesync,
>   		last_render_time_in_us = curr_time_stamp_in_us -
>   				plane->time.prev_update_time_in_us;
>   
> -		/* Sum off all entries except oldest one */
> -		for (i = 0; i < DC_PLANE_UPDATE_TIMES_MAX; i++) {
> -			average_render_time_in_us +=
> -					plane->time.time_elapsed_in_us[i];
> -		}
> -		average_render_time_in_us -=
> -				plane->time.time_elapsed_in_us[oldest_index];
> -
> -		/* Add render time for current flip */
> -		average_render_time_in_us += last_render_time_in_us;
> -		average_render_time_in_us /= DC_PLANE_UPDATE_TIMES_MAX;
> -
>   		if (in_out_vrr->btr.btr_enabled) {
>   			apply_below_the_range(core_freesync,
>   					stream,
-- 
Hamza