Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8dd0ab75-d007-8aa7-e546-c5fe93f9e03b@intel.com>
Date:   Fri, 31 Mar 2023 17:08:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] net: netcp: MAX_SKB_FRAGS is now 'int'
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>, Jakub Kicinski <kuba@kernel.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "Nikolay Aleksandrov" <razor@blackwall.org>,
        Jason Xing <kerneljasonxing@gmail.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230331074919.1299425-1-arnd@kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230331074919.1299425-1-arnd@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akRSZU1LYW9lVXQvMXpaSVFsNHdUc1ZtN1hEQmxOWDd6UndPZUZ0MHdIS3ls?=
 =?utf-8?B?RjgwK05RK2hKTHYrMndDVTN4azVUZGFTVEVvTWVLOTQrd2JjY2RWL0lMa2VH?=
 =?utf-8?B?cXRza3BVZm1TeUtTOFVQeEtkMjFTeWR5RkZTbGcwR29BYlhib0dQR2gwUTlz?=
 =?utf-8?B?Wm9qL1k1dHd1QnUrejZCTjQ0bjdHVWhwNkg3MFE2Z1h6MjRqUC9ha1VrMW4z?=
 =?utf-8?B?WWRvWmY5VEpOdXExUmpCODU2bUZVeW9LL0lVQnBqLzBFaXY3aHFKQS90QWty?=
 =?utf-8?B?d1hKREpRcVBOK25GNW1QSFNvUkIwS0x4TmFUbHFTQmxWMFZ1SFh2UHc5VlpF?=
 =?utf-8?B?WlFOYlRKMG5qZ3RkS0xNbVEvclJuamVQQnczUTNsdklXZ0o4c2dWQUZhRnNY?=
 =?utf-8?B?U3VXdmdNY3dLQnp4ZUtjT0tCdkY1OU5Hb1NJTHJFUFJaQWR6N2NhY2tnSEtS?=
 =?utf-8?B?Q3hVYjFiaWc3RGszM0xBTlFTVVlTd3VyWkVEYVdJeWFhN1pUU1NWeDlHUFVU?=
 =?utf-8?B?STF0U3ZFek5lTFlJRVFGcHltTXVxUytibDM4V1FraFNwREJMWkVHaVBMV1hr?=
 =?utf-8?B?eURkQXhXeTQxaVFrNW91NzdCMHRZYWFaelBrRnFoT05qVmxFaUZxNHI4RW1u?=
 =?utf-8?B?Nis5OEJCWG1DU2JhTXVKMnN5NVJmQzd4cGFCWTRHblFqc01ONkJIY1o2UEpv?=
 =?utf-8?B?TllSOVF6cUE4bXBVZ1V5RWpoZXMxK0p4bUJhbThzdDkrSEFINnVpZVp4ek5j?=
 =?utf-8?B?MVhvLzB5NHlHTHZVM01IcHZ4cG1uaEcxZlpjdWhpcEZTTWdRWnVQazFVdnlX?=
 =?utf-8?B?cnBWeXkxYlJBWnVMYXUrbUF2ZlM0QjhhQkk0V2hYVlhnZWdoM1RhWktURUwx?=
 =?utf-8?B?YktTbXZNaUM3MUJLU05QVXZXQmhFdWw3MUFJb3ZyUXRTVmpzazZLRThHTXpu?=
 =?utf-8?B?a0Z5MzF0OVpsazJ6cXBVQ0tZZnBtL1dHaVBCaXBxYzl1QWRQVFlKMEFzQ3Zj?=
 =?utf-8?B?U3JqUjBPZGpvZ05FdHlYZ2pxSGtuMTdxLzl0VlhUVlBaOXlIMjhWaFlRRGEy?=
 =?utf-8?B?ZEtEb2dPaHA0MXVmd25VK0dlWnhxdTZESUhLUEZaaS9QZTMxRnJ0WnQ0azk2?=
 =?utf-8?B?bW5qRWduNFc3RGxydm55WkhHY3RpNnp0VE0rZnd1S1lKUlhCcUpnMld3c1VV?=
 =?utf-8?B?dUhlYUtYTXRWSjNHYXp2QndoYmpxK29PMGdlU3FqcEhqWkdyRldRVlNTanU1?=
 =?utf-8?B?NnlyZEtPMDdUb25vSkNodFJZRkEzNERvS0FQN1N3S3RnLzhvWUhMNU9zcys5?=
 =?utf-8?B?Sng4SGRldnVoNjlmTVBlY0pYUEFqVVRoZDF5QnU2VEtQTWZQTE90LzNWSG5S?=
 =?utf-8?B?ZUp2cytYM0lYdHJwQ2pTeG9MalY5bXpTWHFyTXU2cjlIMEZiYjg5c3d0Ym5H?=
 =?utf-8?B?VU0ra1NMb1hxWVFQUTJndXNSeE1EQVlMVERqZWFLOUJXQVFGdm5jOU5OUWEw?=
 =?utf-8?B?VUVqcTFCaGcvZnhpZytaQ0txTGZZaVJqWnVPSkgyMVpRRU1PYWVzUUtLRjdt?=
 =?utf-8?B?VXZteVRKVUdmQmtmM2ZHZUtvaWdqSVEweVRIc1pmSEMxellRTUdjR2diVisy?=
 =?utf-8?B?WitYWDFyYnNMeGs3WFB3NHNNaXRKZ05tN0dOVnIxMGk5dkNLSTJ4WmpMcWxx?=
 =?utf-8?B?bmJWczdMb2sxS01JY0IvNWJwTjhoMEtFbkZ3NlU0anY5MUlPckFZK05ScEo4?=
 =?utf-8?B?VHd3dHBNend4SHdCbHJaVVg4ZjNvNUZXYlplamRub1hhWFZmRDdFbTk0UmNs?=
 =?utf-8?B?T0xaYkVjYlFOSXV4b1BIUlc5UEhrYmY2TVJpLzliWkRVRitRWGVTeGl4U3k1?=
 =?utf-8?B?VERKRmQzTFRMR2RSYTdQdFV0cUFFWHJ0UXZYUEhrczdwMkU5T0pTbEdxWGwz?=
 =?utf-8?B?N2lnRzQ0WHQzSGtBMFd0Rmd3L3pUbFZmSW8rayszMTNTNUwzTmNzTlVJaFJU?=
 =?utf-8?B?YXFKV1czRWNCb1VwWXV5L1U4TlNNWmJraW5IdmR2eHRON3lKbXQ1TEdNSjZJ?=
 =?utf-8?B?eXQyV0RuZzkveVdNTm1aMnQwTS8yb1hXUEpHRkc3QnQ0ZHhFdXBRZGRmWGc0?=
 =?utf-8?B?dEJ2QXJDNHhqbnljRkRCbUhUYStYSTVHaCszODA1dnVaRVBoclhBUGxUNXd2?=
 =?utf-8?B?QWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 841ca2fd-bd30-40d2-affc-08db31f9cbf9
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 15:08:34.4079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hi9Z9fImoy9tEbOk0/URvqD2ZF+EX6GDuqo8DviS0I+U9mRfgigSiF00ws7tXanaLrUtg74EHp4ukCFukbtb6gjV2c1NUq0qxLqoveNKiUs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6786
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Arnd Bergmann <arnd@kernel.org>
Date: Fri, 31 Mar 2023 09:48:56 +0200

> From: Arnd Bergmann <arnd@arndb.de>
> 
> The type of MAX_SKB_FRAGS has changed recently, so the debug printk
> needs to be updated:
> 
> drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_create_interface':
> drivers/net/ethernet/ti/netcp_core.c:2084:30: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Werror=format=]
>  2084 |                 dev_err(dev, "tx-pool size too small, must be at least %ld\n",
>       |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 3948b05950fd ("net: introduce a config option to tweak MAX_SKB_FRAGS")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/ethernet/ti/netcp_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
> index 1bb596a9d8a2..dfdbcdeb991f 100644
> --- a/drivers/net/ethernet/ti/netcp_core.c
> +++ b/drivers/net/ethernet/ti/netcp_core.c
> @@ -2081,7 +2081,7 @@ static int netcp_create_interface(struct netcp_device *netcp_device,
>  	netcp->tx_pool_region_id = temp[1];
>  
>  	if (netcp->tx_pool_size < MAX_SKB_FRAGS) {
> -		dev_err(dev, "tx-pool size too small, must be at least %ld\n",
> +		dev_err(dev, "tx-pool size too small, must be at least %d\n",
>  			MAX_SKB_FRAGS);
>  		ret = -ENODEV;
>  		goto quit;

(not related to the actual fix)

I'd personally define %MAX_SKB_FRAGS as `(u32)CONFIG_MAX_SKB_FRAGS`.
It can't be below zero or above %U32_MAX and we have to define it
manually anyway, so why not cast to the type expected from it :D

Thanks,
Olek