Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 31 Mar 2023 08:41:42 -0700
From:   Alison Schofield <alison.schofield@intel.com>
To:     Dave Jiang <dave.jiang@intel.com>
Cc:     Dan Williams <dan.j.williams@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v10 1/6] cxl/mbox: Add GET_POISON_LIST mailbox command
Message-ID: <ZCb/No9ksoqaAUBJ@aschofie-mobl2>
References: <cover.1679448904.git.alison.schofield@intel.com>
 <7789c4ab210ca309b449ae948d3e56c44aaff38d.1679448904.git.alison.schofield@intel.com>
 <ce9221f4-88da-e16c-8dfb-e3438159f5d1@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ce9221f4-88da-e16c-8dfb-e3438159f5d1@intel.com>
Precedence: bulk

On Thu, Mar 30, 2023 at 03:43:18PM -0700, Dave Jiang wrote:
> 
> 
> On 3/21/23 7:12 PM, alison.schofield@intel.com wrote:
> > From: Alison Schofield <alison.schofield@intel.com>
> > 
> > CXL devices maintain a list of locations that are poisoned or result
> > in poison if the addresses are accessed by the host.
> > 
> > Per the spec (CXL 3.0 8.2.9.8.4.1), the device returns this Poison
> 
> Maybe you need a comma here?
> 
> > list as a set of  Media Error Records that include the source of the
> 
> extra space between "of" and "Media"
> 
> > error, the starting device physical address and length. The length is
> 
> Should add a comma before "and length".
> 
> > the number of adjacent DPAs in the record and is in units of 64 bytes.
> > 
> > Retrieve the poison list.

FYI - this is v10, but things you are pointing out do apply to v11.
I'll update the commit msg as you suggest.

> > 

snip

> > +
> > +struct cxl_mbox_poison_payload_out {
> > +	u8 flags;
> > +	u8 rsvd1;
> > +	__le64 overflow_t;
> > +	__le16 count;
> > +	u8 rsvd2[20];
> > +	struct cxl_poison_record {
> > +		__le64 address;
> > +		__le32 length;
> > +		__le32 rsvd;
> > +	} __packed record[];
> > +} __packed;
> 
> Pretty long struct name. poison_mbox_in and poison_mbox_out?

Yeah...I'll drop the _payload from each. Thanks!

> 
snip to end.