Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 31 Mar 2023 17:44:12 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Avadhut Naik <avadnaik@amd.com>
Cc:     linux-edac@vger.kernel.org, yazen.ghannam@amd.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/mce_amd: Update SMCA bank error descriptions
Message-ID: <20230331154412.GBZCb/zO/BGR3a/bVT@fat_crate.local>
References: <20230329192200.110813-1-avadnaik@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230329192200.110813-1-avadnaik@amd.com>
Precedence: bulk

On Wed, Mar 29, 2023 at 07:22:00PM +0000, Avadhut Naik wrote:
> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
> index cc5c63feb26a..869dcca5e2f4 100644
> --- a/drivers/edac/mce_amd.c
> +++ b/drivers/edac/mce_amd.c
> @@ -192,24 +192,24 @@ static const char * const smca_ls2_mce_desc[] = {
>  	"A SystemReadDataError error was reported on read data returned from L2 for an SCB store",
>  	"A SystemReadDataError error was reported on read data returned from L2 for a WCB store",
>  	"A hardware assertion error was reported",
> -	"A parity error was detected in an STLF, SCB EMEM entry or SRB store data by any access",
> +	"A parity error was detected in an STLF, SCB EMEM entry, store data mask or SRB store data by any access",

I'm assuming that "by any access" is not needed because
amd_decode_err_code() would say "GEN"-eric for the transaction type
which is the same thing, basically.

>  static const char * const smca_if_mce_desc[] = {
> -	"Op Cache Microtag Probe Port Parity Error",
> +	"Op Cache Microtag Parity Error",
>  	"IC Microtag or Full Tag Multi-hit Error",
>  	"IC Full Tag Parity Error",
>  	"IC Data Array Parity Error",
> -	"Decoupling Queue PhysAddr Parity Error",
> +	"PRQ Parity Error",
>  	"L0 ITLB Parity Error",
> -	"L1 ITLB Parity Error",
> -	"L2 ITLB Parity Error",
> +	"L1-TLB Parity Error",
> +	"L2-TLB Parity Error",
>  	"BPQ Thread 0 Snoop Parity Error",
>  	"BPQ Thread 1 Snoop Parity Error",
> -	"L1 BTB Multi-Match Error",
> -	"L2 BTB Multi-Match Error",
> +	"BP L1-BTB Multi-Hit Error",
> +	"BP L2-BTB Multi-Hit Error",
>  	"L2 Cache Response Poison Error",
> -	"System Read Data Error",
> +	"L2 Cache Error Response",

Hmm, so I don't think we can do that - I'll bet on older Zens, this was
"System Read Data Error" and on newer it is "L2 Cache Error Response"
which are not the same thing.

Right?

If so, we can't really "update" descriptions like that. If we had to be
precise, we will have to differentiate by family here. Not sure if we
care enough but still...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette