Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1337239rwl; Fri, 31 Mar 2023 09:40:59 -0700 (PDT) X-Google-Smtp-Source: AKy350Yri1NtQ391bl7U7wgoZP53tTg5zhfkRCDmCUXxYJY18o83/LKfcJhWMH1Mv4B56V9Gzm2H X-Received: by 2002:a17:906:3f4f:b0:931:4285:ea1d with SMTP id f15-20020a1709063f4f00b009314285ea1dmr5290464ejj.5.1680280858835; Fri, 31 Mar 2023 09:40:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680280858; cv=none; d=google.com; s=arc-20160816; b=Aw/EcdiPufB7cTFDH2Sb3cCA+pSoXVkKBzXrC/1r6+ajFmi8Bj0pSleJQGFhLvg42/ +LBt5ngr374fQtGKk+BVmHGm29qGw5zI8Brhw0W/r4iZXOr9gVBr58lIi85R9VCiLFBN DJxfxNOWrcRD8EaLbazKBCq/ELwThs0AgavdzU574LVDbuapmKFafPXHZG43h7+aKllb bdxv8psAlGVhjjITl2pMRsufCDZ8KuqKb45WyFFdYeesvzcf4nrdyRvEZ41qt3TCffzh Wr3TBNLFkYVqNU1hyprLItjajlghcTxB/MY+Z/K3fKvU++cheB6y9RZabSekLrnWyonn JNmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=vHfN4HzGdW8ljEF9rSlrVEZtA1KFAcSOHNA3V9Q7d+I=; b=CJH4gmJM6d3FNACALvuYAuN7GFQOnRVGochvlmUxAJgG+3jXoWz38h211l+lAMCy3Z AkNE+52e1ol6nMmKQ1T6gOqPTHGEStA17NM2QJtrkrFDAnzc7f183oC8kHNmGDo35k08 bGMD+AxkLPkvxxWCPFqkZteBtwWEf+KgwUsfRwJmWQLzRmTAC++mS0IqksHEw4z+Nzf8 Zc54RaHDaZYaEOlJo9JDj75+wFAm7WXzg59MXApdilzTpdPVYHhBcF4w85rBiR7kdwWj rkfJunHAA3uAZ/XVOMynEQ6XUk6+A3muzos3TZPdufE19MiCfUHk+Jtmf4z3uIMoLmhq F+Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sVqKIsAA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id me17-20020a170906aed100b00921792d069dsi2183275ejb.608.2023.03.31.09.40.31; Fri, 31 Mar 2023 09:40:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sVqKIsAA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232642AbjCaQcw (ORCPT + 99 others); Fri, 31 Mar 2023 12:32:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232273AbjCaQce (ORCPT ); Fri, 31 Mar 2023 12:32:34 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12B3522233; Fri, 31 Mar 2023 09:28:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8989BCE303D; Fri, 31 Mar 2023 16:28:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5BD8C433D2; Fri, 31 Mar 2023 16:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680280120; bh=73IgJtnFs2TGSAjju6TrDNqdmySf1qlRHQ3Dsp/nG/0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sVqKIsAAgSmsFGZ07bdHiEQctl6mIt2BmwFbxffGTlp1gfp/4owkzIEgCwUOxeiSs oJyjQIlfIRiUg9ZDwJhhMVYdWuIYzy8tzM0V/4zgo099W2vOnYGSikMWU9r2XMFWxU 251Rr5VIpMk9BQiTavizQ4NpzwyPkD3CXLnmkMLEaFkuiwcmHHNC+pxxiOUSI4N76u 5R+O0OtEC0xflg3/rcfq+w3fnCbNkpPzMOHpEAu2/T/1s0ifHHQkozWV2DvRvkVr0m RNub9dq8rI5HAvmlGINbb5cEmX6yFN2h4x0xrxV77NbzteAIMpCIq7VUVc4XpOT+Kd 4NmwQR3SWhmGQ== Received: by mail-yb1-f182.google.com with SMTP id r187so28051248ybr.6; Fri, 31 Mar 2023 09:28:40 -0700 (PDT) X-Gm-Message-State: AAQBX9e0rBDwESX1G/VqeDeuJs/ir6x0hLDLlBzWM9i2ITGkJbXXd8hc pjrNy/+zqu2vMybj30FKVODFZelzRYYxPRDaKA== X-Received: by 2002:a05:6902:10c3:b0:b79:4826:e8e3 with SMTP id w3-20020a05690210c300b00b794826e8e3mr12562188ybu.1.1680280120025; Fri, 31 Mar 2023 09:28:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rob Herring Date: Fri, 31 Mar 2023 11:28:28 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] of: address: Reshuffle to remove forward declarations To: Geert Uytterhoeven Cc: Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 31, 2023 at 2:52=E2=80=AFAM Geert Uytterhoeven wrote: > > Reshuffle the code to get rid of the forward declarations, which > improves readability. Is git blame smart enough to ignore this move? If not, I'd rather keep the blame than save 3 lines. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/of/address.c | 271 +++++++++++++++++++++---------------------- > 1 file changed, 133 insertions(+), 138 deletions(-)