Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1397454rwl; Fri, 31 Mar 2023 10:28:53 -0700 (PDT) X-Google-Smtp-Source: AKy350Z81YJfwa0QTqGcNgb9rxfVkBE4jgEqaJX8Ir7mBpAMKujb5lyfaqDMwcdgosbpzZ3lx1SW X-Received: by 2002:a17:906:1001:b0:93f:e5e4:8c13 with SMTP id 1-20020a170906100100b0093fe5e48c13mr18059758ejm.5.1680283732979; Fri, 31 Mar 2023 10:28:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680283732; cv=none; d=google.com; s=arc-20160816; b=BE+bT4mHPwZjsSm05XD2EUQW/wMnfNU/fm9h3nN3KtPN9wYVyWxrDD9w9IX+NHbCJk AloTQd+2WPBLWMyc23NgTCHARBaPP56dVC0t4s9ZiQLMN+dqNd4kfytOAKSCRKS2IBBh GELp3hslnuHovRN6QAArpMnlcAQ9wDJpfKxiQc81ebvROLx/hdzdgiOQudd/vOgc5P14 eI6BCPPJ+iL9ECKFoRisCvmnlnoqqV4Wa4VnnXIxq+J2w3Gddzv/mm6FzuQ//ixIqIBY OJz/wf17T1jfGX7Ur53bWBes6IB34HZLnh6XMxU8w8FraJO4oGDozHJgNjvvaCR4P+wW yX2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=1Xt2Vza4VuOQIbBeSnuYKwNlmn7kYNAg1dqBanhPej4=; b=Ee4ZWnQ3eOneN2t3K3qqj9bxZUXcMBddjHBtUgivRId+U3FyKBq1AGtboW8EmL2LLS +2e2kr90YUTMYxg0f2NRVKsgJYUI8aI1JhQGk6S44rHvbfqa0SQljHEMbAA3bui/L11q td3bEnEVHBsy29cmAfeJbELXGLJK/aeaKq+t6CciOxFwm3F5QriiaeC0KpAqmuywQpR6 KRIPo3CscPE25cAYRR342ucwxnKekXYlw4rdOCE2hG8oBacgz+6fxeY+4+Tfg4sDDy+S KnTlgd2pqZSjajRMumEg9IG6wzVvgr7Vcivlg0tF4JPzpjognyMqBiQzbI6tRplSk+Lh 2ztg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s5x+xahQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g12-20020a1709067c4c00b009335b145df8si2146843ejp.363.2023.03.31.10.28.25; Fri, 31 Mar 2023 10:28:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s5x+xahQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231800AbjCaRY7 (ORCPT + 99 others); Fri, 31 Mar 2023 13:24:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230064AbjCaRY6 (ORCPT ); Fri, 31 Mar 2023 13:24:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3710B1D2D1; Fri, 31 Mar 2023 10:24:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C6F6962A92; Fri, 31 Mar 2023 17:24:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A29DC433EF; Fri, 31 Mar 2023 17:24:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680283496; bh=DxkTNqKM5xbHWQljDAPO6QEfNmH+hRrp/m3R6vfZIhk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s5x+xahQHmZqg2hvtfQBX/wg1q4FZgNhycQd8uwdaqur40s5cY0rnWWaHp0NCKQae yVpaw3UVI9/fNAcnigNDKupjuueOy85Xh9aNsyyJpVWFgq43hEUIQsx9PS9ZJko4yX 5Cft7U/xScnEbrlv90fLD0kvEm3o5fgltfXKyA4sH0Ieft5FtIcN14HoSJEUQK+WqC 6F+pI8siSO0kVb+lBDa9y01ZqHUXz5PYZbo/fBb/0/gH2epS6jwUj6jZBkapiggg3m 45tsfGsu30YsCvn5qL4uEmnWxI8SYPJCdNOb3gswKy5FOQNIChiYFukH9kGwSy0O08 YzIn76E6S0qNw== Date: Fri, 31 Mar 2023 10:24:54 -0700 From: Jakub Kicinski To: Anjali Kulkarni Cc: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "zbr@ioremap.net" , "brauner@kernel.org" , "johannes@sipsolutions.net" , "ecree.xilinx@gmail.com" , "leon@kernel.org" , "keescook@chromium.org" , "socketcan@hartkopp.net" , "petrm@nvidia.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH v3 6/7] netlink: Add multicast group level permissions Message-ID: <20230331102454.1251a97f@kernel.org> In-Reply-To: <830EC978-8B94-42D6-B70F-782724CEC82D@oracle.com> References: <20230329182543.1161480-1-anjali.k.kulkarni@oracle.com> <20230329182543.1161480-7-anjali.k.kulkarni@oracle.com> <20230330233941.70c98715@kernel.org> <830EC978-8B94-42D6-B70F-782724CEC82D@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 Mar 2023 17:00:27 +0000 Anjali Kulkarni wrote: > > Is there a reason this is better than implementing .bind > > in the connector family and filtering there? > > Are you suggesting adding something like a new struct proto_ops for > the connector family? I have not looked into that, though that would > seem like a lot of work, and also I have not seen any infra structure > to call into protocol specific bind from netlink bind? Where you're adding a release callback in patch 2 - there's a bind callback already three lines above. What am I missing?