Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3a89c1f4-f876-3a5d-465c-6d374890b6e3@redhat.com>
Date:   Fri, 31 Mar 2023 19:34:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] Add "X570S AORUS ELITE" to known working boards
Content-Language: en-US, nl
To:     linux@weissschuh.net, Brandon Nielsen <nielsenb@jetfuse.net>
Cc:     Mark Gross <markgross@kernel.org>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230331014902.7864-1-nielsenb@jetfuse.net>
 <2cf99af4-2d6c-44b6-a133-4ff0d94dca20@weissschuh.net>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <2cf99af4-2d6c-44b6-a133-4ff0d94dca20@weissschuh.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 3/31/23 11:44, linux@weissschuh.net wrote:
> Hi,
> 
> thanks for the patch!
> 
> 
> Mar 31, 2023 04:01:37 Brandon Nielsen <nielsenb@jetfuse.net>:
> 
>> ---
>> drivers/platform/x86/gigabyte-wmi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
>> index 4dd39ab6ecfa..ca5124e31d2c 100644
>> --- a/drivers/platform/x86/gigabyte-wmi.c
>> +++ b/drivers/platform/x86/gigabyte-wmi.c
>> @@ -160,6 +160,7 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 GAMING X"),
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 I AORUS PRO WIFI"),
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570 UD"),
>> +   DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("X570S AORUS ELITE"),
>>     DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("Z690M AORUS ELITE AX DDR4"),
>>     { }
>> };
>> -- > 2.39.2
> 
> 
> This patch is missing a proper subject line, a commit message and Signed-off-by.
> Please send a v2 and take a look how similar patches are structured.
> 
> https://lore.kernel.org/lkml/20220705184407.14181-1-parherman@gmail.com/

Since I'm preparing a fixes pull-req to send to Linus today
and since this is just a simple hw-id addition I have merged this now,
so that it can be included in the fixes pull-req.

I have fixed the subject and solved the missing Signed-off-by problem
by setting myself as author and crediting Brandon with a:

Reported-by: Brandon Nielsen <nielsenb@jetfuse.net>

Regards,

Hans