Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <15c8a804-6e73-706a-d6de-fa9d84e9a0d4@redhat.com>
Date:   Fri, 31 Mar 2023 19:36:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v1] asus-nb-wmi: Add quirk_asus_tablet_mode to other ROG
 Flow X13 models
Content-Language: en-US, nl
To:     weiliang1503 <weiliang1503@gmail.com>, corentin.chary@gmail.com
Cc:     markgross@kernel.org, acpi4asus-user@lists.sourceforge.net,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230330114943.15057-1-weiliang1503@gmail.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20230330114943.15057-1-weiliang1503@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 3/30/23 13:49, weiliang1503 wrote:
> Make quirk_asus_tablet_mode apply on other ROG Flow X13 devices,
> which only affects the GV301Q model before.
> 
> Signed-off-by: weiliang1503 <weiliang1503@gmail.com>

Thank you for your patch, I've applied this patch to my fixes
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in my fixes branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans


> ---
>  drivers/platform/x86/asus-nb-wmi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index cb15acdf1..e2c9a68d1 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -464,7 +464,8 @@ static const struct dmi_system_id asus_quirks[] = {
>  		.ident = "ASUS ROG FLOW X13",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> -			DMI_MATCH(DMI_PRODUCT_NAME, "GV301Q"),
> +			/* Match GV301** */
> +			DMI_MATCH(DMI_PRODUCT_NAME, "GV301"),
>  		},
>  		.driver_data = &quirk_asus_tablet_mode,
>  	},