Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Armin Wolf <W_Armin@gmx.de>
To:     markpearson@lenovo.com, mirsad.todorovac@alu.unizg.hr
Cc:     hdegoede@redhat.com, markgross@kernel.org, thomas@t-8ch.de,
        gregkh@linuxfoundation.org, rafael@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] platform/x86: think-lmi: Fix memory leak when showing current settings
Date:   Fri, 31 Mar 2023 20:03:12 +0200
Message-Id: <20230331180312.37997-1-W_Armin@gmx.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:dO2iJJPkjfw=;Wtu1GOrIhxArCLMl3lyuq1RxcJf
 x6MPFVwYXjwWT0JxvgBUs31+AjtO7OLBl860jNuKLE8Q1numTvKWFFLblXqfRXdl+PovC6fys
 peAmRJ/xmE8+EaWPS7NqyYA86iC1PLTwuRGDU4Xw2Rt/jF0uwXONesBEnUqxPs090aZDH3M1q
 OCTS3l42S3JpYvKpxBnkXuARkjx/1YWLg+RLGfclGiQkYUHXhplbBij22IV5nj5K5iQKWALGH
 GH5HZuk1pWf/9dz338YrLG7wNtv3fgFn9jV98hRGUyX4lGOVXfhu4+nn89lr3wMOLzCEXjUEo
 RyXNs8V/dOGKBRPqy011GGUOhi5BZuHksTNDcEeKvaBS5MlEdTAzEM/Yeo1Ve7WKsqYwADb6H
 /xBjAssu7CfWmLl4zDAyG3zh3wojloWsDMOKwRmgkQA0kMX5LxxLKAkorXVHhK198As0iw674
 RsDPueIvy/acGTzQhkI3rBIaZ6V32lVhxPri8cizcL0oRCG6XVlgrQFEkdXTNXkUn+/IM+TAW
 avMqxx8BI2esSUlt5E/RnVouyoZeBFZhBls00fc4iDze9iE8i087IdiWu4GpseLDwa3bPqMKz
 j0O8TKOmrmlqRaYqY/YDspMMeeK5mT8Tb6b0Z+gtg4fiVBvKLb39U1f/kKBXLhMeDlfWk4NOH
 SZemdhn0OD8GKjeAaPKrCLj3fDpNKOyZN58EkFdrqUo9TLs2XN5oXowvt1W3puU/HqDe0GHF2
 AqzL4YYXFJMUb6IEDScUsXy4lMVbkIZYatpLSUWu4c88ih1LhX7B+HRo1fVooYB5Qj/VqvYHt
 wWGcYzmqQs/eixjq2XuTQNFTBX4HluSRNNv32+Ps6wBLbvuE1wxuOCnruaVHDZPfs9sRCoJfz
 V3uNuNlMX1DrLRvt1f87vtt9AbjSMFXS40MDvrRwTMS8PuwpqU8/QS1VK+o7O0yke4Z9xM0np
 FUAO5BIG8vTX9MgtcDHJjPcO8xU=
Precedence: bulk

When retriving a item string with tlmi_setting(), the result has to be
freed using kfree(). In current_value_show() however, malformed
item strings are not freed, causing a memory leak.
Fix this by eliminating the early return responsible for this.

Fixes: a40cd7ef22fb ("platform/x86: think-lmi: Add WMI interface support o=
n Lenovo platforms")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/platform/x86/think-lmi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think=
-lmi.c
index cc66f7cbccf2..8cafb9d4016c 100644
=2D-- a/drivers/platform/x86/think-lmi.c
+++ b/drivers/platform/x86/think-lmi.c
@@ -930,10 +930,12 @@ static ssize_t current_value_show(struct kobject *ko=
bj, struct kobj_attribute *a
 	/* validate and split from `item,value` -> `value` */
 	value =3D strpbrk(item, ",");
 	if (!value || value =3D=3D item || !strlen(value + 1))
-		return -EINVAL;
+		ret =3D -EINVAL;
+	else
+		ret =3D sysfs_emit(buf, "%s\n", value + 1);

-	ret =3D sysfs_emit(buf, "%s\n", value + 1);
 	kfree(item);
+
 	return ret;
 }

=2D-
2.30.2