Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8a04da89-1c98-8b29-bf96-1e8d0ed47e58@amd.com>
Date:   Fri, 31 Mar 2023 13:13:43 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH v5 1/4] PM: Add a sysfs file to represent time spent in
 hardware sleep state
To:     "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     Sven van Ashbrook <svenva@chromium.org>,
        John Stultz <jstultz@google.com>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        Raul Rangel <rrangel@chromium.org>,
        David E Box <david.e.box@intel.com>,
        Rajat Jain <rajatja@google.com>,
        S-k Shyam-sundar <Shyam-sundar.S-k@amd.com>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-pm@vger.kernel.org
References: <20230330194439.14361-1-mario.limonciello@amd.com>
 <20230330194439.14361-2-mario.limonciello@amd.com>
 <CAJZ5v0jbMXk5k_KG19bQnffhCkGnu=MQXjGrBPipZxA_Cg8O9w@mail.gmail.com>
 <2676888c-e93f-53aa-a4f7-e85b66f351c8@amd.com>
 <CAJZ5v0iia9__-jWmawvsxninoTM5ZRtqhyUJme=noZMZJdUBrA@mail.gmail.com>
Content-Language: en-US
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <CAJZ5v0iia9__-jWmawvsxninoTM5ZRtqhyUJme=noZMZJdUBrA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVJCZmhaTzVZTm1VMlMwZjVkR3lVVTdUcldreHpHT1IyUk9aWmhMd3ZuVzFR?=
 =?utf-8?B?ZkxqZFQ5bTNKVGt6TndUUXp6Q2pnQmNWQ1kxS2k0WTJxbHg2WGRFRmMyalp4?=
 =?utf-8?B?a1IyYm51djhUa0haSTZlWU8xcW4wOVNpL0QvYnZVa2FzdHpWb2JHQ2ZVV1lh?=
 =?utf-8?B?UGtEdWF3NnhyZVBqaUxHWkN0MVMxUHZnbi9kUnFCZGFvdFF6anduek85MUow?=
 =?utf-8?B?Mzh6dmtOMjE4RlBTL2YyN01XanladTR6M1ZROThXdXdSNm0reUZmWlNyeUZz?=
 =?utf-8?B?VVFtSEoyeUtUdHFqMkEwY0ZqNXlsMmg0aWpwQkFOWlpZMWIzWEdJRTFFNlZr?=
 =?utf-8?B?bGpBbjZDZlRLTDhMOXBwZkg3ZUNnS3JnRmhWa1VTVzV0NnA1eU00OWl3cFF4?=
 =?utf-8?B?QmVTZUczSDJOTENVdndCeElGL1NmREhKWWUySWY5aU5WU0k2Y0tyN3kyRUhO?=
 =?utf-8?B?ekxmbFk5Z0Z6ZVRIbzNOWkJ6WEd0RUR4S0xKUENEcHIwbWhWbDhwQ1YvZi81?=
 =?utf-8?B?clpWY0hqWlZxMSsrRjVZSXJBT2FtcFNKdjg5YytCTklNdWpldHlJWEpjVWll?=
 =?utf-8?B?c2FqTHNXWWR2RGtzMlRLdnU2QWxxOWcyeTNldGQvVTN4em1Zc21zdTJIczVZ?=
 =?utf-8?B?RWlOUHFVVXdpS2MvTy9EdCtSZDgwMHNmN25qVUZsbVF3L3owR1UwUnlYN3lC?=
 =?utf-8?B?SzIybWt2OTVOUVVUbVNuM012dUFxbVJuV1M4SmZBTHIxbGtMNlhlQ3QySnRt?=
 =?utf-8?B?NUZYTlVEeUptRlNCNUhZbVcwOWlrcnV5eVRJWVJiekxJcTFvUGxBWnBUeWky?=
 =?utf-8?B?Um5sSTFhMVl2ZjNEWUNZTHFhaHMvN0UySzYrL1AzaW96aU4wVUlEbjB5Vzds?=
 =?utf-8?B?MExTVWpobithS3VGa2RaM0l1STI0NkUvSlExRXh0YUQvakRKOUdXTmN4a01O?=
 =?utf-8?B?aUJ0WDZJVzFBZHUrZkZJbGRvSi9la25LRFNKM0lQYnJtdGcrdUFHVWFyVys3?=
 =?utf-8?B?U0tKN2hCKzI5YkpUUy9zRnRMcnIxQmV2VThJZys5MUoxcUkvcUFmeXdtLzNJ?=
 =?utf-8?B?eHplSllmT250ZHlwWVdYSW1xNGhwWXNrU25uaE5nNmVyMWwwQjdTNWlaZzEx?=
 =?utf-8?B?NnZWQ3hMaUlRc2NIYlBuVzZVODR6U1JKdk51R20rQjJVNlQ4bmpqQXdWR0t1?=
 =?utf-8?B?SWZnb29xNmRwSGd0T2RVUzJPb1NIOEMyQmlKSjBoREpUY2xCSllrVm00eXh6?=
 =?utf-8?B?QkJ6UGFVSXErNG10WjFXOTAvSkJLYVdqWlQzM255S25LdGRQS081NDg1bHBR?=
 =?utf-8?B?TGhGQWJMMUtUbFVjczl6VFMwZnpIL3Z0eGJOY1JMb3ZDdWFDd0xFUmp0Q003?=
 =?utf-8?B?RHF4QmF4VFhCNEllYVlPWmdmUmpmQ09Pd0dXazM4czN1T0R0KzZLdE5DaFlY?=
 =?utf-8?B?SlYzYyt0WVM5ZWJoaEFXK3RjbWdWbkFjOVM4aVBnRHBFbHI3akhsNVJ0VUJG?=
 =?utf-8?B?VjFmUWZJWlE3OUtPd3Zxc09VcDdmdS91c3E2ci9GdVhZdk1sbFpER1RTV1F6?=
 =?utf-8?B?c2p5NlA5Z3E2NGhrdHZ0dC8vc3JCUm9OVXp5TkNFeXZzQUd1eHIrQ1VBQnZr?=
 =?utf-8?B?ejhmcXQvSG9sTzZ4QjRlSWFWMnpGMEc2M3JnSG1hb1VLS3lxTWtmdWk0cFdU?=
 =?utf-8?B?S3ZQbmhxS0tQclhPRWkwR0ZCa2dpWEx1Q0kvanBlTHBnU3lYbURqa0YyazJQ?=
 =?utf-8?B?TGx3Tnh1d2Y2aFdTa1ViRjRWY1prZkhXcExBYUdTQTB2WUVhZEZxQ05yUUU3?=
 =?utf-8?B?RlY4Mm5KMXBqZk0rOXpOVkdDUlo3NHk0UVcwUWlPeC9jcEo5Qmd5UEF5YnZE?=
 =?utf-8?B?c0lHR3JnaGU4OHRCMjE5TFVRNFBiQTRQYmZiU2sxd2g5cGpaTjdkN1J4RHd3?=
 =?utf-8?B?MkFJK3JkSURCQStQT3Q4OER4eit1akF1VXhwZlZ2WDlkUVdYM0FsTnoweHlI?=
 =?utf-8?B?UzlkT21kUTdtVXNTZWd5S09HSjVuNnRJZDdQU290Qnc0dmVvdS9uZURvNmRL?=
 =?utf-8?B?THRKRmxLaUtYb01jWHBHRHB4MzNiajRwUHpTTkJ0QWtKbTVxQ2h3QWtaSXNR?=
 =?utf-8?Q?XOt7cfSpqJipqsOY0KenRxrBL?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1ea1f90-6b91-4926-bebc-08db3213ab19
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 18:13:46.1173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VYMVKwA+IUzQhLH6E1PDXOi2WMPjkPMRSjDjdD0j7JUP0YTYNfZ6y9a23eSQoQj7+eJh9rRbOwVZ3zAjI1or8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4047
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/31/2023 13:07, Rafael J. Wysocki wrote:
> On Fri, Mar 31, 2023 at 8:05 PM Limonciello, Mario
> <mario.limonciello@amd.com> wrote:
>>
>> On 3/31/2023 13:01, Rafael J. Wysocki wrote:
>>> On Thu, Mar 30, 2023 at 9:45 PM Mario Limonciello
>>> <mario.limonciello@amd.com> wrote:
>>>>
>>>> Userspace can't easily discover how much of a sleep cycle was spent in a
>>>> hardware sleep state without using kernel tracing and vendor specific sysfs
>>>> or debugfs files.
>>>>
>>>> To make this information more discoverable, introduce a new sysfs file
>>>> to represent the time spent in a sleep state.
>>>
>>> This is only in the most recent suspend-resume cycle, isn't it?
>>
>> Yes; that's correct.
>>
>>>
>>> Wouldn't it be useful to have another attribute printing the
>>> accumulated total HW sleep time?
>>>
>>
>> I had considered this; but I didn't think it was actually very useful
>> because userspace will get control at the end of every cycle and can
>> accumulate those numbers if desirable.
> 
> Unless "user space" in question is actually a human, that is.

This is what I envisioned:

* In traditional Linux some software like systemd could capture this and 
log it.
It could subtract at the time the suspend started from the time it ended 
and use that to calculate a percentage of time in hardware sleep state 
and then put that percentage in the system journal.

* In ChromeOS something like powerd would be the only thing reading this 
number and it could be adding it up during dark resume until the system 
gets to a full resume.

* If a human is manually capturing these values they'll be most 
interested in whether an individual cycle reached hardware sleep.
If it didn't they'll want to look at debug data from that cycle.
The aggregate will be noise.

Do you think of another use case?