Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 31 Mar 2023 11:37:26 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Nadav Amit <nadav.amit@gmail.com>
Subject: Re: [PATCH 10/29] selftests/mm: Test UFFDIO_ZEROPAGE only when
 !hugetlb
Message-ID: <20230331183726.GD12460@monkey>
References: <20230330155707.3106228-1-peterx@redhat.com>
 <20230330160714.3106999-1-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230330160714.3106999-1-peterx@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xDmgi5NIJQMrutiJkfI6i/nNHMkdw6mRqyqtgSLLXT6hb4w2JvUxM3hnZf3i?=
 =?us-ascii?Q?ok8NSq4kGR+oSQg7vLvlNeT5AG0IsV7PzknUIqhvjJis90reKN+8WeIliE8Z?=
 =?us-ascii?Q?AhENX5NVoy1D8AqNeLr8z1qEB81UiOBldwOM1cW9JhuITyG5hiN2E79xthA9?=
 =?us-ascii?Q?/m8LzPTdxGViUw8G0XjAKNaGqoKgS42BDgBH1TWN7GxeQ1kWPIJOvN4JGffw?=
 =?us-ascii?Q?09UD0LsTXgX26ryvyHAaRyoYQ5LwSvRdBTf9wBGxbKLJ30Gnp9MaDNwload9?=
 =?us-ascii?Q?gVwuh4x5hbRJl8nem8gNFC1N6PlqP0DrsHxCQXzLUe8VObUYkYbIgxdAKCDe?=
 =?us-ascii?Q?ba+dP1L40XTHA+uPOrEHMVVxFmBKLh+o1utl02HcyXuX1fUZJrWn8BzZyBkM?=
 =?us-ascii?Q?MssrAsy7d8VKynEGe8d69gWzBe0lE6njpVQMQY5rggv/CBp912r9tRehkDlC?=
 =?us-ascii?Q?FCEFte3L98TZC4tFn3FJ2Mf5wmD+JAik8O4MM94+Pmp6SmdGGMnNZ0aQvIe6?=
 =?us-ascii?Q?Z+mbJZ+PWpfIzYl7GsS+Ik1rctF5nxhUgzdx30yawh8leK7zTM7InB1Y5Gms?=
 =?us-ascii?Q?2Cnkjwmj+/nVjnomZtD4z1xOzoaaPaDWAhZ7Z1g04E4MSt4GXLMLRh/rHg2h?=
 =?us-ascii?Q?Ow/9JFQAEJFIwc8VPWcUfpUMOpcgTqDFDV8v5MB+XVCsB+uelgLSyKoGz/xt?=
 =?us-ascii?Q?IiIQVvbWwG8KCuxSjObCcIuW8jQ1V/S40/9ipR9rFrTp1Ki365h8CrDWjA0D?=
 =?us-ascii?Q?zJBeN4enELNrWmZ7avxCuSDjmxTQdS8PuHGoHR0dMPM+yT/PbvJY8QWBx4L5?=
 =?us-ascii?Q?7JWblb2wV/IQ3iRxFsYqZiL45Zy6AH653V1yR7BoFllVAfgfnZmLm9eTuN5l?=
 =?us-ascii?Q?LpBb0Kjus7BP1DUrK4YJ8AMIUtWnVz6zeghcEj8TTOZttqbmeRzTo2N0FTjI?=
 =?us-ascii?Q?7klp9Q4sNxxrfK50aKPbFiJDMMG6RIgtVSyYsQDx+pdH8b3idfYgh7Rs2VY5?=
 =?us-ascii?Q?SvnO8sEHkoGhCEQVek7GxRqGFOlqOzzbyK+iLBlNLXbiIFgUYstVusffzSw7?=
 =?us-ascii?Q?UsvhftW/EWUTf8iN3FFcsS6pAVAu0u1YJnKcAYZliOMgPgjni3Af3UWb2HVd?=
 =?us-ascii?Q?BuQ3RD8oU7qQqXphKeOjKx0dSmomV7cvpUSy8g7oq3DUzUVYFe5+VI6S/l8E?=
 =?us-ascii?Q?elXsrJAQAHcl/W9GFktLj1p1LvU7NWEd7LF41wtjFzHB1vxkgd1StB7x9PFu?=
 =?us-ascii?Q?r+8fMDpaEa51V0OOZB2A3mrSdWgimGrAcRSLEq0w4r7H2abdYwEAxBN0WRKb?=
 =?us-ascii?Q?QmeSsNQO9o6DpfEqeiPVzGldHsuzbsuDJo8TV+Ktg+ogM96x97v0ioroZ8+y?=
 =?us-ascii?Q?6eN0P9yTXa6cpFnwchB9RhlX7PzhxM1bp5ITPG1E7vfMBcPTxCiyatss0yxU?=
 =?us-ascii?Q?UqAw0xU2SnS/ZDb/AV4z0hP1+ClgBHBpN5OP8L2XN09A9Lufm0HT70F85648?=
 =?us-ascii?Q?G6b/byENiJLEq9LBwH131VKBqQE1lzAcFZZfQTMshJ7Z2yMb3YqMrTwVveJC?=
 =?us-ascii?Q?ZElqvNfcwiww20tlB9rgPmf7bgt3rdDpgFPEl1Y3d+p5c2TGTrpgbGTdCN/g?=
 =?us-ascii?Q?5Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?AfRyFaVji3kMZaYIBGcUC5SH0hZgS/25+kV0gyJVVDfvRlIDse4eZRqWx4BF?=
 =?us-ascii?Q?wmt6SiillhF5Dcpm9Mikf1Q4DX/y7S3eyfruPmKRQEToPbrpKbAR65lXARtg?=
 =?us-ascii?Q?CvUQWAwOJswC9f4J5DHz4rakNS10/oo+2w7ca3Y4aNla2h8KmuDCG7G14KvO?=
 =?us-ascii?Q?Bct14YxiExyuqbnfCmnUdv4Mbkbz9septCrVjobxyTP+GOnFu55Tc9TF4wfs?=
 =?us-ascii?Q?eHuP6PcbAa61StEsc4W7FavnKiG5vwChOaFg3fkLNn4aFlHitb8d6i4b4E6m?=
 =?us-ascii?Q?pvaLFWxDztdczWwwdMmgpgWn8FtcM/Fl+0eZCVKedQy7DAzxFVz6mKLNHu3k?=
 =?us-ascii?Q?9pkUq/rLmDlBJQ0TrifeNnbZhsuR7KLitbqzGafauKKpXLzkFcsu+8LIGX79?=
 =?us-ascii?Q?YIUvmKWZn5Sk69DefR7TaEsmU+3H1vbKjUlsXPOJu05OQJAxsS8TjdKgm5xI?=
 =?us-ascii?Q?TVdnWGc/RRno1Y+2g2JoYV6qMJJK/zzE2x8EF/97kV4HfO1/E6hYCm2Fm0Wf?=
 =?us-ascii?Q?v8c9c2BzQmtxTcfgVzW8MgBKG9HclkSVqSnqxQ4kF8tM8rzi1cHHaqeavKdn?=
 =?us-ascii?Q?gmWCgre5+ZYs+VV/FAmqQrPQG4G9YcaXXNAGzJFlkn1qun5RzwVlg4S7yDhT?=
 =?us-ascii?Q?azQF1WEoh65UALkmHlcNZXOqxb8Eug4z2f5GwWdT57t09B3Qp9d3E7ZAmZQ1?=
 =?us-ascii?Q?a57q/W/DBewuOyuV0C3x0AtqB8v1VY9MoIk7P4fNOvdSbLTkCmxZZ4cwLBfe?=
 =?us-ascii?Q?JY+YfsGB/OeCzqG1aBm6yXP3ZYjk4amNp4fSXIiBUgecwcOA+2uZ/l8haIk4?=
 =?us-ascii?Q?UgwtWlxUzomM+3p3pyWaHp+5wewFbqbLEjDTD0oBA5cNEleDRT/P9i3xJMGx?=
 =?us-ascii?Q?/acp97cm7UzaOMpUxkHYslUoi0JqU0W/NWoLtldiVTs+U7RznJ08lCZatBbR?=
 =?us-ascii?Q?FNprTsPlxjd8ughvXoRSwFpQthVZ2fnMB1S/C8U6mf4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48b07ba3-4db6-41bf-16e7-08db3216fb69
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 18:37:29.4266
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4cDxB/P6Pzl2cRi81QZtJC46jwBRLDaOKwLXdxEoXebWqaOFfcGEHZHTw7wRMG6g81K12RkWwFU9XQ8IQ2bdLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB7484
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-31_07,2023-03-31_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0
 suspectscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2303310149
X-Proofpoint-GUID: SwXEDkTkjn81J9Aghm-_J4CD8IgZizGi
X-Proofpoint-ORIG-GUID: SwXEDkTkjn81J9Aghm-_J4CD8IgZizGi
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/30/23 12:07, Peter Xu wrote:
> Make the check as simple as "test_type == TEST_HUGETLB" because that's the
> only mem that doesn't support ZEROPAGE.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  tools/testing/selftests/mm/userfaultfd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/userfaultfd.c b/tools/testing/selftests/mm/userfaultfd.c
> index 795fbc4d84f8..d724f1c78847 100644
> --- a/tools/testing/selftests/mm/userfaultfd.c
> +++ b/tools/testing/selftests/mm/userfaultfd.c
> @@ -1118,7 +1118,7 @@ static int __uffdio_zeropage(int ufd, unsigned long offset, bool retry)
>  {
>  	struct uffdio_zeropage uffdio_zeropage;
>  	int ret;
> -	bool has_zeropage = get_expected_ioctls(0) & (1 << _UFFDIO_ZEROPAGE);
> +	bool has_zeropage = !(test_type == TEST_HUGETLB);

It is true that hugetlb is the only mem type that does not support zeropage.
So, the change is correct.

However, I actually prefer the explicit check that is there today.  It seems
more like a test of the API.  And, is more future proof is code changes.

Just my opinion/thoughts, not a strong objection.
-- 
Mike Kravetz