Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1481347rwl; Fri, 31 Mar 2023 11:47:20 -0700 (PDT) X-Google-Smtp-Source: AKy350agV795Tx+OQiRc9CB3joWlbOl87p7f42ZvCv9uW8PWtUVcwU3MyS4QK7OXSsDZz8/lKzYz X-Received: by 2002:a05:6402:524e:b0:500:3fd0:25a8 with SMTP id t14-20020a056402524e00b005003fd025a8mr6728548edd.0.1680288440343; Fri, 31 Mar 2023 11:47:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680288440; cv=none; d=google.com; s=arc-20160816; b=z2RwjdzO8JdzBxQ4RKMdNBF7TZcoU8GKR9lNtsbOEwmMzcF8D+q+iORgiQqZ3cX8sq tzsAFFQnZBbWLnnSgh8TQRQnuFkpF6zCHQ2lpr8SQCigd/T52GL9KkqQhmCPCeakFPG4 PDKprPi+yjVQDqqnew6UJ7vrDtpO57E6EdvWIcOwGTclDx0TI0spcNgMsIQwR/51NaRx I+Mx86y1G06QR263D7RKP6d2SbJhpQ0a4gxpYzP840brKq0f1SWrHvjCyTpKEMyHNLmE YC/UiMA+q3VzO1Wg26J/FGgpNwE1CKOKBtDcukqXnhCbNzIZ7G0HsK2xw3YBKUQgwprI HIOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TIlC9F7porC8Z4XNqnlpBIxmlsjG4JovEy5roUq2yUY=; b=ygXMdqiu207+3/A/kU9aDkjHAWh9QlWWSVoHPOD3BTO+CWhabm2hFQa6vozCsQ9FIE Uflt2DSYC+gtBF7TrhBV+nm9h/eVh1GfECdYXqnMP2+BsWdkF0IYCy6pPUYnY8blpE6t TwUY66lgDo/EcSjPvcUfV8K9gi7u/RiCpS/QzNgYgQ0RkoC205Q9wUo++FIBKa1n0GQv SUqO6B50CwU4msBmQ1iLI/r6NxlyYUoUTF14CkDAIQRw/lKQvtnK1gN73WVJ7A8UfK2Z tuFTpZ6Uj4L5e85HFl8Ekfi0slfcBO9K+CTaBSL7ziIF8YpIFvhEniNlIThHzTvdaAm/ BlPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VxtkU6Ha; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y6-20020a056402134600b004fe94d86d53si2856129edw.240.2023.03.31.11.46.55; Fri, 31 Mar 2023 11:47:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VxtkU6Ha; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232021AbjCaSls (ORCPT + 99 others); Fri, 31 Mar 2023 14:41:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbjCaSlq (ORCPT ); Fri, 31 Mar 2023 14:41:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 942336A42; Fri, 31 Mar 2023 11:41:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 27A96B831AB; Fri, 31 Mar 2023 18:41:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6508AC433EF; Fri, 31 Mar 2023 18:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680288102; bh=3p/O9/CLo4800DOPyq8SsH+lR09J6hidgfyfB1UwbMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VxtkU6Hac0u1ir+DqGNebk0fkqDIppqx0euv07VJQ4ZQFAzvG2M8ZmXeot+AiC8vt 4fYnwSsGiYMhjfNGImhXbimSozpRmJM9XSnRHQuwvj1aaThMxY+AncV2401PXXy4O8 xZYFO7RDOUYKKKsTE3szzVMRFHYluYppqPDYdK9cXnMUuY6N8wKB1jVIlNYtSZh4gn 2IQpz6LL0OYndgZIbrH88Qi3HBKz+h9mOC0eMcWADuiD66iaf/zgXg3a00C/48A6sG EwPpJdlxToLadYc9P0IwfGIWuuI5prNQ3wpJFnaBKTNPmfGD5Ai/IpNKTUhMWWzsyH 3WZWez09Bwtbg== Date: Fri, 31 Mar 2023 19:41:35 +0100 From: Conor Dooley To: guoren@kernel.org Cc: arnd@arndb.de, palmer@rivosinc.com, tglx@linutronix.de, peterz@infradead.org, luto@kernel.org, conor.dooley@microchip.com, heiko@sntech.de, jszhang@kernel.org, lazyparser@gmail.com, falcon@tinylab.org, chenhuacai@kernel.org, apatel@ventanamicro.com, atishp@atishpatra.org, mark.rutland@arm.com, ben@decadent.org.uk, bjorn@kernel.org, palmer@dabbelt.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Guo Ren , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Yipeng Zou Subject: Re: [PATCH -next V17 4/7] riscv: entry: Convert to generic entry Message-ID: References: <20230222033021.983168-1-guoren@kernel.org> <20230222033021.983168-5-guoren@kernel.org> <60ee7c26-1a70-427d-beaf-92e2989fc479@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wc5Ye/0zXmFh17VW" Content-Disposition: inline In-Reply-To: <60ee7c26-1a70-427d-beaf-92e2989fc479@spud> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wc5Ye/0zXmFh17VW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 31, 2023 at 07:34:38PM +0100, Conor Dooley wrote: > On Tue, Feb 21, 2023 at 10:30:18PM -0500, guoren@kernel.org wrote: > > From: Guo Ren > >=20 > > This patch converts riscv to use the generic entry infrastructure from > > kernel/entry/*. The generic entry makes maintainers' work easier and > > codes more elegant. Here are the changes: > >=20 > > - More clear entry.S with handle_exception and ret_from_exception > > - Get rid of complex custom signal implementation > > - Move syscall procedure from assembly to C, which is much more > > readable. > > - Connect ret_from_fork & ret_from_kernel_thread to generic entry. > > - Wrap with irqentry_enter/exit and syscall_enter/exit_from_user_mode > > - Use the standard preemption code instead of custom >=20 > This has unfortunately broken booting my usual NFS rootfs on both my D1 > and Icicle. It's one of the Fedora images from David, I think this one: > http://fedora.riscv.rocks/kojifiles/work/tasks/3933/1313933/ >=20 > It gets pretty far into things, it's once systemd is operational that > things go pear shaped: Shoulda said, can share the full logs if required of course, but they're quite verbose cos systemd etc. >=20 > [ OK ] Mounted Huge Pages File System. > [ 70.297439] systemd[1]: Mounted POSIX Message Queue File System. > [ OK ] Mounted POSIX Message Queue File System. > [ 70.453489] systemd[1]: Mounted Kernel Debug File System. > [ OK ] Mounted Kernel Debug File System. > [ 70.516331] systemd[1]: Mounted Kernel Trace File System. > [ OK ] Mounted Kernel Trace File System. > [ 70.679253] systemd[1]: modprobe@configfs.service: Succeeded. > [ 70.788400] systemd[1]: Finished Load Kernel Module configfs. > [ OK ] Finished Load Kernel Module configfs. > [ 71.501222] systemd[1]: modprobe@drm.service: Succeeded. > [ 71.573295] systemd[1]: Finished Load Kernel Module drm. > [ OK ] Finished Load Kernel Module drm. > [ 71.825934] systemd[1]: modprobe@fuse.service: Succeeded. > [ 71.886945] systemd[1]: Finished Load Kernel Module fuse. > [ OK ] Finished Load Kernel Module fuse. > [ 71.991932] systemd[1]: nfs-convert.service: Succeeded. > [ 72.034674] systemd[1]: Finished Preprocess NFS configuration converti= on. > [ OK ] Finished Preprocess NFS configuration convertion. > [ 72.148778] systemd[1]: systemd-modules-load.service: Main process exi= ted, code=3Dexited, status=3D1/FAILURE > [ 72.256659] systemd[1]: systemd-modules-load.service: Failed with resu= lt 'exit-code'. > [ 72.337818] systemd[1]: Failed to start Load Kernel Modules. > [FAILED] Failed to start Load Kernel Modules. > See 'systemctl status systemd-modules-load.service' for details. > [ 72.410491] systemd[1]: systemd-modules-load.service: Consumed 1.463s = CPU time. > [ 72.496739] systemd[1]: Condition check resulted in FUSE Control File = System being skipped. > [ 72.513689] systemd[1]: Condition check resulted in Kernel Configurati= on File System being skipped. > [ 72.682549] systemd[1]: Starting Apply Kernel Variables.. > [ OK ] Finished Apply Kernel Variables. > [ 76.314434] systemd[1]: Finished Load/Save Random Seed. > [ OK ] Finished Load/Save Random Seed. > [*** ] (1 of 6) A start job is running for=E2=80=A6p Virtual Console (1= 4s / no limit) > [ OK ] Finished Create Static Device Nodes in /dev. > [ 79.787065] systemd[1]: Started Entropy Daemon based on the HAVEGE alg= orithm. > [ OK ] Started Entropy Daemon based on the HAVEGE algorithm. > [ 80.186295] systemd[1]: Starting Journal Service... > Starting Journal Service... > [ 80.713508] systemd[1]: Starting Rule-based Manager for Device Events = and Files... > Starting Rule-based Manage=E2=80=A6for Device Events and Files... > [ *** ] (2 of 7) A start job is running for=E2=80=A6 All udev Devices (1= 7s / no limit) > [ 82.939347] systemd[1]: systemd-journald.service: Main process exited,= code=3Dexited, status=3D1/FAILURE > [ 83.032046] systemd[1]: systemd-journald.service: Failed with result '= exit-code'. > [FAILED] Failed to start Journal Service. > See 'systemctl status systemd-journald.service' for details. > [ 83.210041] systemd[1]: Dependency failed for Flush Journal to Persist= ent Storage. > [DEPEND] Dependency failed for Flus=E2=80=A6Journal to Persistent Storage. > [ 83.254122] systemd[1]: systemd-journal-flush.service: Job systemd-jou= rnal-flush.service/start failed with result 'dependency'. > [ 83.272366] systemd[1]: systemd-journald.service: Consumed 1.443s CPU = time. > [ 83.334360] systemd[1]: systemd-journald.service: Scheduled restart jo= b, restart counter is at 1. > [ 83.427839] systemd[1]: Finished Setup Virtual Console. > [ OK ] Finished Setup Virtual Console. > [ 83.510650] systemd[1]: Stopped Journal Service. > [ OK ] Stopped Journal Service. > [ 83.554417] systemd[1]: systemd-journald.service: Consumed 1.443s CPU = time. > [ 83.576573] systemd[1]: Condition check resulted in Journal Audit Sock= et being skipped. > [ 83.904878] systemd[1]: Starting Journal Service... > Starting Journal Service... > [ 85.752090] systemd[1]: systemd-journald.service: Main process exited,= code=3Dexited, status=3D1/FAILURE > [ 85.826421] systemd[1]: systemd-journald.service: Failed with result '= exit-code'. > [ 85.876165] systemd[1]: Failed to start Journal Service. > [FAILED] Failed to start Journal Service. > See 'systemctl status systemd-journald.service' for details. > [ 85.952221] systemd[1]: systemd-journald.service: Consumed 1.355s CPU = time. > [ 86.002092] systemd[1]: systemd-journald.service: Scheduled restart jo= b, restart counter is at 2. > [ 86.015081] systemd[1]: Stopped Journal Service. > [ OK ] Stopped Journal Service. > [ 86.076429] systemd[1]: systemd-journald.service: Consumed 1.355s CPU = time. > [ 86.089700] systemd[1]: Condition check resulted in Journal Audit Sock= et being skipped. > [ 86.390162] systemd[1]: Starting Journal Service... > Starting Journal Service... > [ 87.904427] systemd[1]: systemd-journald.service: Main process exited,= code=3Dexited, status=3D1/FAILURE > [ 87.950259] systemd[1]: systemd-journald.service: Failed with result '= exit-code'. > [ 88.000661] systemd[1]: Failed to start Journal Service. > [FAILED] Failed to start Journal Service. > See 'systemctl status systemd-journald.service' for details. > [ 88.079953] systemd[1]: systemd-journald.service: Consumed 1.316s CPU = time. > [ 88.128956] systemd[1]: systemd-journald.service: Scheduled restart jo= b, restart counter is at 3. > [ 88.145365] systemd[1]: Stopped Journal Service. > [ OK ] Stopped Journal Service. > [ 88.189975] systemd[1]: systemd-journald.service: Consumed 1.316s CPU = time. > [ 88.205799] systemd[1]: Condition check resulted in Journal Audit Sock= et being skipped. > [ 88.514817] systemd[1]: Starting Journal Service... > Starting Journal Service... >=20 > (Note, you need to merge -rc2 into riscv/for-next to actually boot) >=20 > Cheers, > Conor. --wc5Ye/0zXmFh17VW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZCcpXwAKCRB4tDGHoIJi 0gW6AQDI28/go9okNXNTDXLjSCttIpeBd0rRc4eSF+3vqbawegD/VWTdRfmbB6Ug Q4XU0kzKQwFyM3Rx5dTOeUOUKZOQxwU= =0M5y -----END PGP SIGNATURE----- --wc5Ye/0zXmFh17VW--