Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 31 Mar 2023 21:46:33 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sricharan Ramabadhran <quic_srichara@quicinc.com>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        mani@kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-arm-msm@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] net: qrtr: Do not do DEL_SERVER broadcast after
 DEL_CLIENT
Message-ID: <ZCc4mV9slbY1eVZl@corigine.com>
References: <1680248937-16617-1-git-send-email-quic_srichara@quicinc.com>
 <20230331080216.GA6352@thinkpad>
 <4792f5c8-2902-2e46-b663-22cffe450556@quicinc.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4792f5c8-2902-2e46-b663-22cffe450556@quicinc.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z3QxY4aSvy/xGfEc9i4MF1PAOqy40yVTX450Pvgx/J8XMOtHP3Ymz8cG1I7I?=
 =?us-ascii?Q?AYD6bw87+5XbKwyoR6mPKzgZ+NGrLnU+3jdESO5RVSZicO0lvTjsQT6sC5v6?=
 =?us-ascii?Q?SzTYkrLZEXR1PnwxxNJ/FwbBU7etC0Kge/k8WS6WUEfMUQcYFHq3TMJYDROS?=
 =?us-ascii?Q?B+4YyaX/ej8AuFHhNHmUn/W905N6ah2fDYYvL70kx0Cotm9ugg3L1ejow8dR?=
 =?us-ascii?Q?ckjHqJyWXALJ9worJCyh5/LOsTPCLNGJvDApkV9oQ0IxmkFQOAkwC1BNxsMA?=
 =?us-ascii?Q?vmpY4w8m8y7RqAVRUXBHFTF1ytOzZI9u5RNvzij5vxNjxtHmYi+Dd24yIewC?=
 =?us-ascii?Q?6LAswzuVVDj5ZU6Iw8Zot6zpy56zowjzszRe/c+yTOskRLc+jCeqiVmnvyep?=
 =?us-ascii?Q?4VleU8Z/miOs7lfhpty8p4t4lgZF8x3ZAg8sEBevYQIkP1qojrRvPjzLAl21?=
 =?us-ascii?Q?swSPtlDkGm09CffKqLzighHECsK8FKqwqCoXZVtbPAiaK4GwvtaTYYOsr/OS?=
 =?us-ascii?Q?yxExNRED7VIRv23G9TXWQb+Lw9TdU5Sort7TZccE3FUhGwfhbU9Me5rfOTP9?=
 =?us-ascii?Q?ObJFFikDUVl4eYO7mGgxTggV24iy8mye+VffUmC0WEG5zZS3L8+2E/8ExNqI?=
 =?us-ascii?Q?zvOwYKXStUNsOJIGeK3CSNjzvH3GebwEl3CVViaua9qjhg/7etK82G2ARQCr?=
 =?us-ascii?Q?OZUiOHzMfTgvtVmrvnwyjLF/teOR5Rg981njNt7AYya306kOuduT8cYe1TWW?=
 =?us-ascii?Q?c7irsDacolAKtDUiAb7+84z1zPC++2Wxcprc1QpmSciRfCw5kAP4Rlij3w+S?=
 =?us-ascii?Q?Q8eqOEgJqGbtUcuoxUxCddE1CW8gI1kGSu2fa1e6xKDjtj2a3XCI5UPaD+ne?=
 =?us-ascii?Q?WXOOt1Qpgwbf3atEiLv/hpeEKwetn+6LnoBrG8U89+Gjedgzb6OJQ9UoxnBz?=
 =?us-ascii?Q?bEg77y960ZbO49m6Npltn24rCUou7khZ6LpTWCCF3iw9w4wYwh8uqfOsmMdM?=
 =?us-ascii?Q?jXSjCtvW4Ud7JYXNP27H4qj/DH+CAqmuazwNVay0m79iayeH+qeXixkRRBYj?=
 =?us-ascii?Q?WDfyw0v9tEYN+M4Itq249i79NMXd92zecbI4zft7HTrUmhmp6681n45A3o9i?=
 =?us-ascii?Q?dN+Mw38qh1h9ovamUKTynmUlPzu/pCRv+PapfTP5WWWFjhZnV6VB++bPMhz1?=
 =?us-ascii?Q?CTw4jJjHxl5in10MbZvnhrXc98bJOqWzRR8wvr6ef+4JF8w3yEkZU6nqrRvc?=
 =?us-ascii?Q?Kz1UxQl6UZURzy1Bcr5+/Df5XFmWfs0OKak5g4WHZNx35Ujkx6KjRVv5I9CQ?=
 =?us-ascii?Q?GgNUEmF47nITTD/E+NaG3YWj6tZQTwxYNXLVzLT2l/zQX9upyvPaMtbEef2E?=
 =?us-ascii?Q?aTlggPIEupMacTxU4xknG5+52cpTX0dfp94Ghaj8ImOXmujlIItBfq9Bk3zm?=
 =?us-ascii?Q?syb9YIoVDNlIDaZYtssJXBQwB6iwfztt/MPBlPjv7yPH9pMqK8EeA+S+NiEm?=
 =?us-ascii?Q?drg7xF3Xv32rsJzo9eYSvXUZdfLEEP64xj57fxkHaax7D4yeYwD6u/thgylR?=
 =?us-ascii?Q?kgETpnuu8odU6OXPraa+bAy1w3Wi+nYB2PNlXWHIXI6LE0irg6URsKF5AvB+?=
 =?us-ascii?Q?SCsd4WkPKAuokt1l63cPdgvTUUWH7QsDC70LI7E3/+erqlyB4jAB6gUyrlts?=
 =?us-ascii?Q?IQ4fBQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9b2582d-c780-4fc7-e6c5-08db3220a6d6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 19:46:42.5041
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9poQJ6+dJoH8foi15DkLlBwVkhYkGwrhMyzc/IMmtIJ03m5uhU3H1iV9WaXG8qExaCf1d/zehaNdO3o9/5xDoxV05P9SRzLIGUjYs04GD7k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3642
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 31, 2023 at 02:02:04PM +0530, Sricharan Ramabadhran wrote:
> <..>
> 
> > > -static int server_del(struct qrtr_node *node, unsigned int port)
> > > +static int server_del(struct qrtr_node *node, unsigned int port, bool bcast)
> > >   {
> > >   	struct qrtr_lookup *lookup;
> > >   	struct qrtr_server *srv;
> > > @@ -287,7 +287,7 @@ static int server_del(struct qrtr_node *node, unsigned int port)
> > >   	radix_tree_delete(&node->servers, port);
> > >   	/* Broadcast the removal of local servers */
> > > -	if (srv->node == qrtr_ns.local_node)
> > > +	if (srv->node == qrtr_ns.local_node && bcast)
> > >   		service_announce_del(&qrtr_ns.bcast_sq, srv);
> > >   	/* Announce the service's disappearance to observers */
> > > @@ -373,7 +373,7 @@ static int ctrl_cmd_bye(struct sockaddr_qrtr *from)
> > >   		}
> > >   		slot = radix_tree_iter_resume(slot, &iter);
> > >   		rcu_read_unlock();
> > > -		server_del(node, srv->port);
> > > +		server_del(node, srv->port, true);
> > >   		rcu_read_lock();
> > >   	}
> > >   	rcu_read_unlock();
> > > @@ -459,10 +459,13 @@ static int ctrl_cmd_del_client(struct sockaddr_qrtr *from,
> > >   		kfree(lookup);
> > >   	}
> > > -	/* Remove the server belonging to this port */
> > > +	/* Remove the server belonging to this port but don't broadcast
> > 
> > This is still not as per the multi line comment style perferred in kernel.
> > Please read: https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting
> > 
> 
>  Ho, i had it like first style and checkpatch cribbed. Then changed it
>  as per the second style for net/ format. You mean we should stick to
>  1 st style ?

I think that what you have matches the preferred style for net/ code,
and thus is correct for this patch.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#multi-line-comments