Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762300AbXIVJac (ORCPT ); Sat, 22 Sep 2007 05:30:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751057AbXIVJaW (ORCPT ); Sat, 22 Sep 2007 05:30:22 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:37829 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751230AbXIVJaU (ORCPT ); Sat, 22 Sep 2007 05:30:20 -0400 Date: Sat, 22 Sep 2007 10:30:17 +0100 From: Christoph Hellwig To: Andi Kleen Cc: vapier@gentoo.org, patches@x86-64.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [32/45] x86_64: hide cond_syscall behind __KERNEL__ Message-ID: <20070922093017.GB27827@infradead.org> Mail-Followup-To: Christoph Hellwig , Andi Kleen , vapier@gentoo.org, patches@x86-64.org, linux-kernel@vger.kernel.org References: <200709211044.901175000@suse.de> <20070921204514.DF01414EFF@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070921204514.DF01414EFF@wotan.suse.de> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 35 On Fri, Sep 21, 2007 at 10:45:14PM +0200, Andi Kleen wrote: > From: Mike Frysinger > > This brings x86_64 into line with all other architectures by only defining > cond_syscall() when __KERNEL__ is defined. > > Signed-off-by: Mike Frysinger > Signed-off-by: Andrew Morton > Signed-off-by: Andi Kleen > Index: linux/include/asm-x86_64/unistd.h > =================================================================== > --- linux.orig/include/asm-x86_64/unistd.h > +++ linux/include/asm-x86_64/unistd.h > @@ -676,6 +676,7 @@ asmlinkage long sys_rt_sigaction(int sig > #endif /* __KERNEL__ */ This is the previous __KERNEL__ block. > #endif /* __NO_STUBS */ And this one shouldn't extent iver the declarations of sys_iopl and sys_rt_sigactions I think. If it should be there at all. So please make this file at least semi-clean while you're at it instead of much worse. The __KERNEL__ block should also be extended over the various __ARCH_WANT_ definitions because they're not for userspace at all. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/