Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 31 Mar 2023 14:44:44 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     patchwork-bot+netdevbpf@kernel.org
Cc:     Arnd Bergmann <arnd@kernel.org>, kuba@kernel.org, arnd@arndb.de,
        davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        razor@blackwall.org, kerneljasonxing@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: netcp: MAX_SKB_FRAGS is now 'int'
Message-ID: <20230331214444.GA1426512@dev-arch.thelio-3990X>
References: <20230331074919.1299425-1-arnd@kernel.org>
 <168025201885.3875.15510680598248652530.git-patchwork-notify@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <168025201885.3875.15510680598248652530.git-patchwork-notify@kernel.org>
Precedence: bulk

On Fri, Mar 31, 2023 at 08:40:18AM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net.git (main)
> by David S. Miller <davem@davemloft.net>:
> 
> On Fri, 31 Mar 2023 09:48:56 +0200 you wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > The type of MAX_SKB_FRAGS has changed recently, so the debug printk
> > needs to be updated:
> > 
> > drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_create_interface':
> > drivers/net/ethernet/ti/netcp_core.c:2084:30: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'int' [-Werror=format=]
> >  2084 |                 dev_err(dev, "tx-pool size too small, must be at least %ld\n",
> >       |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > [...]
> 
> Here is the summary with links:
>   - net: netcp: MAX_SKB_FRAGS is now 'int'
>     https://git.kernel.org/netdev/net/c/c5b959eeb7f9

net now warns:

  In file included from include/linux/device.h:15,
                   from include/linux/dma-mapping.h:7,
                   from include/linux/skbuff.h:28,
                   from include/linux/if_ether.h:19,
                   from include/linux/ethtool.h:18,
                   from include/linux/phy.h:16,
                   from include/linux/of_net.h:9,
                   from drivers/net/ethernet/ti/netcp_core.c:16:
  drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_create_interface':
  drivers/net/ethernet/ti/netcp_core.c:2084:30: error: format '%d' expects argument of type 'int', but argument 3 has type 'long unsigned int' [-Werror=format=]
   2084 |                 dev_err(dev, "tx-pool size too small, must be at least %d\n",
        |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
    110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
        |                              ^~~
  include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
    144 |         dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
        |                                                        ^~~~~~~
  drivers/net/ethernet/ti/netcp_core.c:2084:17: note: in expansion of macro 'dev_err'
   2084 |                 dev_err(dev, "tx-pool size too small, must be at least %d\n",
        |                 ^~~~~~~
  drivers/net/ethernet/ti/netcp_core.c:2084:73: note: format string is defined here
   2084 |                 dev_err(dev, "tx-pool size too small, must be at least %d\n",
        |                                                                        ~^
        |                                                                         |
        |                                                                         int
        |                                                                        %ld
  cc1: all warnings being treated as errors

The commit this patch is fixing is only in net-next and my patch to fix
this warning is already applied:

https://git.kernel.org/netdev/net-next/c/3292004c90c8

c5b959eeb7f9 should be reverted in net (I am running out of time today
otherwise I would just send a patch).

Cheers,
Nathan