Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: iad51458e:Fastmail
Date:   Fri, 31 Mar 2023 15:23:17 -0700
From:   Boqun Feng <boqun.feng@gmail.com>
To:     y86-dev@protonmail.com
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Gary Guo <gary@garyguo.net>,
        =?iso-8859-1?Q?Bj=F6rn?= Roy Baron <bjorn3_gh@protonmail.com>,
        Alice Ryhl <alice@ryhl.io>, rust-for-linux@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Alice Ryhl <aliceryhl@google.com>
Subject: Re: [PATCH v4 01/15] rust: enable the `pin_macro` feature
Message-ID: <ZCddVfb9vUw8j7u/@boqun-archlinux>
References: <20230331215053.585759-1-y86-dev@protonmail.com>
 <20230331215053.585759-2-y86-dev@protonmail.com>
 <ZCdWErZLBFl205UP@boqun-archlinux>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZCdWErZLBFl205UP@boqun-archlinux>
Precedence: bulk

On Fri, Mar 31, 2023 at 02:52:18PM -0700, Boqun Feng wrote:
> On Fri, Mar 31, 2023 at 09:51:35PM +0000, y86-dev@protonmail.com wrote:
> > From: Benno Lossin <y86-dev@protonmail.com>
> > 
> > This feature enables the use of the `pin!` macro for the `stack_pin_init!`
> > macro. This feature is already stabilized in Rust version 1.68.
> > 
> > Signed-off-by: Benno Lossin <y86-dev@protonmail.com>
> > Cc: Gary Guo <gary@garyguo.net>
> > Cc: Andreas Hindborg <a.hindborg@samsung.com>
> > Cc: Alice Ryhl <aliceryhl@google.com>
> 
> Acked-by: Boqun Feng <boqun.feng@gmail.com>
> 

Hmm.. actually I think you will need to add this in the
scripts/Makefile.build, because the user (stack_pin_init!()) is a macro,
feel free to add my acked-by after that.

Regards,
Boqun

> Regards,
> Boqun
> 
> > ---
> >  rust/kernel/lib.rs | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> > index 223564f9f0cc..4317b6d5f50b 100644
> > --- a/rust/kernel/lib.rs
> > +++ b/rust/kernel/lib.rs
> > @@ -17,6 +17,7 @@
> >  #![feature(core_ffi_c)]
> >  #![feature(dispatch_from_dyn)]
> >  #![feature(generic_associated_types)]
> > +#![feature(pin_macro)]
> >  #![feature(receiver_trait)]
> >  #![feature(unsize)]
> > 
> > --
> > 2.39.2
> > 
> >