Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <db59f6df-feb0-280d-88bd-6bbf1b6e7a1e@intel.com>
Date:   Fri, 31 Mar 2023 16:26:11 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.1
Subject: Re: [PATCH v3 10/19] x86/resctrl: Allow resctrl_arch_rmid_read() to
 sleep
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>
References: <20230320172620.18254-1-james.morse@arm.com>
 <20230320172620.18254-11-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230320172620.18254-11-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmo5cHdPeWJnVTFVOEJLM0hIeitMRnN1ZkVYQnQ1YXQ2OHgyNVlBc0tpWUN3?=
 =?utf-8?B?aHN5VHFKNDl0RWs2Tjg5YmlyR3hJRm1Xa215UkNRcE0rOGZPd1RoV01Gc1Zn?=
 =?utf-8?B?TlJtNllwMzdzb2hXcTZ1MExMMXFUdVZDT1RIb016cmdSM2d0NEYrZElzRXBL?=
 =?utf-8?B?Tk5haEx3NG5JeEM0L2JjelQ2VmVEQ2dRNUFobjEyM0F4MzVVN3NDUkpTT3Ir?=
 =?utf-8?B?M3doaEZBL3Y4ZUJUVjlwMFpTRDZWSE1JekZ4U3RGaEkrb1Y2dEFtU1phbkxR?=
 =?utf-8?B?bm5Kd2swdmN5ZmxRZXNEaW9HQkhETTllbWtBdHJlWWdEYTB4cWZOdE1OcEZC?=
 =?utf-8?B?NExjWkhtRGlDZUdSNENBVDFmeWVBRGZLM0dBaVFQcnFVcnVZRzhiNktkZmN5?=
 =?utf-8?B?WXlLZERncWE0Yyt6VGNMQ3pxVEVNT1dPQlFMOGY4dWFGNlNzR3J5dnV2SnNv?=
 =?utf-8?B?dUFENmRCU3dsUmpXRkltU0VKR1d0L05YLzdWdE5RbEl6VWhYNzNEZWs1V3NY?=
 =?utf-8?B?T0xDV3BzWlcwdFFSMDlnMlFzR0RPejlLSjB1UHMwRndtWnJxN0g2YUZTQ2VN?=
 =?utf-8?B?bEhKbzlrQkxpMi90VExySEdkbXFXWHVDakFOaGpSdVh4TXg3ZHo2dzFOVXl6?=
 =?utf-8?B?Q2dxM0RqcTFPZW5XUXhHOEwrNUxmd0ZDL1lyVFo4cTlnekwwK0VRQytDK2J4?=
 =?utf-8?B?RW1OT0k2bUluUkovV3ZHWFUzSEsvRjBXaHA2TVN5cDQ0MUJ4ZlEyZ0Q0UlhI?=
 =?utf-8?B?Wm1YSTdnU1U0bWVCekxPY1h6aURaNGNjTVU2Q0UxVkZBZ1hyQWkzZ3lTMzN1?=
 =?utf-8?B?TzlEMW5sZ0ZkQUpzekZtQk5Wc2xFekkzdDBrRlRUR01FcmpKMUw2bzNya1Fu?=
 =?utf-8?B?V1NwYUk0YzYydkRaejJMb2tlUjhya2d5MFhOaFpPZ2xTVXQ4SlNFclh3ck1h?=
 =?utf-8?B?eEh0dkpYL25seDdXYmY4N1B5LzFidHVsdzd2K2dSbnhzSVRiSXlOVWtRajdh?=
 =?utf-8?B?VWI2TTVPQ2pKeEhsbDFwajF5SUp1ZlFEUGkrSUFLQjhXeWFSK2I3aWdOWjJH?=
 =?utf-8?B?U2RVVGtHbnZ2Z1VNVG1MV2IzK1pZOVpmbTJsVFIzREsrUkhrdUpvTVQ1UmRk?=
 =?utf-8?B?cWV0amdIbHdacG03UzlBc0JpM2xZVXp4cmRxVXFURWVZUnVPRDVwWDdST3BQ?=
 =?utf-8?B?NGJGT2Jza3RWM3g3U2JzNG9oVGRVbVdIakJyVEU0Y0JGVlMzV1E0WkxmNnlG?=
 =?utf-8?B?dWtvSWRYQVR0NWIySzN0L1RNWWorWWUySXdZbWdDRVYzTWk5ZHdpQWwxK1pJ?=
 =?utf-8?B?ZUpZeFJvUHllMFZuSytOdjVFRm93Q3VmNmdUYlYzSm1Tdy8ybjljRlBUVVFL?=
 =?utf-8?B?TGVFQ1ZGYkdUaUpoeWxhNkl6Q0xWN1BNaVh6UHdjYlE0eEJMR0lIL0Rtc1l4?=
 =?utf-8?B?ZVdocXNja2FtQjQ4c0VKbU5QeEc2T29oRlA2UW5XUGQ2RjV1QStIaWZhNk5M?=
 =?utf-8?B?ODhobUlGb250WVNjaTcxejdJcm9sZ3FNRnFGdGVLbExyQnljN3Nuejl5Uzh2?=
 =?utf-8?B?SnpzOGM5QUNsMVBrRTVMdWQrYzNUeWVtNHkrcWJhUFFndXM3NFlHSkllWFBU?=
 =?utf-8?B?V2RCOEt2NCt3d09zdjh6M0NCRGhMaFNkaVFKdjNZYloxaDNheHVqdmVldUxr?=
 =?utf-8?B?Yi9RSlpWWG9iS01zcFRwTnNKSnBsM1E3RWx0akxGRkJ5bkV6azgwOVZCYmxG?=
 =?utf-8?B?U1p2SEpaZWZidE5aeDJhVkFreWwxNVhyS2MrYjhaMi9lWjZxaXk5aUdDdUZQ?=
 =?utf-8?B?aGZNYXBxZlhjVWhFMzNSWEt4WGhWaEplL3lCdC9HTUcxSUJjekQ2M0NlK21G?=
 =?utf-8?B?ZWk4NGlYTTNaMERpeTBKa2FTeDFWam52TXl1c2xYdU5aNyswMTBnUStzMm5D?=
 =?utf-8?B?WGJnVkE1c29WaHVmOFJ6UXVJb1ltRnV5Nitoc0hIby8veTNVa1BwVGs3WGFX?=
 =?utf-8?B?UG41aUhYVitnbmtIUUEwZHAvZVFDdkUvQ2g4S3Z3R3htT3BSTWZFcmZIaGtG?=
 =?utf-8?B?WVBweFV2YWhPQnVvbG9CMU11aml2eXhKb3hBdlJuQTkyMWgwQkVQZUllQ0or?=
 =?utf-8?B?UEZ4WXJpRVEybmx0QlEyN1UyM21CTU5nUHNtMXNCQ2VmcFRWVnBpb1ZNZlRL?=
 =?utf-8?B?eVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 51144a62-c754-4d0d-892e-08db323f51c1
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 23:26:14.1114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tBenBToiXCHWcA0tWYcWnLfvzpnnJDXZYpQImYqFwHsagF+9OafzYU3R1JJvYrnUysZ57IdueyFp1nUudEe+da63DsdH3J9mVnimB+BFnhA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6426
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 3/20/2023 10:26 AM, James Morse wrote:

...

>  int resctrl_arch_rmid_read(struct rdt_resource *r, struct rdt_domain *d,
>  			   u32 closid, u32 rmid, enum resctrl_event_id eventid,
>  			   u64 *val)
>  {
>  	struct rdt_hw_resource *hw_res = resctrl_to_arch_res(r);
>  	struct rdt_hw_domain *hw_dom = resctrl_to_arch_dom(d);
> +	struct __rmid_read_arg arg;
>  	struct arch_mbm_state *am;
>  	u64 msr_val, chunks;
> -	int ret;
> +	int err;
>  
> -	if (!cpumask_test_cpu(smp_processor_id(), &d->cpu_mask))
> -		return -EINVAL;
> +	arg.rmid = rmid;
> +	arg.eventid = eventid;
>  
> -	ret = __rmid_read(rmid, eventid, &msr_val);
> -	if (ret)
> -		return ret;
> +	err = smp_call_function_any(&d->cpu_mask, smp_call_rmid_read, &arg, true);
> +	if (err)
> +		return err;

This seems to break the assumption of expected return values. __mon_event_count()
does: 
	rr->err = resctrl_arch_rmid_read()

and later rdtgroup_mondata_show() only expects -EIO or -EINVAL as errors, with
default of success.


> +	if (arg.err)
> +		return arg.err;
> +	msr_val = arg.msr_val;
>  


Reinette