Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c429e614-fe97-1c44-287a-9c52438dbeb2@intel.com>
Date:   Fri, 31 Mar 2023 16:29:43 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.1
Subject: Re: [PATCH v3 16/19] x86/resctrl: Add cpu online callback for resctrl
 work
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>
References: <20230320172620.18254-1-james.morse@arm.com>
 <20230320172620.18254-17-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230320172620.18254-17-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2ZSMnhYNEJMdUZaeW5OVGZxaW1LZXJjdTFtYlVYS2gyUjBxbDF1Q1dsNngy?=
 =?utf-8?B?blNOa2o4MlNKYzRERHBjSitobEhsWEJmaVRzVFd1NkhKRy9DNUptUWRPZjBy?=
 =?utf-8?B?a1F0bXFkMnhOQ3NVWnlGRE5kb2o4UTVuSmFIRzVlZXNOVDQrRVMzVlpTSXNG?=
 =?utf-8?B?Zmx1U0RndTE1Nll3cXdlRE1FWmp5UHdRNmZGQllkdVBWcUZBQnZUY2VUMnQ1?=
 =?utf-8?B?VHZQQmFTTVBEallTeTBCNDRzazk0Y0I3TklvL2RZanZIaGprTm80RlpoRVFa?=
 =?utf-8?B?NmU5TktWY3RxcHJMUmU5dXNVUlI1ZUpJS2VJaWFabVpDbFB0cE9VdWVCYU9y?=
 =?utf-8?B?NkhXNnpEcGh4bS90QVRQNldNeUtvNUJ5MXo2cFVRRWUrMUUyNXg1Z3FOR1lr?=
 =?utf-8?B?bEdFYU5UQ095a0xMK2V6VERBRGQrMFBQbTg3Z0hScWswUHU2dndyTDJOUzlv?=
 =?utf-8?B?bjFnaFF1Si94YjN4NXo2bmpnVFZjaHc4VmRQNVRnK09uTWtZNlNDSUlTOVBH?=
 =?utf-8?B?eE01ZVpxL2s4RmFsU1JQclkxTUZaOC9rZEswam1FbW1zbzFzTVFCSEU2aml1?=
 =?utf-8?B?U2JzRUhuRTNNaE9heW9uRTlxMzB4SlZDTVdXaXZIRTdhTm1MVkF0ZGdoS2dW?=
 =?utf-8?B?MTNzcVEyUEltZHQxbzh3N2xjTGRMUVAwVVdCNzNEV2Z6eExOdTdrbE0zMlRr?=
 =?utf-8?B?Q2JsUnUwWXQwRmM5S2RZTVZja2JtV1AxSFZFaUhwcHEyMnFGL0FtV2pTRUd3?=
 =?utf-8?B?bURzSVRhbTAvYmVZOHRoQ240RnlsdTBtZmhSL3Nnb0JTQStwM3VoN2dyMVRy?=
 =?utf-8?B?aUhtRHJUaXZMMzdoMTA0NXRRV3dHUlpkRmNiUS9wdndIQTdoY2dBUFVMSUFC?=
 =?utf-8?B?aVVkd2d0RGZuaHJWSHJiaW9EMk83cmNRenAvcFhNTGZKZ05hUm56c1EyU2Ir?=
 =?utf-8?B?RlExSk1Qb0EyREpXd2gxZmlqc1VFejg0UkRIV1dUVm5hT21IRVV0SWV6UHdt?=
 =?utf-8?B?NXg2Q2o2THVsVmgzRHNYK2RIOEZJZUFmQ2tOQU9PcFF4VFhBam16T3ZKN2dk?=
 =?utf-8?B?Sml6STlmYUxlb1VuY295dlYydDlZUmc0RWwxUVhTQU14Rkg1NE91Z2xPOTBJ?=
 =?utf-8?B?a01kcWtnckFFdEUwVHdValIzSzFrMXlnMG1VQ2JPYzhrWnlqZkw3UHlPczhU?=
 =?utf-8?B?c0pwdDNKcytxdnJsbCtHeVVtMEVvaTBONi9HSGRjbmpzV3h5eG90V244QTV2?=
 =?utf-8?B?RFhwTGhOM3NzV1o0RkFJc2dHcDN1d25CYWwrY2NSTitJNjdKTDVCUTEvY1Ri?=
 =?utf-8?B?NUNqS0t2aTd1ZUtUOGY2YXZYYzF5ZFppVlk1WEZTNkkxd2xTeVhib0tkL2Yr?=
 =?utf-8?B?Q0tzSnd0bzI1RU5IOFVXR0F4Y3hYKzZFY3l5bVZXVVIrNHVlQmhQVWpId3BL?=
 =?utf-8?B?U0VVMS9XakhqMzk3WWxRSS9BTnVaQ3BkQ2xQeUtxaXBnSWNKV2k2dnRueWZL?=
 =?utf-8?B?RjArMHNLTjNnTDRQTFRYQkttelVqU3ZrK3ErT2hnTWp5STI3cThtbWJEbFBR?=
 =?utf-8?B?aW5XNkFCSGVCRDRYNjQ3V284cVBwTjZBbWc0UTAwS1ljT0xjVGdodHhSK3FR?=
 =?utf-8?B?Wmw5T2VCS0FSV1ZNR0t4RU8vM0JUbkhTanVkWWdzTklvbGM1WWVjeDY1bHhR?=
 =?utf-8?B?c3VOV1VyREgzVmIrc3ZJT3dnRHJldnJhSWc4dnZsWnJtQjU1R3lTdDdHWjlY?=
 =?utf-8?B?dTkycG1aaVNjMUhWRVlWc01lR3ZaRE8xeGxlRlIxNmpybmIwcU8vZDZnVlRK?=
 =?utf-8?B?VitXRHl2OW1ha3AzQk4wd0gwcFdEUlVTbUNncnNVNkZIWDlCc1RIU0FQQ3Bx?=
 =?utf-8?B?cC9velJ0Ui95ajMxbUpCVDZSMTNwcHl4b0o1TnJnbDBwclRBNGlmU1ZJNmNR?=
 =?utf-8?B?eDBHOHV4dDJTT1AwcmVSaG52b1U1clRvUTFxUlFuclpvaUxtUXFTRjhWVTJU?=
 =?utf-8?B?TlRVT0lzMzhQRE1RQ3prUDU5UkRBeDNOYVJuZkM1Vnc3enA0eTV6bHNSQ2xF?=
 =?utf-8?B?RVUzZk1CZGI3RDhNYzZwS3NiMWd3V0pLSlY4QTNJb2p3eGZZaXFxSnNCVEd6?=
 =?utf-8?B?MGJuLzBldHpVUFZMOXdvcElwVFlmeER0WXVUZ3VweEtVWUFBS21WUTFXdDJY?=
 =?utf-8?B?MWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d955c61-37b9-4445-7121-08db323fd060
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 23:29:46.8767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BSo8A2zGG9KlZl0q32ELbF8C5HU5kfOy6QaBtTjAM6XZwuL3VBbqYPejGcke6oVrIV7UHxSYrPIdULqs9fT9fsCMzr3EI/A3LKnLP5ZReL4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6426
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 3/20/2023 10:26 AM, James Morse wrote:

...

> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 351319403f84..8e25ea49372e 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -603,19 +603,20 @@ static void clear_closid_rmid(int cpu)
>  	wrmsr(MSR_IA32_PQR_ASSOC, RESCTRL_RESERVED_CLOSID, 0);
>  }
>  
> -static int resctrl_online_cpu(unsigned int cpu)
> +static int resctrl_arch_online_cpu(unsigned int cpu)
>  {
>  	struct rdt_resource *r;
> +	int err;

Could you please rename err to ret? 

Reinette