Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Yu, Fenghua" <fenghua.yu@intel.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Robin Murphy <robin.murphy@arm.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "vkoul@kernel.org" <vkoul@kernel.org>
CC:     Will Deacon <will@kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Zanussi, Tom" <tom.zanussi@intel.com>
Subject: RE: [PATCH v3 7/7] dmaengine/idxd: Re-enable kernel workqueue under
 DMA API
Thread-Topic: [PATCH v3 7/7] dmaengine/idxd: Re-enable kernel workqueue under
 DMA API
Thread-Index: AQHZZCWaCgY3Jdq93USwu66veGT73K8ViPzg
Date:   Fri, 31 Mar 2023 23:31:13 +0000
Message-ID: <IA1PR11MB609783D2D1159E4AA6F6099E9B8F9@IA1PR11MB6097.namprd11.prod.outlook.com>
References: <20230331231137.1947675-1-jacob.jun.pan@linux.intel.com>
 <20230331231137.1947675-8-jacob.jun.pan@linux.intel.com>
In-Reply-To: <20230331231137.1947675-8-jacob.jun.pan@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lq0RjKYu4Fc5QPLEPaCP/hms2EDyNBbuSrusCg4NWs3oykVQ8Rhh/Nmx8KDh?=
 =?us-ascii?Q?6wkLvYrUbd20zQJaJ96yzOZIIVKC2H1t8pMGg3BTV4wb/CzVdLvcalR/rCr6?=
 =?us-ascii?Q?ggKhxryvf5OpLnhjA785E4N6/UmGcskzg7bCh14oEziRcUiDtmmi9+1cJ0/7?=
 =?us-ascii?Q?uT+mABVY6oMBmgnSVTBHP2rI8B9ZDmC8zsp81MAfOiAWHHLBKBijFIbQPL5g?=
 =?us-ascii?Q?t6qLznvED3mTV7h0X7TA7rhbTnRQkmpaxhFGbnJHVSIsQnF0T54QTYp7QFxg?=
 =?us-ascii?Q?aRmee0r2WykOxsk0DcomDo9D8eFD4UJ/m0sJhWI/YSmB8BH6SoA2o4xNniR5?=
 =?us-ascii?Q?c26x4zs/LDgzmxI1Et35+LMbNHvRRg3eheIyuz/mVpVcp1IDcW/UU/PDOwsB?=
 =?us-ascii?Q?HRGvsvIcB+3FQteEhJHwjhzrpZMh0ar8TuxL13yjBk7zYYHJohc4kMKOoXHi?=
 =?us-ascii?Q?YtPf8yUTwRnLVZfKWIG8pq9DBzrOFg7I6Gf8GNXcjjoVjZuaf47ubhBDZEd+?=
 =?us-ascii?Q?WT8UcfjK1RRsNWIB7cTH9P86+ftwa6yobfmQ7uwxUkDNZMMo6BPfQF0XyLZW?=
 =?us-ascii?Q?2XAS6LSDkzDjaGCQ6htw897FhJjXxncCBt/th7KEQCEmiAPB4o184ZOfcY+F?=
 =?us-ascii?Q?wtrlC4h/FpoFc1BBwlH4hGwbXoVaxFQenJiS4AmHlFslBxx0Vz27NO2skZ11?=
 =?us-ascii?Q?raZMNmWR5TLzjqdp9YCRvxo0wmrPW3lCUR5neyVbF2z3D6SmKQwISy4fI4OV?=
 =?us-ascii?Q?8NmtWo7T2TnKGXVK9PJUT0oynHtOuJ4F9o/5SFfpg3mJsb5oqjymeRAfRUnL?=
 =?us-ascii?Q?Xudn+LzYOS1PKWQ1XJYIYbsfZ1MP7UrNzXsLcND58rcuj5o7MBvaQo91W+1z?=
 =?us-ascii?Q?s1RzAS4TnFcXUABA74IZhndITcgIQSvkpjAJ2DmPN9WnllkHW5sVMzdVgdsc?=
 =?us-ascii?Q?6rNnXjV07UTT1Nfi7B5MpfCTD7JsapAlsdMs1LLODkC0guPXKB00Os22L1F/?=
 =?us-ascii?Q?u6FicD+feicycFxwVDJ6jjmKoaM6jnChqIxCLoYne59Lr16J5IYkvW4LVjJu?=
 =?us-ascii?Q?L4BZQHum52kX1ssL0MmYZkVXDx7dQC5BEGcFSNqQUnWC1RVtWfT7zvOm32td?=
 =?us-ascii?Q?boFDNT/V7OLJvHbN3z6i996LIe6TzTla/BnSppSiGGg1VQVu2uw2GxQGzikA?=
 =?us-ascii?Q?KLFi3x74kHQniHFikxbtRLlMI5oIg4eZQljE/BuyPgTv3GRnIeoNAGsuf2Vj?=
 =?us-ascii?Q?y8sM4/WRxYpZjaMc3OdcO415a1g/YfpNEPOiM9d3COndx25GhVspKf9fBbKE?=
 =?us-ascii?Q?SQjTSwFaeiy0HQVQEhDkXyAw3Dh/wLRPnqKYE0HI8YFRegOBV8ldjOVfSUy0?=
 =?us-ascii?Q?L59KAu4xCIJ3m1hghCmRFy/O4zok/RjRy+42HvD76uuB1ltKNXnU8CLrAiit?=
 =?us-ascii?Q?p/vvXTIBgwU8ZWKLODxu24onDg95TWRKC9FkbQQZT+DlSQPLuraohf9fjZ17?=
 =?us-ascii?Q?0chsXwBa9ywQS8GKJlu9v7eh5XUFPuKaIIBjiQha/3uzMbtTNgslEJYlAzse?=
 =?us-ascii?Q?eqhaSltDvTAlIrWZBpT7tXKfBjpRMfoNTKvdsbl9?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 821ce288-63db-4368-5ef6-08db32400427
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2023 23:31:13.1433
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0l7SGDPsfILozzLJrsFjwbJDVZt7GvbWyhANoxZI8KaCZpRCFokltiWUghlzufNFb8uWDt8hhVRzRjaE1X/KYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8199
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Jacob,

> Kernel workqueues were disabled due to flawed use of kernel VA and SVA AP=
I.
> Now That we have the support for attaching PASID to the device's default

s/That/that/

> domain and the ability to reserve global PASIDs from SVA APIs, we can re-=
enable
> the kernel work queues and use them under DMA API.
>=20
> We also use non-privileged access for in-kernel DMA to be consistent with=
 the
> IOMMU settings. Consequently, interrupt for user privilege is enabled for=
 work
> completion IRQs.
>=20
> Link:https://lore.kernel.org/linux-
> iommu/20210511194726.GP1002214@nvidia.com/
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

Other than the typo,

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua