Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Apr 2023 01:54:09 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Alistair <alistair@alistair23.me>
Cc:     Linus Walleij <linus.walleij@linaro.org>, ye.xingchen@zte.com.cn,
        pali@kernel.org, sravanhome@gmail.com, linux-pm@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: power_supply_show_property Kernel Oops
Message-ID: <20230331235409.tub5oxes4cse7wne@mercury.elektranox.org>
References: <0dcc1aac-9a6a-4d17-be68-a895cb6120da@app.fastmail.com>
 <CACRpkdZSJCZZEkD0V_wint+a1XKsbCQFuArFvPdFP8RSDsGLMQ@mail.gmail.com>
 <20230329224736.qzidpkzkdth2lvuq@mercury.elektranox.org>
 <3cd2ef19-f902-4493-ad90-00c410aca176@app.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2o6gmr26ich5y7ua"
Content-Disposition: inline
In-Reply-To: <3cd2ef19-f902-4493-ad90-00c410aca176@app.fastmail.com>
Precedence: bulk


--2o6gmr26ich5y7ua
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Mar 30, 2023 at 06:00:41PM +1000, Alistair wrote:
> > I did not look deeply, but it's at least missing an update to
> > power_supply_attrs. I guess you were 'lucky' that it did not crash
> > with v6.2.
>=20
> Do you mind pointing to an example that does this correctly? I don't see
> anything obviously wrong compared to the in-tree max* drivers.
>=20
> Anything to help point me in the right direction would be greatly
> appreciated :)

I am talking about the extra additions to the core, that have been
done incorrectly. You cannot see that in other max* drivers. The
additions to the core basically break the core and thus the drivers
are broken.

> > None of the extra properties are acceptable upstream btw.:
> >=20
> > POWER_SUPPLY_PROP_CURRENT_MAX2:
> >     The driver seems to use CURRENT_MAX2 for input current;
> >     POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT should be used for that
> >=20
> > POWER_SUPPLY_PROP_CHARGER_MODE:
> >     OTG should be handled via a regulator
> >=20
> > POWER_SUPPLY_PROP_STATUS_EX:
> >     Use extcon for connectors
>=20
> Thanks! I figured as much. These are just taken from the vendor
> tree, I need to clean everything up for upstreaming. I just wanted
> to have a working base point to start.

That did not turn out that well so far... :)

-- Sebastian

--2o6gmr26ich5y7ua
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQncp4ACgkQ2O7X88g7
+pqSNA/+OhSIKjmO8LExFGPc60OFNOZwKDQG909gAZQd8JFTJgT4a9S5T5ocsVP3
kCxPx45nrfRXCCxxqQWN4BM/qqLZZb13uuxs3lSjU+q5ha7lhD10Bk7s5sm54vOa
xNUKJwI+Eq1lXB12MNGHsSc7wPQPGLkqC927NLptGq/oERbQiPgia5oSu9zYgGpr
2FbWbnxThcWPbC2wxZzwpD2N7HmyhEm+kevZyv42Qxbx7K0YCXyiqY0eEbhP/ICt
xSrhPjabTpOC5Xix5dNlnI9iqAimB35YvF7/fx4ZM37MmS1wdMCf7vTfSRy/f7qv
qMGQiJbNx2mVlNDTCljh/OniMceutcZdeoXm4T5UDFbNK4anJc1HUmKPyRQTeFd3
7+xdFPOT3UjTudcCgOwYf+dRR+gD44GHC8IocsO52QfaMv/2Gbm4sIXEOKgDbjnV
ORLgA5sDjjvhDlJFOBfQr69Xmp5IwgxBHnesg+NBikVdD0fsDJ5PdcBrUqlRLXje
2BXpQsSKD41j6ZYVWWcVujoubr0YYbn8RxY6wi5hKCRJw8QzpPf5TbRsv2/yilfy
SeJPof6zMZ2dwNG0n+l6eqbeKUp2ycyS1bjWk4XslnBWHfc6ntsld2kcfsO++phN
+lJrQxhv4u8ctt03xwgkvUbxoMUqggbQj70hLPQhDMYAvaAELpc=
=rmUF
-----END PGP SIGNATURE-----

--2o6gmr26ich5y7ua--