Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 31 Mar 2023 17:03:17 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Nadav Amit <nadav.amit@gmail.com>
Subject: Re: [PATCH 11/29] selftests/mm: Drop test_uffdio_zeropage_eexist
Message-ID: <20230401000317.GF12460@monkey>
References: <20230330155707.3106228-1-peterx@redhat.com>
 <20230330160717.3107010-1-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230330160717.3107010-1-peterx@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?anQOlNvc6aQwFPbMpsCTmROpCRcL/DqwXx/r8Cb7HhrWPQbO7oZSRHc5w3Jn?=
 =?us-ascii?Q?hALYAL5HWTS4UuIMcd/OvtqED7PYLLzKvSFfA2d82nCJDsbI2KNXBZ9gCENF?=
 =?us-ascii?Q?qNf8htPRES5QpYaYQ053Re4LWU3Mcewc6vIGrTtnNJy/6tV+Uq1qjW7QAWBr?=
 =?us-ascii?Q?iJviwbnxL11d98NxR5GQruy/eS5zgGINYpS3K7OaMbvQU51skdzgp0y4JyzG?=
 =?us-ascii?Q?Jp/vOk+dKeZ3adg5OYGs2kgSfujTzNcv0kQRy0uk4lXeNHvI44h2O1GtOVPS?=
 =?us-ascii?Q?2xxCiZz7HgqCbYj+xLR0CO2yBqOgiiR3wGb5qAL6zKt3f5T7lezzPpa0dmlc?=
 =?us-ascii?Q?e2yVpTeZFyCm97Zdm4dykNuawdyonK6RPkDaGb46fHvx4jAgpv8nKVNL+7q9?=
 =?us-ascii?Q?pf0oMKCeHpe7ZK9HMcmwcVrX/n4PlVTHkRtSubFokE+uUnGFJrQ2BiSvlAnT?=
 =?us-ascii?Q?G0NLpCfSA1hEVf2EmPWILwFQ3r3YbLB6c/2L4frb1nmZcukIYOb1UUfEMZmr?=
 =?us-ascii?Q?cquCEVNukuHx5fc0zyT0JpMYOzX0ql04AbMTKEiwtvh6EhIzMqYQtGSDHAzC?=
 =?us-ascii?Q?u51z3o8ZFgJ1LMUk4TEevQYUOuARRbYQJGm/ovA+hXZ29rIN6Vwa4Rqcrgw2?=
 =?us-ascii?Q?O0uuyGYXivO/MBG+KY7vmu2H3BpSvZpJ3YB7EojZFhqPDiZvuxMgToMfpGQT?=
 =?us-ascii?Q?rjlJnofuCbv5HzUEMNLDZ4D5ZUo5bMTz/dcSwLLc2yEN/PUfhb+4VhNmZlhj?=
 =?us-ascii?Q?QBGrhbJbF4zOI4UXxkHOWGeIr4rt5X1wHfDD3xFtEyRPnckq4A5XSyE8CPTU?=
 =?us-ascii?Q?+I5JDMpqRHyryRArEMTrXM9k0GQ05xO+R4wc7TPJF6Qcjbjsn4GDeXkIPgqX?=
 =?us-ascii?Q?WRk+oARsMGCXaZ4ZcjCUDxzOF6rtIPaWEU6qN/ZpobdPvzm1bHrDFRGHzwOR?=
 =?us-ascii?Q?nFHASej5VPG6b2iSNqifr9+z3zputLVlX4WHt6WE1QCZIs6lNbcyhjz0R2St?=
 =?us-ascii?Q?0cEPolPQ3vsYcq7tIj9yZ6l2XVG7QWol6+xQ5rG4/sGdSzEGbwQUopbE4So9?=
 =?us-ascii?Q?0vrqjWpyiqt5DTtEI7GWMoAaeG5nthfYdT5FEyVwHPVCDz6+sMXIDgrsoRkG?=
 =?us-ascii?Q?PNyrhOs75/codA21WZ33QX0ROe9Z6WWJ4JG/TYklZG8RtUNdUDc7Ux+ALY8N?=
 =?us-ascii?Q?kwNu4iF3vjti4WJwKyLasbet7QG5ZWJIoYBwjh4YG8TXFLZizR7T9f8O1+w1?=
 =?us-ascii?Q?giBZ8rS6aVajywYs54qwtIks/tsgNeOM107H/aqeMA5gwh3bajIJksnifExV?=
 =?us-ascii?Q?aUHqSUvjxnIujPb/mt148O7JGyS8cZm06L1CmRzIkbiWIeWidxIdhxl8RdTi?=
 =?us-ascii?Q?Vr4UaSiFOpqKVNuELftEOV7A6Da69wAP0WxB9RLV/s0xufDHuEO9jTk1ibVu?=
 =?us-ascii?Q?mAw1aJnjFrW7D/6sg85jcpifXxZqaZj+kMlKLuLX420z9hrQmcJocEdMQYRP?=
 =?us-ascii?Q?UdG78fi/Wk1YZOkUD8/WUNWvhpJPwHioaTnhxL7v9MKNZfmCsFzovD+iaYRL?=
 =?us-ascii?Q?LjZTnGHrSRn42UTYEceWlCt6pBck2ZSErHh0CI1wQM/TvhEt19Vtd81cRImq?=
 =?us-ascii?Q?uA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?mk7jxgx7r9oNzoGw7pj5QdB9rcMuS15fU/MV3tcjx7rwNOBNMNsoKAUaEs62?=
 =?us-ascii?Q?aoRgQblAhWCVtRbu34DujmO6sWCLlsHcIWx9CpBAcNrYC1AipkVgwtHEsJEW?=
 =?us-ascii?Q?TVom4qyueUDnh8skD3q3k26l1UEqsQyFt+TXVSk5+GzGHSU/yRltUo3KfPkz?=
 =?us-ascii?Q?aMMIrdFAcZ0IHqqkftjouyAu2EHy/Veye/+oy68mcgPNjqDoVvNUdG9PHmGw?=
 =?us-ascii?Q?ZdKygFjn7GmqhJQBdylYRvsoiF5MbBkHOQKJHHdzPOOCudNVe2miv3aVquZJ?=
 =?us-ascii?Q?dI10EDspSzYON/XKKSfYIZWfVwRyIcXD4d1Q1Jgg8Uk7wGS4r1N4VKgQYUXC?=
 =?us-ascii?Q?J2IZjrVT73WZgN+hCHSENDvlWefXTZyxIn1Srs4cTchOWnVsVLT8eVDeMmFQ?=
 =?us-ascii?Q?VQkUXdG1qHXwBUGyuQ685Eeip5c96l1h2wlaczo03LBbCZa5z+EdXT+G3BNj?=
 =?us-ascii?Q?beKoY7g9WlmyCFb08jfwfKqd/a39pIW/I8eALGZ+E4IKva46uLoP+cwQu5gI?=
 =?us-ascii?Q?Ki6vvvGM2IJ/DLRD8NQ+BeFqOkbT8oKoi/mSo1XUaU4PTbH2pAwcnzpGvUL/?=
 =?us-ascii?Q?bGtPR20ENdZJgfs0eHeubJ4W9wvw0xqG9+Li/P5GWV1oGhxSqDS8+9fo495w?=
 =?us-ascii?Q?AMKDtPnJvcmKZUNuU+DDR/Q/0vOAB9On/l3Jc4DLMG8OzXxAIZr90ZoAJ/br?=
 =?us-ascii?Q?uXRCkkQ3mVgbqwIcOiEU+ErMBfc8TzsTkEEBSDU+QTvlomffNCa1bqG6g7M+?=
 =?us-ascii?Q?vwtGD1GyCSL/ochP5TK/FzjxeFaRT2yYTA0yeZ7X/MBFABPXpXeoCeKt3tYO?=
 =?us-ascii?Q?aW4+BwgH6cNQr/WWBgbBiIoQz6eeXp5C5p/BDapnKf4Oci9KERX9wrsR1KT2?=
 =?us-ascii?Q?bIkycs0VId1QTGbejuWkma0OWUXUF8VJLN1WcDW8SkDbjZjN3nzASxtRUhM1?=
 =?us-ascii?Q?KQjRSPL72BT21iulSsp+5KGfU+Mlnkj5J6+mPq54bBY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27d18ae3-ee20-407c-a856-08db32448110
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2023 00:03:20.9612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f+HG+0Z1qVnTuksvNXhRj/nfXuxCe9rx8S2EpD8bS++Calr7/yodAnBTGCymiCudV6l7/g3hmoaB5nznNJ6EwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6021
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-31_07,2023-03-31_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 spamscore=0
 phishscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2303310197
X-Proofpoint-GUID: RjlmMFc_09-MiageWtfHXFTU66pOpRoR
X-Proofpoint-ORIG-GUID: RjlmMFc_09-MiageWtfHXFTU66pOpRoR
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/30/23 12:07, Peter Xu wrote:
> The idea was trying to flip this var in the alarm handler from time to time
> to test -EEXIST of UFFDIO_ZEROPAGE, but firstly it's only used in the
> zeropage test so probably only used once, meanwhile we passed
> "retry==false" so it'll never got tested anyway.
> 
> Drop both sides so we always test UFFDIO_ZEROPAGE retries if has_zeropage
> is set (!hugetlb).
> 
> One more thing to do is doing UFFDIO_REGISTER for the alias buffer too,
> because otherwise the test won't even pass!  We were just lucky that this
> test never really got ran at all.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  tools/testing/selftests/mm/userfaultfd.c | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)

Thanks!  With only passing "retry==false", that code is indeed dead.  I had
to read the code again to understand area_dst_alias.  Thanks for taking this
on as the code is difficult to understand.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz