Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1888303rwl; Fri, 31 Mar 2023 19:55:16 -0700 (PDT) X-Google-Smtp-Source: AKy350Yom2v+QWLKnsLkJkUdEMHmieBr9aJa9FT3gJqPNvzeLWUN2lfhubt3RS2MDHFsxWSXYNzW X-Received: by 2002:a17:906:7390:b0:947:8734:a058 with SMTP id f16-20020a170906739000b009478734a058mr5288524ejl.4.1680317716718; Fri, 31 Mar 2023 19:55:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680317716; cv=none; d=google.com; s=arc-20160816; b=sXtEh7TpVim7oDH3+eW5oL1FmR1goXMFIcfucnY5gr/vd8KGtpBm3ivoCAa8bCPHNy kWck6ZK1V7wSqLQvajsqR721QnPNxKaHkoAUk1oRhHXSV1h4rcj5RvCecI8tnHHjEDIr +UM0ju4GqeFvO0B7Or0nXHWsnHx3lzCMSrIjF6kkkupaXB5Ba0cIAQtyOEJSss7KYH+Q l/2549dNGNguVQjkCBwrVcYeyJ9UwTnhuF3w0QMIxnboicqtDRHXlp0bi7R7TE6MUCtL KF4rP7pk8YL7O07J+kONj7vsBi7vFgbpOjyN5RLxn4PRnaX/Nnxmm4cBNap7MqUwcRHS 3sGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=rmcXAI4T61XuisoJQTRdqhGr0sWB57soA9olnyA6J5s=; b=bePzjQiC5L6MV5mPk9jVN4gYHkdq9vHt54gHakIBqmXNPhdoVixukKYAJBs73cx76f u1I3TIr/A9yyOhLmZkbJXiaTPvoND6N9zwbpjuRHNWvyyR1rx7lNlZ4Fi7PH/S8zsQWC PzAyhg/cPn9BFGDz9EMvrcZT8Wmp8vDeAjoDmwVcdpFYmmtVMog1NOaf94Hth05Z9Ls3 qAtA/UF+1OgC7ZY8tvN1dcJ4AT8xN4fZV2Yt2dugUZQRGErfzGGWKomSV5MpWikIvODm bcJlQS5y6hb75nEN1oIJnG2cMuse65ZJUr/pJfVt+jfXmMi5VBB8QNwX/5GULWMBRBZ3 ryvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DVrhdT8g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a22-20020a170906671600b0092cf65c1a30si2798308ejp.814.2023.03.31.19.54.52; Fri, 31 Mar 2023 19:55:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DVrhdT8g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233791AbjDACPu (ORCPT + 99 others); Fri, 31 Mar 2023 22:15:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233738AbjDACPt (ORCPT ); Fri, 31 Mar 2023 22:15:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32AFF12049; Fri, 31 Mar 2023 19:15:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B812B62D63; Sat, 1 Apr 2023 02:15:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 259FAC433A1; Sat, 1 Apr 2023 02:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680315346; bh=FXua526i85PRorKEsrWCzuQNWGXkTMXjZIj2FQTkD3U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DVrhdT8gxsqP43tJ9qjz+euqr0tdZjtpaNdJrd4h4RDRBWkhx7zOEd+h6fhmnn6L8 PhJ5GQ4oIOuLIajX/MPv+9zNLZYYiz91vqKnC6N2yA9SNoSZy4j9/j906cTWJ9SLwb Vazw1TdKPR3ttl9mmTkhMq1lNtVseq7wFOiTnEtWcrYlTWQnmLu+rGtZV1u2QcM5uU +OlM2IHe4H8vcscGOkSpUMTEYB/P0EWTRYOigCv9rR8g+1ita26UfbOIcDBN05tC3G 4nbvFLjtZQWvagZ400gPCgKiQCZtzFGC+NEKxzE4reWW93a6CBSk8MrAICxw5Gh5Xw zsfLbPr51h9pA== Received: by mail-ed1-f52.google.com with SMTP id h8so96778871ede.8; Fri, 31 Mar 2023 19:15:46 -0700 (PDT) X-Gm-Message-State: AAQBX9cdy65uvSbDy1EyhLxdUkoR+DtW2sa7vJol0vx6DEbefwiH1Yeq qlwHWyN0FSVxXCrtMKqKmOxKNmU6IGD/5aGgwpo= X-Received: by 2002:a17:906:a146:b0:931:fb3c:f88d with SMTP id bu6-20020a170906a14600b00931fb3cf88dmr14532529ejb.5.1680315344177; Fri, 31 Mar 2023 19:15:44 -0700 (PDT) MIME-Version: 1.0 References: <20230222033021.983168-1-guoren@kernel.org> <60ee7c26-1a70-427d-beaf-92e2989fc479@spud> <23668656.ouqheUzb2q@diego> In-Reply-To: <23668656.ouqheUzb2q@diego> From: Guo Ren Date: Fri, 31 Mar 2023 22:15:32 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next V17 4/7] riscv: entry: Convert to generic entry To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Conor Dooley , arnd@arndb.de, palmer@rivosinc.com, tglx@linutronix.de, peterz@infradead.org, luto@kernel.org, conor.dooley@microchip.com, jszhang@kernel.org, lazyparser@gmail.com, falcon@tinylab.org, chenhuacai@kernel.org, apatel@ventanamicro.com, atishp@atishpatra.org, mark.rutland@arm.com, ben@decadent.org.uk, bjorn@kernel.org, palmer@dabbelt.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Guo Ren , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Yipeng Zou Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 31, 2023 at 2:47=E2=80=AFPM Heiko St=C3=BCbner wrote: > > Hi, > > Am Freitag, 31. M=C3=A4rz 2023, 20:41:35 CEST schrieb Conor Dooley: > > On Fri, Mar 31, 2023 at 07:34:38PM +0100, Conor Dooley wrote: > > > On Tue, Feb 21, 2023 at 10:30:18PM -0500, guoren@kernel.org wrote: > > > > From: Guo Ren > > > > > > > > This patch converts riscv to use the generic entry infrastructure f= rom > > > > kernel/entry/*. The generic entry makes maintainers' work easier an= d > > > > codes more elegant. Here are the changes: > > > > > > > > - More clear entry.S with handle_exception and ret_from_exception > > > > - Get rid of complex custom signal implementation > > > > - Move syscall procedure from assembly to C, which is much more > > > > readable. > > > > - Connect ret_from_fork & ret_from_kernel_thread to generic entry. > > > > - Wrap with irqentry_enter/exit and syscall_enter/exit_from_user_m= ode > > > > - Use the standard preemption code instead of custom > > > > > > This has unfortunately broken booting my usual NFS rootfs on both my = D1 > > > and Icicle. It's one of the Fedora images from David, I think this on= e: > > > http://fedora.riscv.rocks/kojifiles/work/tasks/3933/1313933/ > > > > > > It gets pretty far into things, it's once systemd is operational that > > > things go pear shaped: > > > > Shoulda said, can share the full logs if required of course, but they'r= e > > quite verbose cos systemd etc. > > I was just investigating the same thing just now. So that saves me some > tracking down the culprit :-) . > > My main qemu is living as a "board" in my boardfarm (also doing nfsroot) > as well as my d1 nezha with nfsroot was affected. Can you reproduce it with qemu? Could give me some tips and let me reproduce it on qemu? > > Though my board is stuck in some failure loop with both the journal- as > well as the timesyncd service failing again and again. And I haven't > figured out how to get logs without a working login console yet. > > > Heiko > > > > > > > > > > [ OK ] Mounted Huge Pages File System. > > > [ 70.297439] systemd[1]: Mounted POSIX Message Queue File System. > > > [ OK ] Mounted POSIX Message Queue File System. > > > [ 70.453489] systemd[1]: Mounted Kernel Debug File System. > > > [ OK ] Mounted Kernel Debug File System. > > > [ 70.516331] systemd[1]: Mounted Kernel Trace File System. > > > [ OK ] Mounted Kernel Trace File System. > > > [ 70.679253] systemd[1]: modprobe@configfs.service: Succeeded. > > > [ 70.788400] systemd[1]: Finished Load Kernel Module configfs. > > > [ OK ] Finished Load Kernel Module configfs. > > > [ 71.501222] systemd[1]: modprobe@drm.service: Succeeded. > > > [ 71.573295] systemd[1]: Finished Load Kernel Module drm. > > > [ OK ] Finished Load Kernel Module drm. > > > [ 71.825934] systemd[1]: modprobe@fuse.service: Succeeded. > > > [ 71.886945] systemd[1]: Finished Load Kernel Module fuse. > > > [ OK ] Finished Load Kernel Module fuse. > > > [ 71.991932] systemd[1]: nfs-convert.service: Succeeded. > > > [ 72.034674] systemd[1]: Finished Preprocess NFS configuration conv= ertion. > > > [ OK ] Finished Preprocess NFS configuration convertion. > > > [ 72.148778] systemd[1]: systemd-modules-load.service: Main process= exited, code=3Dexited, status=3D1/FAILURE > > > [ 72.256659] systemd[1]: systemd-modules-load.service: Failed with = result 'exit-code'. > > > [ 72.337818] systemd[1]: Failed to start Load Kernel Modules. > > > [FAILED] Failed to start Load Kernel Modules. > > > See 'systemctl status systemd-modules-load.service' for details. > > > [ 72.410491] systemd[1]: systemd-modules-load.service: Consumed 1.4= 63s CPU time. > > > [ 72.496739] systemd[1]: Condition check resulted in FUSE Control F= ile System being skipped. > > > [ 72.513689] systemd[1]: Condition check resulted in Kernel Configu= ration File System being skipped. > > > [ 72.682549] systemd[1]: Starting Apply Kernel Variables.. > > > [ OK ] Finished Apply Kernel Variables. > > > [ 76.314434] systemd[1]: Finished Load/Save Random Seed. > > > [ OK ] Finished Load/Save Random Seed. > > > [*** ] (1 of 6) A start job is running for=E2=80=A6p Virtual Consol= e (14s / no limit) > > > [ OK ] Finished Create Static Device Nodes in /dev. > > > [ 79.787065] systemd[1]: Started Entropy Daemon based on the HAVEGE= algorithm. > > > [ OK ] Started Entropy Daemon based on the HAVEGE algorithm. > > > [ 80.186295] systemd[1]: Starting Journal Service... > > > Starting Journal Service... > > > [ 80.713508] systemd[1]: Starting Rule-based Manager for Device Eve= nts and Files... > > > Starting Rule-based Manage=E2=80=A6for Device Events and Fil= es... > > > [ *** ] (2 of 7) A start job is running for=E2=80=A6 All udev Device= s (17s / no limit) > > > [ 82.939347] systemd[1]: systemd-journald.service: Main process exi= ted, code=3Dexited, status=3D1/FAILURE > > > [ 83.032046] systemd[1]: systemd-journald.service: Failed with resu= lt 'exit-code'. > > > [FAILED] Failed to start Journal Service. > > > See 'systemctl status systemd-journald.service' for details. > > > [ 83.210041] systemd[1]: Dependency failed for Flush Journal to Per= sistent Storage. > > > [DEPEND] Dependency failed for Flus=E2=80=A6Journal to Persistent Sto= rage. > > > [ 83.254122] systemd[1]: systemd-journal-flush.service: Job systemd= -journal-flush.service/start failed with result 'dependency'. > > > [ 83.272366] systemd[1]: systemd-journald.service: Consumed 1.443s = CPU time. > > > [ 83.334360] systemd[1]: systemd-journald.service: Scheduled restar= t job, restart counter is at 1. > > > [ 83.427839] systemd[1]: Finished Setup Virtual Console. > > > [ OK ] Finished Setup Virtual Console. > > > [ 83.510650] systemd[1]: Stopped Journal Service. > > > [ OK ] Stopped Journal Service. > > > [ 83.554417] systemd[1]: systemd-journald.service: Consumed 1.443s = CPU time. > > > [ 83.576573] systemd[1]: Condition check resulted in Journal Audit = Socket being skipped. > > > [ 83.904878] systemd[1]: Starting Journal Service... > > > Starting Journal Service... > > > [ 85.752090] systemd[1]: systemd-journald.service: Main process exi= ted, code=3Dexited, status=3D1/FAILURE > > > [ 85.826421] systemd[1]: systemd-journald.service: Failed with resu= lt 'exit-code'. > > > [ 85.876165] systemd[1]: Failed to start Journal Service. > > > [FAILED] Failed to start Journal Service. > > > See 'systemctl status systemd-journald.service' for details. > > > [ 85.952221] systemd[1]: systemd-journald.service: Consumed 1.355s = CPU time. > > > [ 86.002092] systemd[1]: systemd-journald.service: Scheduled restar= t job, restart counter is at 2. > > > [ 86.015081] systemd[1]: Stopped Journal Service. > > > [ OK ] Stopped Journal Service. > > > [ 86.076429] systemd[1]: systemd-journald.service: Consumed 1.355s = CPU time. > > > [ 86.089700] systemd[1]: Condition check resulted in Journal Audit = Socket being skipped. > > > [ 86.390162] systemd[1]: Starting Journal Service... > > > Starting Journal Service... > > > [ 87.904427] systemd[1]: systemd-journald.service: Main process exi= ted, code=3Dexited, status=3D1/FAILURE > > > [ 87.950259] systemd[1]: systemd-journald.service: Failed with resu= lt 'exit-code'. > > > [ 88.000661] systemd[1]: Failed to start Journal Service. > > > [FAILED] Failed to start Journal Service. > > > See 'systemctl status systemd-journald.service' for details. > > > [ 88.079953] systemd[1]: systemd-journald.service: Consumed 1.316s = CPU time. > > > [ 88.128956] systemd[1]: systemd-journald.service: Scheduled restar= t job, restart counter is at 3. > > > [ 88.145365] systemd[1]: Stopped Journal Service. > > > [ OK ] Stopped Journal Service. > > > [ 88.189975] systemd[1]: systemd-journald.service: Consumed 1.316s = CPU time. > > > [ 88.205799] systemd[1]: Condition check resulted in Journal Audit = Socket being skipped. > > > [ 88.514817] systemd[1]: Starting Journal Service... > > > Starting Journal Service... > > > > > > (Note, you need to merge -rc2 into riscv/for-next to actually boot) > > > > > > Cheers, > > > Conor. > > > > > > > > > > --=20 Best Regards Guo Ren