Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 01 Apr 2023 07:44:32 +0000
To:     Boqun Feng <boqun.feng@gmail.com>
From:   Benno Lossin <y86-dev@protonmail.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Gary Guo <gary@garyguo.net>,
        =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Alice Ryhl <alice@ryhl.io>, rust-for-linux@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Alice Ryhl <aliceryhl@google.com>
Subject: Re: [PATCH v4 08/15] rust: init/sync: add `InPlaceInit` trait to pin-initialize smart pointers
Message-ID: <90c7c075-255e-33ef-527e-32be5e9a6fc3@protonmail.com>
In-Reply-To: <ZCdh8fwSGTjDW6vE@boqun-archlinux>
References: <20230331215053.585759-9-y86-dev@protonmail.com> <ZCdh8fwSGTjDW6vE@boqun-archlinux>
Feedback-ID: 40624463:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 01.04.23 00:42, Boqun Feng wrote:
> On Fri, Mar 31, 2023 at 09:53:25PM +0000, y86-dev@protonmail.com wrote:
> [...]
>> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
>> index eee7008e5e3e..24dc96603090 100644
>> --- a/rust/kernel/sync/arc.rs
>> +++ b/rust/kernel/sync/arc.rs
>> @@ -17,6 +17,7 @@
>>
>>   use crate::{
>>       bindings,
>> +    init::{InPlaceInit, Init, PinInit},
>>       types::{ForeignOwnable, Opaque},
>>   };
>>   use alloc::boxed::Box;
>> @@ -163,6 +164,28 @@ impl<T> Arc<T> {
>>           // `Arc` object.
>>           Ok(unsafe { Self::from_inner(Box::leak(inner).into()) })
>>       }
>> +
>> +    /// Use the given initializer to in-place initialize a `T`.
>> +    ///
>> +    /// If `T: !Unpin` it will not be able to move afterwards.
>> +    #[inline]
>> +    pub fn pin_init<E>(init: impl PinInit<T, E>) -> Result<Self>
>
> `Result` became `core::result::Result` after patch #3, so you will need
> to refer to `crate::error::Result` here. Alternatively you can change
> patch #3 to use the full path i.e. `core::result::Result`.
>
>> +    where
>> +        Error: From<E>,
>
> In my env, looks like the compiler doesn't know which `Error` it
> is after removing use of `crate::error::Result` in patch #3, you
> probably need to deal with this as well.
>
> Regards,
> Boqun
>
>> +    {
>> +        UniqueArc::pin_init(init).map(|u| u.into())
>> +    }
>> +
>> +    /// Use the given initializer to in-place initialize a `T`.
>> +    ///
>> +    /// This is equivalent to [`pin_init`], since an [`Arc`] is always =
pinned.
>> +    #[inline]
>> +    pub fn init<E>(init: impl Init<T, E>) -> Result<Self>
>> +    where
>> +        Error: From<E>,
>> +    {
>> +        UniqueArc::init(init).map(|u| u.into())
>> +    }
>>   }
>>
>>   impl<T: ?Sized> Arc<T> {
>> --
>> 2.39.2
>>
>>

Sorry, forgot to compile check that.
--
Cheers,
Benno