Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Apr 2023 12:59:24 +0300
From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     Joe Lawrence <joe.lawrence@redhat.com>
Cc:     live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kbuild@vger.kernel.org, Josh Poimboeuf <jpoimboe@kernel.org>,
        Miroslav Benes <mbenes@suse.cz>,
        Petr Mladek <pmladek@suse.com>,
        Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: Re: [PATCH v7 00/10] livepatch: klp-convert tool
Message-ID: <0d28af49-ff04-417c-9047-fc2c796a5040@p183>
References: <4ce29654-4e1e-4680-9c25-715823ff5e02@p183>
 <683593a8-79db-4f3b-bc78-7917284683e4@p183>
 <f1351c5f-16aa-8407-753c-90049956123d@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f1351c5f-16aa-8407-753c-90049956123d@redhat.com>
Precedence: bulk

On Fri, Mar 31, 2023 at 12:03:52PM -0400, Joe Lawrence wrote:
> On 3/30/23 13:04, Alexey Dobriyan wrote:
> > This patchset somehow breaks the build of the simplest livepatch module:
> > 
> > 	make -f linux/linux-1/scripts/Makefile.modfinal
> > 	make[1]: *** No rule to make target 'linux/module-klp/main.tmp.ko', needed by 'linux/module-klp/main.ko'.  Stop.
> > 
> 
> Thanks for testing.
> 
> Presumably this is an out-of-tree livepatch module?  If so, that is
> still on the TODO list.  If not, that is weird as the patchset itself
> includes updates to samples/ and lib/ livepatches that build and load fine.

Yes, this is external module.

make doesn't see this implicit rule despite it is hiding in the open:

	+%.tmp.ko: %.o %.mod.o symbols.klp FORCE
	+	+$(call if_changed,ld_ko_o)