Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2208314rwl; Sat, 1 Apr 2023 04:00:28 -0700 (PDT) X-Google-Smtp-Source: AKy350buyKE+29PoBFOF37BxXLzOjAwDsjh0IZ20WrTgITeDztavjNF+IgHawwnyaz96Z1mJBCv6 X-Received: by 2002:a17:906:b303:b0:933:48ce:73a5 with SMTP id n3-20020a170906b30300b0093348ce73a5mr27880382ejz.56.1680346827859; Sat, 01 Apr 2023 04:00:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680346827; cv=none; d=google.com; s=arc-20160816; b=EvX12+XiSLHu8nx4WGEdaDcbVBoMyautWysk/xVUAtjtk7pJ/TlyANR1RHJ+S+MjTZ F/rE1QpFp8lrTMPCHwVc1AQbpCT0kw8AF/o8D0El/UNn/nKkowCcV5glgGI+acL5huxb d25SE+z/gOhqVEmXCYYwb+X/PaTZOtNR3ckcfakV7hoPraNP3Snk7YdXVuSaHLvyVZK7 m3soZ+Z70Wbh5r4GNr0K7a9kZcrfqN1xOiwoHhlkd+BVssfbxZuJVG5Z8CUJAO/eEZPc CkxQyBLnxen9x6gQzjW4xRvAJRndGKfGKQjF7/ZzRqEsvjPEUgml38HWaUv/Lpw7cbTR sLDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=iyZoPySXOOxOaO748N2MsJyH964xIOQPpVIusQutvT4=; b=ygEswXVzxBsOSbvKfiYtuECPobGyK/cnO6/hTzOtjoySwgBGaVNeXVWjr24ftbIKq5 7uy/tqoKIocaauAf7hfjQiJn1BAdXDyclDKlaupABrVA8j/ukMWYDth19jOavqEcEHkP +VrjY6nsim9M7wJVkPCiZA8uWcwtuwz9cDvnrIkglvIN0UyCpN+cmKB6flN/g4R6+yHT SqnTqUzmoSlEHL+BBjedPEk2R9oMZq2UJdbS7eYH7jMo/4SLQVVT6WgGKV8Fn0DpHGEg wmdjEc6e3yshS/DXp32E/EO8SDJHR6Gy0yXTxgKqulF9SEs2jQZtmBaDdRa6uGczQXJO E2LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=OFI90b0a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z17-20020a170906945100b008dc76bf3a69si2352614ejx.735.2023.04.01.03.59.59; Sat, 01 Apr 2023 04:00:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=OFI90b0a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229560AbjDAKrv (ORCPT + 99 others); Sat, 1 Apr 2023 06:47:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjDAKrt (ORCPT ); Sat, 1 Apr 2023 06:47:49 -0400 Received: from mx4.wp.pl (mx4.wp.pl [212.77.101.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 590BFDBC8 for ; Sat, 1 Apr 2023 03:47:46 -0700 (PDT) Received: (wp-smtpd smtp.wp.pl 8697 invoked from network); 1 Apr 2023 12:47:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1680346059; bh=iyZoPySXOOxOaO748N2MsJyH964xIOQPpVIusQutvT4=; h=From:To:Cc:Subject; b=OFI90b0aVTbz/MtTgf1vdbCWxoaJIG/4Rd4Dg9i0yAoW+7bbtcEjZ4k11uyBLFyZF HQHDxcD2V6XLJxEkfHcAVAv7Q1RaUrbdkxNZqUpddQO1hNpTLhTXNYQkoY5yqvl3g5 d+dwkjSLOiwzF6kIBmoZrXsVOINJeuyw8cClonEY= Received: from 89-64-1-145.dynamic.chello.pl (HELO localhost) (stf_xl@wp.pl@[89.64.1.145]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 1 Apr 2023 12:47:39 +0200 Date: Sat, 1 Apr 2023 12:47:38 +0200 From: Stanislaw Gruszka To: Armin Wolf Cc: helmut.schaa@googlemail.com, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wifi: rt2x00: Fix memory leak when handling surveys Message-ID: <20230401104738.GA104104@wp.pl> References: <20230330215637.4332-1-W_Armin@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330215637.4332-1-W_Armin@gmx.de> X-WP-MailID: 3e9d8f7d9636ccf6fd6f75025492a895 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [0VMB] X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 30, 2023 at 11:56:37PM +0200, Armin Wolf wrote: > When removing a rt2x00 device, its associated channel surveys > are not freed, causing a memory leak observable with kmemleak: > > unreferenced object 0xffff9620f0881a00 (size 512): > comm "systemd-udevd", pid 2290, jiffies 4294906974 (age 33.768s) > hex dump (first 32 bytes): > 70 44 12 00 00 00 00 00 92 8a 00 00 00 00 00 00 pD.............. > 00 00 00 00 00 00 00 00 ab 87 01 00 00 00 00 00 ................ > backtrace: > [] __kmalloc+0x4b/0x130 > [] rt2800_probe_hw+0xc2b/0x1380 [rt2800lib] > [] rt2800usb_probe_hw+0xe/0x60 [rt2800usb] > [] rt2x00lib_probe_dev+0x21a/0x7d0 [rt2x00lib] > [] rt2x00usb_probe+0x1be/0x980 [rt2x00usb] > [] usb_probe_interface+0xe2/0x310 [usbcore] > [] really_probe+0x1a5/0x410 > [] __driver_probe_device+0x78/0x180 > [] driver_probe_device+0x1e/0x90 > [] __driver_attach+0xd2/0x1c0 > [] bus_for_each_dev+0x77/0xd0 > [] bus_add_driver+0x112/0x210 > [] driver_register+0x5c/0x120 > [] usb_register_driver+0x88/0x150 [usbcore] > [] do_one_initcall+0x44/0x220 > [] do_init_module+0x4c/0x220 > > Fix this by freeing the channel surveys on device removal. > > Tested with a RT3070 based USB wireless adapter. > > Fixes: 5447626910f5 ("rt2x00: save survey for every channel visited") > Signed-off-by: Armin Wolf Acked-by: Stanislaw Gruszka