Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2343969rwl; Sat, 1 Apr 2023 06:18:22 -0700 (PDT) X-Google-Smtp-Source: AKy350YNPCV7a8pSsTGrw3PIcowIemxeropyoPNeo5TjMjK+8+g18M7j7sSYDyS4+QwVaH496TG2 X-Received: by 2002:a05:6a20:2d9e:b0:db:e054:826a with SMTP id bf30-20020a056a202d9e00b000dbe054826amr14018756pzb.5.1680355101884; Sat, 01 Apr 2023 06:18:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680355101; cv=none; d=google.com; s=arc-20160816; b=EKlx3S9Q/SImIX2i0KzaQBwIKP1xIPWXPkkRfIg3SnE6UV/gQrwXD838yAV1M6MQIS 5ht4I4DOx4SK7IMqstOQvPw7ULrUYDXUQAHukRm6Bd/U9+0CiUC6AjFrPrzW1tYjVPtm KOmyxz+hlkLnr1K8YXTArtt02LRxQEnNfU/sZlbugR45hKb6dxpC2FV30uHxrsVI8EDi arr4gQfzaVYSlq+cR1TkEKAfbYgLx/QdFzCInjhabyEXly09PNtbzu3GjzcKIeZPBKN5 N2wih1Ai/IJ4fSfz8bx/zUEcE/CJCv7aKaku7Yd1iLHG9GbThtBbTc81hqwu8O87Llxl hc8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4n3970YVJgScIYsLOLOJ40pOvrh5QeCEXyrxgVLgCzM=; b=cqKH8GCUbnYwExDa1shCypP7EoAl92ojA/CcCbjFQ/aaJCBoQRN/vsxdFpH0kh8IJu 9IZDaxeP/bOlhZmWHOPEeuJLBvlgG5fVo/wltZ9zRkiOPw/2SMIJZ7U6odkxITdqzusb cTqkjX4NHqqv3iKyUmwaOl3oPCsvFixeXMKxx8xVPrCpgSp1ZBR4NNMs/RKrMvY48RZQ gKJD36qApfbrW5r4ZMBUoNJj1bohBYM15SkGPfAEkcDrg1pDsreCfruyI1PZjRBzZU65 pql4XWij+ygyAbBHMSF7x0e1JyjquaM0kOPzJESU63/JCu6Xk91GT+7FZe7zzvvRBjj1 Ie2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 79-20020a621852000000b0062a450c329dsi4776534pfy.93.2023.04.01.06.18.11; Sat, 01 Apr 2023 06:18:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbjDANGF (ORCPT + 99 others); Sat, 1 Apr 2023 09:06:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjDANGE (ORCPT ); Sat, 1 Apr 2023 09:06:04 -0400 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 185BBAF3E; Sat, 1 Apr 2023 06:06:03 -0700 (PDT) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1piava-0008Q2-1A; Sat, 01 Apr 2023 15:05:54 +0200 Date: Sat, 1 Apr 2023 14:05:48 +0100 From: Daniel Golle To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Sean Wang , Landen Chao , DENG Qingfang , Philipp Zabel , Sam Shih , Lorenzo Bianconi , John Crispin , Felix Fietkau Subject: Re: [PATCH net-next 13/15] net: dsa: mt7530: add support for 10G link modes for CPU port Message-ID: References: <89ef48606fdbe896705a57a65a85c22cae01936e.1680180959.git.daniel@makrotopia.org> <8f213456-af0b-3047-d7ec-865fecec8142@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8f213456-af0b-3047-d7ec-865fecec8142@arinc9.com> X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 01, 2023 at 11:56:43AM +0300, Arınç ÜNAL wrote: > On 30.03.2023 18:23, Daniel Golle wrote: > > The built-in switch of the MT7988 SoC is internally connected using > > a stateless 10G link. Add support for 10G interface modes to silence > > a warning otherwise occurring when the switch driver is setup. > > > > Reviewed-by: Andrew Lunn > > Signed-off-by: Daniel Golle > > --- > > drivers/net/dsa/mt7530.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > > index 3a4682e71e746..ac666da2d10dc 100644 > > --- a/drivers/net/dsa/mt7530.c > > +++ b/drivers/net/dsa/mt7530.c > > @@ -2618,6 +2618,9 @@ mt7531_mac_config(struct dsa_switch *ds, int port, unsigned int mode, > > case PHY_INTERFACE_MODE_1000BASEX: > > case PHY_INTERFACE_MODE_2500BASEX: > > /* handled in SGMII PCS driver */ > > + case PHY_INTERFACE_MODE_USXGMII: > > + case PHY_INTERFACE_MODE_10GKR: > > + /* internal stateless 10G link */ > > return 0; > > default: > > return -EINVAL; > > I think it'd be better to make this explicitly for the switch in the > MT7988 SoC. I decided to rather introduce mt7988_mac_config (a noop returning either 0 or -EINVAL), mt7988_mac_port_get_caps (allowing only USXGMII and 10000FD) and mt7988_cpu_port_config (setting CPU port bit in registers but not caring about interface mode and speed other than USXGMII/10000FD). The updated commit adding MT7988 is here: https://github.com/dangowrt/linux/commit/595c940cbee90b5dbdc8173974a007fefe641550 So then I dropped "net: dsa: mt7530: add support for 10G link modes for CPU port" because it is no longer needed if all this is done explicitely for MT7988. > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index e5347dd2521b..f7542c7f60e4 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2666,10 +2665,13 @@ mt7531_mac_config(struct dsa_switch *ds, int port, unsigned int mode, > case PHY_INTERFACE_MODE_1000BASEX: > case PHY_INTERFACE_MODE_2500BASEX: > /* handled in SGMII PCS driver */ > + return 0; > case PHY_INTERFACE_MODE_USXGMII: > case PHY_INTERFACE_MODE_10GKR: > - /* internal stateless 10G link */ > - return 0; > + if (priv->id == ID_MT7988) > + /* internal stateless 10G link */ > + return 0; > + > default: > return -EINVAL; > } > > Arınç