Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Apr 2023 09:43:51 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] iio: addac: stx104: Migrate to the regmap API
Message-ID: <ZCg1FyfcOvpLrMmH@fedora>
References: <cover.1679867815.git.william.gray@linaro.org>
 <4ebc1b6b609a086846420954b893e914fd395384.1679867815.git.william.gray@linaro.org>
 <ZCGBIAvr7OQLwNXv@smile.fi.intel.com>
 <20230401145121.1a64a113@jic23-huawei>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="KbeYdy2842VnTNzT"
Content-Disposition: inline
In-Reply-To: <20230401145121.1a64a113@jic23-huawei>
Precedence: bulk


--KbeYdy2842VnTNzT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 01, 2023 at 02:51:21PM +0100, Jonathan Cameron wrote:
>=20
> >=20
> > > +		do {
> > > +			err =3D regmap_read(priv->aio_ctl_map, STX104_ADC_STATUS, &adc_st=
atus);
> > > +			if (err)
> > > +				return err;
> > > +		} while (u8_get_bits(adc_status, STX104_CNV)); =20
> >=20
> > Hmm... Isn't it a potential infinite loop (e.g., ther hardware / firmwa=
re
> > is broken)?
> >=20
> > Why not using regmap_read_poll_timeout() (or its atomic variant, depend=
s on
> > the case)?
>=20
> Just to shortcut things as I'm looking at this.
> That's currently handled in patch 2.  Argument being this is a direct con=
version
> of existing code, whereas changing to xxx_poll_timeout() is an improvemen=
t.
>=20
> I'm fine with it just being rolled into first patch with a note in the pa=
tch
> description though if that works better.

I'm going to keep it as a separate follow-up patch because introducing a
timeout is enough of a functional change to risk a regression that
having it in a dedicated commit makes it easier to revert later if we
need to.

William Breathitt Gray

--KbeYdy2842VnTNzT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZCg1FwAKCRC1SFbKvhIj
KwfPAQC0qyFGLIKKcxO0aN0oqjFdF6fMtToeQek70VRbNnBA7gEAy9WIVmR1n/LP
XtuVVyKufI9v+lw3SM0J+9icvaYeLAU=
=DZ9m
-----END PGP SIGNATURE-----

--KbeYdy2842VnTNzT--