Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Apr 2023 21:52:45 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Nava kishore Manne <nava.kishore.manne@amd.com>
Cc:     mdf@kernel.org, hao.wu@intel.com, trix@redhat.com,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: select FPGA_BRIDGE for
 'Xilinx LogiCORE PR Decoupler'
Message-ID: <ZCg3LepdPRFtsAcb@yilunxu-OptiPlex-7050>
References: <20230327115103.106059-1-nava.kishore.manne@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230327115103.106059-1-nava.kishore.manne@amd.com>
Precedence: bulk

On 2023-03-27 at 17:21:03 +0530, Nava kishore Manne wrote:
> The Xilinx LogiCORE PR Decoupler depends on the FPGA_BRIDGE always and
> hence select it explicitly to make sure that it will be available all
> the time when PR decoupler is enabled.

FPGA_BRIDGE is available all the time if XILINX_PR_DECOUPLER is selected
by user. What's the problem now?

Thanks,
Yilun

> 
> Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
> ---
>  drivers/fpga/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 0a00763b9f28..71003f256c60 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -115,8 +115,8 @@ config ALTERA_FREEZE_BRIDGE
>  
>  config XILINX_PR_DECOUPLER
>  	tristate "Xilinx LogiCORE PR Decoupler"
> -	depends on FPGA_BRIDGE
>  	depends on HAS_IOMEM
> +	select FPGA_BRIDGE
>  	help
>  	  Say Y to enable drivers for Xilinx LogiCORE PR Decoupler
>  	  or Xilinx Dynamic Function eXchange AIX Shutdown Manager.
> -- 
> 2.25.1
>