Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Apr 2023 16:49:30 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Andrew Halaney <ahalaney@redhat.com>
Cc:     linux-kernel@vger.kernel.org, agross@kernel.org,
        andersson@kernel.org, konrad.dybcio@linaro.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org,
        bhupesh.sharma@linaro.org, wens@csie.org, jernej.skrabec@gmail.com,
        samuel@sholland.org, mturquette@baylibre.com,
        peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
        joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
        richardcochran@gmail.com, linux@armlinux.org.uk, veekhee@apple.com,
        tee.min.tan@linux.intel.com, mohammad.athari.ismail@intel.com,
        jonathanh@nvidia.com, ruppala@nvidia.com, bmasney@redhat.com,
        andrey.konovalov@linaro.org, linux-arm-msm@vger.kernel.org,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, ncai@quicinc.com,
        jsuraj@qti.qualcomm.com, hisunil@quicinc.com, echanude@redhat.com
Subject: Re: [PATCH net-next v3 07/12] net: stmmac: Remove some unnecessary
 void pointers
Message-ID: <ZChEeuyNJlL6mpPC@corigine.com>
References: <20230331214549.756660-1-ahalaney@redhat.com>
 <20230331214549.756660-8-ahalaney@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230331214549.756660-8-ahalaney@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?njKEqOpGFwUjeuyewXLj4yNrQYSiUXx65JT4j6MQAjPlmquSeC0SGard5F+9?=
 =?us-ascii?Q?PfJ0Trs7GsD/bCWb46ZkEH9m5eoK92oTzMXq6O3Krvm12fJcY/YeC49UjIin?=
 =?us-ascii?Q?Wuy17ZQMd1cWAN07luyzcAA5REh25KnK2Ge7HhpplOl6GVWEWhAvfmyA9zPd?=
 =?us-ascii?Q?J2YIAx+9EW9cn85ygiqrO7aFppgHVe8mALRLzatKySpSSY19krN5isobYQr7?=
 =?us-ascii?Q?JPyQ95fwPb/5v6dzuYowaI+eu8f45BTZlpJIX3KitnFCt2GfIcpdzUxluVkR?=
 =?us-ascii?Q?DULcml3HsAFoMBL9vrnwaipiBixPND++zv6a7QawnoFxmdTl5FTzK4FFA+wR?=
 =?us-ascii?Q?j4+Unv5/8iQP3elKhwxZRV3FlBByoNc1kI8Hcg/J+cMeZ1erdaBHOi7XCUKX?=
 =?us-ascii?Q?PY76iOIlyRLdcMDKYIWfQm+ugca44pIqp2n4FDTP6ohj9BniTJjE/hiU9xsi?=
 =?us-ascii?Q?HbMVZ9zQDGcRD7E7Eb6XWdMbHmeV0vBLXTdgn/zRufvG/FR6kF4fhpoXR0Oh?=
 =?us-ascii?Q?OcdMWLWCX6wmuRyftEaYzn+B402/2hVND/Mu7J8+kX8S+CzKAEfRoaQtV/I9?=
 =?us-ascii?Q?KfgJnNvUvtBHu1Sou6jVPoyw3QXNQW/LHrxApRJnnGlUtlIczUuz1gc/Qx7y?=
 =?us-ascii?Q?6bujcWEA/yUq5mCMj3rssX8zmM8wgBigMvGuQg+i4m7zn+LjemmkwyBB6hba?=
 =?us-ascii?Q?COxz1wHmr0UgUxv6HEDLGCmBnz2Nra0SBeH2x5BuPreNM0skhQSStd2W/Yq6?=
 =?us-ascii?Q?E5d25IFdPro12sVrzbntwOEi0CahA3O5ysCRBJe7wPW/HMQR0wKNN3c/+HQ0?=
 =?us-ascii?Q?wvzpdtt8Wk1FJwnKPv/zSsnYxPRQ7btInUuoJ+QdXRV5kzoiTugwtJJLGtgQ?=
 =?us-ascii?Q?kfA3eTJxsoU/4ukA5/Ec7NakWlK9PVE0c/e15/vjgl/tT83OSfclgdBe86t1?=
 =?us-ascii?Q?c+U3G+vdlhq2swVPR4FEUMqJmF2sEKtiFNGYlAhCY1ANWslwuK2hZlXJRd6n?=
 =?us-ascii?Q?YYrlsGof/RmX5y+USCk2aj7VltPLhxnu8ckmhT/u0RsEo19CPT+Ds9dfDRvy?=
 =?us-ascii?Q?YPvaruGEqKv5rQMn5ryfIdr9CZz0acJa7gtQW7YPe3rN0VRnZTatOUKS1Yoz?=
 =?us-ascii?Q?/cX2I2uq7X3NlXiLxuojQ/9661hQhcUytLhcGpEWCnmPc2gaXPT3Jla/0RjU?=
 =?us-ascii?Q?VgAjypAjavMhUWI1LGf1rm0KlyqGPvjaMDXzl+DqeNlmDpWtzHwor81ZipR2?=
 =?us-ascii?Q?eE5m1kHZ5mPXyvSeTghUzNdYKLipT30pKHtCf4OidzKRpWyNIqD/m6K8wENC?=
 =?us-ascii?Q?cHUroQRpQzY2dTxWw2innYrNNiROyLz4+drTLfbrk6j52p4RoaBq1Ftzkpq9?=
 =?us-ascii?Q?lhYVcucdt534F6/LnNK3rswm2f292Dq/5xD6cWG0ATnisy2bDWx89uhymGCx?=
 =?us-ascii?Q?BMlGDyIutohzvQBnLJbbhE+Om9E5LakOp73x8/52azQk0mxvcvuQF9tWriI+?=
 =?us-ascii?Q?MBqXU03mCvoW9pKyS0n0R2vRhLZEyVsucJujmmCq7EXFvUJQSGFNgFJnU723?=
 =?us-ascii?Q?rUxiN8ob4DgiquLMHwfO0cCW6YteqYrL1d3eylfvj5q0iHSrIg1I5+j0wlya?=
 =?us-ascii?Q?45njv5nTKwcqBe2kSW4OIhXmLX0fE0kevwLp13A9FqTUUxu4H5bnBSXkvhqD?=
 =?us-ascii?Q?jH3VqQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c13d6ede-b371-44d5-701e-08db32c053dd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2023 14:49:42.7524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M0TY7PKpuuLD9VIQKJm8JCWvYKz2XPwq7GLtFdEirzO5Yr2uTFzTCC9fGdMlyf87++NUGMm6wsJYkqQEuBFZHFzbexk2f6sSWTwJP4bPQPA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4789
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 31, 2023 at 04:45:44PM -0500, Andrew Halaney wrote:
> There's a few spots in the hardware interface where a void pointer is
> used, but what's passed in and later cast out is always the same type.
> 
> Just use the proper type directly.
> 
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
> 
> Changes since v2:
>     * New patch. In later patches refactoring hwif.h I touched these in
>       their first form (which was later dropped) and changed this as
>       part of that. But I thought the change was still good overall,
>       so I left this improvement in the series.

FWIIW, I am very pleased to see this kind of change.

Reviewed-by: Simon Horman <simon.horman@corigine.com>