Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "zbr@ioremap.net" <zbr@ioremap.net>,
        "brauner@kernel.org" <brauner@kernel.org>,
        "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "socketcan@hartkopp.net" <socketcan@hartkopp.net>,
        "petrm@nvidia.com" <petrm@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 1/6] netlink: Reverse the patch which removed filtering
Thread-Topic: [PATCH v4 1/6] netlink: Reverse the patch which removed
 filtering
Thread-Index: AQHZZCxJt7hHR9OT2UmzMPODBe2VMK8V1x8AgADu1gCAAA1sAIAADO8A
Date:   Sat, 1 Apr 2023 19:58:31 +0000
Message-ID: <82F9EDF5-9D7E-4FFC-9150-A978A36F26B9@oracle.com>
References: <20230331235528.1106675-1-anjali.k.kulkarni@oracle.com>
 <20230331235528.1106675-2-anjali.k.kulkarni@oracle.com>
 <20230331210920.399e3483@kernel.org>
 <88FD5EFE-6946-42C4-881B-329C3FE01D26@oracle.com>
 <20230401121212.454abf11@kernel.org>
In-Reply-To: <20230401121212.454abf11@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i7QOPwutXP2lRFYjWYmRsc2gpK5xKwSjhRAq5uYOg9xS7JSojoegrDdVqTue?=
 =?us-ascii?Q?+Ur/6azmYEidD39oDN5M5uZYRQ/RqXEdls9c+yTTSqr6XkoEBqhtjSvn4eqN?=
 =?us-ascii?Q?SjBYV00RbU0BZl0DzGyatenv+FFOUDvow3b+M5oZXNfrUGvyyI85tU/zlckV?=
 =?us-ascii?Q?wIjAABJKAul71Alz7N+RtvlClPdtaWWnR8u/McIWPIuaIQQtQNAl4Z6BLMR9?=
 =?us-ascii?Q?Aqsz6xCffIc6nVGdqAAQBhzzYCPJ/FwEXxIPlcAe+t8c4J6pbYGxHdEtsehc?=
 =?us-ascii?Q?BtRUliCZDsb0wzlCJeNZLzft7Uqf3NZx1oR7/UhTyCDUYIwKk73Nkl40hx2L?=
 =?us-ascii?Q?LC3hBSvx0ixcQfaH7jaGRnH8Uy6TrBK/7yDnafyp6PZxldgApASb2/dnhobV?=
 =?us-ascii?Q?/NCsot20yR138Q/o4yE90P48gZJXo+q/y0qqrgByd3i7LoxM+LDPvT24jAA6?=
 =?us-ascii?Q?IWHCpd/sFxoM3ri+YcTrrD3az97yW/MujpzgRZvzgjMnSAms2qGw9hfP4ojb?=
 =?us-ascii?Q?m1kzqHY4q44vrx5bmrVgVFGATsSKhFpdH6HAX/6LnBy6dSHu6bjMYjjlb7CV?=
 =?us-ascii?Q?I9b34pvBXepaskoSqSgOhC70+LEpG3Mq1I0tfRtp9tJEf2816U6JTShe5Iq8?=
 =?us-ascii?Q?uU1ZJk2XOnGf/gaj08uCANPIMd2pD4OExDuDRcZ3s/EfLjbMykB/KAmJE2JL?=
 =?us-ascii?Q?ZRz0Lt3UIowaHWN2VYyL6rjD4OgJWeAKqjinFxxPSzprTskIRTLcu+gb7TFd?=
 =?us-ascii?Q?6RvxRi5TckfInc7ufyprsE/ZflWw8alDXzQuxBrXPojLOc0/R9zzTkgxv7zF?=
 =?us-ascii?Q?1dqzRoKWd/Y/QFUGfh4rj7ApHmlMul8Fgk8URH86QjSUQP431GKfzAyAiuyT?=
 =?us-ascii?Q?NWR9XyddqUtHxFQUWv8gXbCzgTAjQGvVD2cMoVsthdjm1UwGcMfyzEwEiwFs?=
 =?us-ascii?Q?+iFdexPCFB3n1GFKjBcdRz6Uww0A1o9dbnjGEgPAdCbC8fEKoQBpxySXTDV8?=
 =?us-ascii?Q?RbDwT3/l1RmVxT0zCxcXWN/QnzxZonY66u8zqGANZUZgNyElfqBv+5IXroRE?=
 =?us-ascii?Q?5IZY7G/8+R3vixJDY1MNlPlHv0zFGTuEiji3ZRhGuO/kjwO6awG7kjiJdH7O?=
 =?us-ascii?Q?vX25bsW/QKGOvWslBhnooBcFSpIUzk8sCFFcR5uOfWj/C8XGr4hZnSh8Oe4o?=
 =?us-ascii?Q?nI+d610i0SzxI+9CybF1E0KeuLjehGSWSnrn8TSH4e+qkF35U1t5mcyCqXYW?=
 =?us-ascii?Q?v4y8QIF0Hgv+9ZsuMsYQgd66dRvzEA1TZivHGpZ7zQf8aUTSfLypNEmyaIJ6?=
 =?us-ascii?Q?KgDyIq/qJPd0ZkrGlupqfBiLg7wcVJsp6blkyHTXR1ZefUs+gCgCVv9TQHRT?=
 =?us-ascii?Q?DknfAywEcry26Ftu+fcZWFkXf5dORqx98cGOC6AnpIrCUEa9RSS7z+NUU7aq?=
 =?us-ascii?Q?fJOYQpbt3xRcoVbo6zVs5KhvGvkGvTkxOScYdZJYRgwZdw5nXFFPPlpOU2xy?=
 =?us-ascii?Q?fWFIIyvW1U89HRjotaK6KYwvE0rjgPXYmm8IY1u3OGjKnzeeobXhpwPSnTAV?=
 =?us-ascii?Q?tMfyy6a1sJEYp60h3PerGmupacJKMgSJsnog42GaP4lFP7LrSE2uBs13nebp?=
 =?us-ascii?Q?A6xksVqVZIeMTYYWB7hARn9JYoifax1lGk0EHTpzbiZK?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <996063E2CD0F354BB95FAD69499003BE@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?OrGOSAFDx8yz+SB9hVuRpeYdERWeemIRIAD7WdHj1+g6srTaPj4xajMS3lj9?=
 =?us-ascii?Q?fG/S7Po4SAcZvLaFYe+JrT/9/iUwMGPfZ37/QXYzbXYJkxBmtQz8enQtBz9v?=
 =?us-ascii?Q?UqgXPrjx3FV928tWyeto1xp/mp+BM88ZHwBaZEmqtZHZHSSBEXqE/d9+2Nhn?=
 =?us-ascii?Q?DAy/3YCWhNo6SKfdOVscmxlnFfzKDUFqAaLnA6ThWcMLuWJaaGIWpddjuXhj?=
 =?us-ascii?Q?Uq4AEjp3mXNGxan3PlWlnW1mxFcjqu3tB6wUJ0lUhrG7RY7wrlLMRhb85kBj?=
 =?us-ascii?Q?kxSqxtE/TVTmSe45WNyuraylrWe6cxQMEF/rKLXAgM4An2DDJ5zSd7zqb4BC?=
 =?us-ascii?Q?QgzKCmgvJ70tPsqqgPjOC6i8q+Mk4DMd1nz3RPTHTgESiAD5bxRvKfxhafxK?=
 =?us-ascii?Q?qWXgh87me97n22Kp5Xo7e0+H1NAUsj4ZCQgdOu8O/GwvnZ0kDmj2DCiHAF9F?=
 =?us-ascii?Q?Yq9JfXbXboz2fnK+m3fPruKaJJLK3naXnEssR/i95VsUXKy26IvLuQPjoK0O?=
 =?us-ascii?Q?4KqtqeNNXlFThVyQePDNzLORNUAH57bd969+jnVSbKsq/y0Y6eBjD1z2TXJT?=
 =?us-ascii?Q?/6sqqk2BRZT/0H97JLUaEvHVxBxEConOz8oEjK6j1/UiaGw50tpbLJpfuQwx?=
 =?us-ascii?Q?iPRs9eUPBtqRwMChQrxV1iMyguJxSEAlckJlPi2OCEYWXypMVpIcE6qAKx8B?=
 =?us-ascii?Q?deLn4tp1N0LC2aiWTgcd8HBdWf6F6NA1cYYtLrLgxskR81NU8C+tP7XfvhOq?=
 =?us-ascii?Q?0qNCTW5pHTngX274w7jLpmDgY46GphY2/Rds52O3oZ7iUfkeK65d3xoGEzzq?=
 =?us-ascii?Q?shwGr/hpFw7zmqyNFTV4n8WQQdoFbdqr+T2VprDi7cq7KEj5/upSYue+PRrG?=
 =?us-ascii?Q?6spQI4sPM5avPfd7OPvDsUYVYGxgLAIvnpDVFvCrYc730REPhWTK9yXSUKl+?=
 =?us-ascii?Q?sZGDic92TRZVj+ScAZlP5eX40I6Y5naz0V1W21ERo0kv02ByufbItCvbOtOj?=
 =?us-ascii?Q?gbsJVbT2Noosm/Hblbc0TufZJuWSxpex580vau9B5XUyK2+h+nFtxo1UC603?=
 =?us-ascii?Q?SGK4UHHzUazg1ZiTql9qvaWPktqMqA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4129.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e420e2fb-0d7d-4171-641a-08db32eb783f
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2023 19:58:31.9083
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UxpaDVBEHR2DriKuG3feE712jhSpjDV0wVJ9qydqKDIsLnIqxQFqU/vEiycp/sxTq6Vz9FgmOdDne3V7qtdOJIWAvxA83N4SKmo4khtHBI4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB6983
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-31_07,2023-03-31_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 mlxlogscore=999 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304010183
X-Proofpoint-ORIG-GUID: 72H8U_1ZjzdkgyCjUU6mOLR8qV2F5ncf
X-Proofpoint-GUID: 72H8U_1ZjzdkgyCjUU6mOLR8qV2F5ncf
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Apr 1, 2023, at 12:12 PM, Jakub Kicinski <kuba@kernel.org> wrote:
>=20
> On Sat, 1 Apr 2023 18:24:11 +0000 Anjali Kulkarni wrote:
>>> nit: slight divergence between __u32 and u32 types, something to clean
>>> up if you post v5 =20
>>=20
>> Thanks so much! Will do. Any comments on the connector patches?
>=20
> patch 3 looks fine as far as I can read thru the ugly in place casts
Thanks for reviewing!
> patch 5 looks a bit connector specific, no idea :S
> patch 6 does seem to lift the NET_ADMIN for group 0
>        and from &init_user_ns, CAP_NET_ADMIN to net->user_ns, CAP_NET_ADM=
IN
>        whether that's right or not I have no idea :(
I can move this back to &init_user_ns, and will look at group 0 too.=20
>=20
> Also, BTW, on the coding level:
>=20
> +static int cn_bind(struct net *net, int group)
> +{
> +	unsigned long groups =3D 0;
> +	groups =3D (unsigned long) group;
> +
> +	if (test_bit(CN_IDX_PROC - 1, &groups))
>=20
> Why not just
>=20
> +static int cn_bind(struct net *net, int group)
> +{
> +	if (group =3D=3D CN_IDX_PROC)
>=20
> ?
Will change this.
>=20
> Who are you hoping will merge this?
I am not sure. Whom should I contact to move this forward?