Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Apr 2023 16:23:32 -0400
From:   Brian Masney <masneyb@onstation.org>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Tom Rix <trix@redhat.com>, lars@metafoo.de, nathan@kernel.org,
        ndesaulniers@google.com, u.kleine-koenig@pengutronix.de,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, Chuhong Yuan <hslester96@gmail.com>,
        Brian Masney <bmasney@redhat.com>
Subject: Re: [PATCH] iio: tsl2772: remove unused prox_diode_mask variable
Message-ID: <ZCiSxK5JgY6g+0X+@onstation.org>
References: <20230327120823.1369700-1-trix@redhat.com>
 <ZCGVJOSBjKO3FKD6@smile.fi.intel.com>
 <20230401152028.30344b48@jic23-huawei>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230401152028.30344b48@jic23-huawei>
Precedence: bulk

On Sat, Apr 01, 2023 at 03:20:28PM +0100, Jonathan Cameron wrote:
> On Mon, 27 Mar 2023 16:07:48 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > On Mon, Mar 27, 2023 at 08:08:23AM -0400, Tom Rix wrote:
> > > clang with W=1 reports
> > > drivers/iio/light/tsl2772.c:576:24: error: variable
> > >   'prox_diode_mask' set but not used [-Werror,-Wunused-but-set-variable]
> > >         int i, ret, num_leds, prox_diode_mask;
> > >                               ^
> > > This variable is not used so remove it.  
> > 
> > While from the compilation point of view this is a correct fix, I think
> > we need to hear from the author (or interested stakeholders) about this
> > feature. Perhaps it should be enabled / fixed differently.
> > 
> 
> Superficially it looks like this value should have been stored to
> chip->settings.prox_diode
> 
> +CC people who might know...

Jonathan is correct about the proper fix and is this is my mistake. We
should just need to add this to the bottom of that function:

   chip->settings.prox_diode = prox_diode_mask;

Tom: I can fix this up next week, unless I hear from you otherwise that
you'll do it.

Brian