Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 1 Apr 2023 22:30:26 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Tom Rix <trix@redhat.com>
Cc:     nathan@kernel.org, ndesaulniers@google.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, Andreas Kemnade <andreas@kemnade.info>,
        "H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH] power: supply: twl4030-charger: remove unused cur_reg
 variable
Message-ID: <20230401203026.nzk4aygv7sr7quhe@mercury.elektranox.org>
References: <20230401113432.1873847-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mfptafjvzvw5h7cx"
Content-Disposition: inline
In-Reply-To: <20230401113432.1873847-1-trix@redhat.com>
Precedence: bulk


--mfptafjvzvw5h7cx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, Apr 01, 2023 at 07:34:32AM -0400, Tom Rix wrote:
> clang with W=3D1 reports
> drivers/power/supply/twl4030_charger.c:242:16: error: variable
>   'cur_reg' set but not used [-Werror,-Wunused-but-set-variable]
>         unsigned reg, cur_reg;
>                       ^
> This variable is not used so remove it.
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/power/supply/twl4030_charger.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/suppl=
y/twl4030_charger.c
> index 7adfd69fe649..5fa5b2311330 100644
> --- a/drivers/power/supply/twl4030_charger.c
> +++ b/drivers/power/supply/twl4030_charger.c
> @@ -239,7 +239,7 @@ static int twl4030_charger_update_current(struct twl4=
030_bci *bci)
>  {
>  	int status;
>  	int cur;
> -	unsigned reg, cur_reg;
> +	unsigned reg;
>  	u8 bcictl1, oldreg, fullreg;
>  	bool cgain =3D false;
>  	u8 boot_bci;
> @@ -357,11 +357,9 @@ static int twl4030_charger_update_current(struct twl=
4030_bci *bci)
>  	status =3D twl4030_bci_read(TWL4030_BCIIREF1, &oldreg);
>  	if (status < 0)
>  		return status;
> -	cur_reg =3D oldreg;
>  	status =3D twl4030_bci_read(TWL4030_BCIIREF2, &oldreg);
>  	if (status < 0)
>  		return status;
> -	cur_reg |=3D oldreg << 8;
>  	if (reg !=3D oldreg) {

I think the correct fix would be checking for (reg !=3D cur_reg) here.

-- Sebastian

>  		/* disable write protection for one write access for
>  		 * BCIIREF */
> --=20
> 2.27.0
>=20

--mfptafjvzvw5h7cx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIyBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQolF4ACgkQ2O7X88g7
+poTpw/4qkx6YJ+9tkZXsBoUZCdHoevMWeMg4FDt6d351ZoMDrZQyLWkrrQglRt6
rwnpaReLsWPt3q9TmZwsQ5892JZOZw5QMOUHyfGhlCBPp7wiY35PQ0Ihff0NyzoJ
KermMpArXyjcL4meLX8Q5NRlanU4TpDJwN03SmJziryemQI5ytwGxjBBXOcvq2hB
ck2Py7rSk8FgBAtNAA2tjV05eJL6rVRcD3JknZicSQ1F1CissdhlJS72OdUhRDVj
ydmiXywW1jTEMCMrXG92x3COR0Niv/MH0PjlMakYKrjUlD0hMXUsNLq4CRjknhRu
QnGF1kGtBSd15ANhNNcqOmSTyC7uWzvQTOnE1Ge0wbMNVXSNeHFvieRxN5EOEAC0
6Yt9xUDMQtMIVoBgzUk3GAdwSvW+mYBXC14UlTFzfRKh0GozhZSuG8Ee+rtEdovn
xqdTx/mxR75AWTiL/JsbAzrkCv3+Yt7sSwvcsz5CseNXxWvuWt/W7apC9HSvEd7O
L7eR1iaB42II2oJJBtZra0Lp4bscslMwmXK7B9/Zjkdn5SnD0vttBuBAEpgksU/4
thNJUNt8jtS0WSKbAjeJEWpFwxo9Yha1grP4wXqDgGpuEYZjUFLqp+C/HgSoS4sO
Onf5LmXisLayRqToKWUUEmRfOa+a/xTicUvyxrxeOVdmLOolbg==
=28ub
-----END PGP SIGNATURE-----

--mfptafjvzvw5h7cx--